Re: svn commit: r106214 - /apr/apr/trunk/CHANGES /apr/apr/trunk/configure.in /apr/apr/trunk/include/apr.h.in /apr/apr/trunk/misc/unix/rand.c

2004-11-22 Thread Paul Querna
Joe Orton wrote: On Mon, Nov 22, 2004 at 08:14:26PM -, Paul Querna wrote: Author: pquerna Date: Mon Nov 22 12:14:25 2004 New Revision: 106214 Modified: apr/apr/trunk/CHANGES apr/apr/trunk/configure.in apr/apr/trunk/include/apr.h.in apr/apr/trunk/misc/unix/rand.c Log: Use uuid_generate()

Re: svn commit: r106214 - /apr/apr/trunk/CHANGES /apr/apr/trunk/configure.in /apr/apr/trunk/include/apr.h.in /apr/apr/trunk/misc/unix/rand.c

2004-11-22 Thread Cliff Woolley
On Mon, 22 Nov 2004, Julian Foad wrote: > Joe Orton wrote: > > On Mon, Nov 22, 2004 at 08:14:26PM -, Paul Querna wrote: > >>+memcpy( (void*)uuid_data, (const void *)&g, sizeof( uuid_t ) ); > > > > Please watch the code style, Paul! > > Not sure exactly what Joe is referring to, but note th

Re: svn commit: r106214 - /apr/apr/trunk/CHANGES /apr/apr/trunk/configure.in /apr/apr/trunk/include/apr.h.in /apr/apr/trunk/misc/unix/rand.c

2004-11-22 Thread Julian Foad
Joe Orton wrote: On Mon, Nov 22, 2004 at 08:14:26PM -, Paul Querna wrote: +memcpy( (void*)uuid_data, (const void *)&g, sizeof( uuid_t ) ); Please watch the code style, Paul! Not sure exactly what Joe is referring to, but note that it should never be necessary to cast anything to "const voi

Re: svn commit: r106214 - /apr/apr/trunk/CHANGES /apr/apr/trunk/configure.in /apr/apr/trunk/include/apr.h.in /apr/apr/trunk/misc/unix/rand.c

2004-11-22 Thread Joe Orton
On Mon, Nov 22, 2004 at 08:14:26PM -, Paul Querna wrote: > Author: pquerna > Date: Mon Nov 22 12:14:25 2004 > New Revision: 106214 > > Modified: >apr/apr/trunk/CHANGES >apr/apr/trunk/configure.in >apr/apr/trunk/include/apr.h.in >apr/apr/trunk/misc/unix/rand.c > Log: > Use uuid_