Re: Precomit broken due to style violation. Why are failures getting past precommit?

2019-01-29 Thread Scott Wegner
This is great, and exactly solves the problem we were having. FindBugs will fail the compilation, but test flakes from another subproject can potentially mask the failures. On Tue, Jan 29, 2019, 3:56 PM Michael Luckey As currently we miss prominent exposures of check style warnings, I added >

Re: [VOTE] Release 2.10.0, release candidate #1

2019-01-29 Thread Ahmet Altay
-1, I ran into a new blocking issue: https://issues.apache.org/jira/browse/BEAM-6545 On Tue, Jan 29, 2019 at 4:08 PM Kenneth Knowles wrote: > I have done this in the least vulnerable way I can think of. I have filed > https://issues.apache.org/jira/browse/BEAM-6544 as a blocker to fix the >

Re: [VOTE] Release 2.10.0, release candidate #1

2019-01-29 Thread Kenneth Knowles
I have done this in the least vulnerable way I can think of. I have filed https://issues.apache.org/jira/browse/BEAM-6544 as a blocker to fix the release process. Kenn On Tue, Jan 29, 2019 at 3:07 PM Kenneth Knowles wrote: > Yes, the instructions for building the wheels includes inputting my

Re: Precomit broken due to style violation. Why are failures getting past precommit?

2019-01-29 Thread Michael Luckey
As currently we miss prominent exposures of check style warnings, I added another post build action to publish check style and findbugs warnings. [1] This will lead to - show check style/findbugs status right on the status page - links to followup pages with some graphs This could help to not

Re: BEAM-6324 / #7340: "I've pretty much given up on the PR being merged. I use my own fork for my projects"

2019-01-29 Thread Kenneth Knowles
On Mon, Jan 28, 2019 at 5:25 AM Łukasz Gajowy wrote: > IMHO, I don't think committers spend time watching new PRs coming up, but > they more likely act when pinged. So, we may need some automation in case a > contributor do not use github reviewed proposal. Auto reviewer assignment > seem too

Re: GSOC - Summer of Code, on Beam?

2019-01-29 Thread Kenneth Knowles
I believe for the ASF process the target is January 31, no? So basically if you have an idea, file it now! Kenn On Wed, Jan 16, 2019 at 2:23 AM Ismaël Mejía wrote: > Little reminder for the interested parties: > GSoC 2019 Org applications are now open! > Deadline is at February 6 at 20:00 UTC

Re: Enforce javadoc comments in public methods?

2019-01-29 Thread Kenneth Knowles
It sounds like there's widespread practices in our codebase that this new restriction might improve. Instead of /** Constructs XX object */ you could add a @deprecated and/or a TODO to migrate the code. Kenn On Mon, Jan 28, 2019 at 11:46 PM Reuven Lax wrote: > The problem is existing code. I

Re: ContainerLaunchException in precommit [BEAM-6497]

2019-01-29 Thread Kenneth Knowles
I retract my statement. I failed at web browsing. On Tue, Jan 29, 2019 at 3:14 PM Kenneth Knowles wrote: > Version 18.10.3 no longer appears on the linked page. > > On Tue, Jan 29, 2019 at 3:08 PM David Rieber wrote: > >> I am consistently hitting that error on this PR: >>

Re: ContainerLaunchException in precommit [BEAM-6497]

2019-01-29 Thread Kenneth Knowles
Version 18.10.3 no longer appears on the linked page. On Tue, Jan 29, 2019 at 3:08 PM David Rieber wrote: > I am consistently hitting that error on this PR: > https://github.com/apache/beam/pull/7631 > > > On Thu, Jan 24, 2019 at 9:14 AM Alex Amato wrote: > >> I have just seen it randomly

Re: ContainerLaunchException in precommit [BEAM-6497]

2019-01-29 Thread David Rieber
I am consistently hitting that error on this PR: https://github.com/apache/beam/pull/7631 On Thu, Jan 24, 2019 at 9:14 AM Alex Amato wrote: > I have just seen it randomly occur on presubmits. So I don't have a > reliable repro, unfortunately. > It may be a specific environmental issue to the

Re: [VOTE] Release 2.10.0, release candidate #1

2019-01-29 Thread Kenneth Knowles
Yes, the instructions for building the wheels includes inputting my ASF credentials into Travis-CI. I've been trying to understand why and what I can do instead. (The release guide says that the release script builds the binaries, but from what I can tell it does not. This makes sense because the

Fwd: Logging with Key-Value Tags

2019-01-29 Thread Akshay Balwally
Hi, I have logging statements in my Beam python code (using Flink). To improve debugging, I add tags to the log statement, which are then indexable on my log tool (kibana). However, the log statements that come out are not properly formatted. For example, statements like: logger.exception('this

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

2019-01-29 Thread Chamikara Jayalath
Congrats Etienne!! On Tue, Jan 29, 2019 at 6:30 AM Etienne Chauchot wrote: > Thanks for the warm welcome guys ! > > Etienne > > Le lundi 28 janvier 2019 à 14:28 +0100, Łukasz Gajowy a écrit : > > Thanks for your great work and congratulations! :) > > pon., 28 sty 2019 o 12:01 Gleb Kanterov

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

2019-01-29 Thread Etienne Chauchot
Thanks for the warm welcome guys ! Etienne Le lundi 28 janvier 2019 à 14:28 +0100, Łukasz Gajowy a écrit : > Thanks for your great work and congratulations! :) > > pon., 28 sty 2019 o 12:01 Gleb Kanterov napisał(a): > > Congratulations Etienne! > > > > > > > > On Mon, Jan 28, 2019 at 11:36

Re: [VOTE] Release 2.10.0, release candidate #1

2019-01-29 Thread Robert Bradshaw
The artifacts and signatures look good. But we're missing Python wheels. On Tue, Jan 29, 2019 at 6:08 AM Kenneth Knowles wrote: > > Ah, I did not close the staging repository. Thanks for letting me know. Try > now. > > Kenn > > On Mon, Jan 28, 2019 at 2:31 PM Ismaël Mejía wrote: >> >> I think