haven't contributed a while.
I mostly agree with Julian's comment. I'm not a native English speaker and
I think that line of comment could be interpreted as `humorous` or may be
at least intended to.
if I was contributing that feature, I would care more if there are comments
to help push my
I have not contributed to Calcite in a while but I keep up with whats going
in project and actively follow mailing list and jiras of interest.
I concur with Josh that it is public shaming and bullying. This is not
acceptable. Also, this is not an exception but pattern which tells me that
it will
You can see that I already responded to the comment and I don't really have
many further thoughts. I do agree though that it's true that this could
have been intended humorously and my reaction didn't acknowledge that. That
said, it's of course worth considering with comments intended to be
Hello,
First of all, thanks Hongze for working on this!
CALCITE-525 asks for throwing exceptions in certain circumstances and I
think the fix should focus exclusively on this.
Regarding the discussion about additional actions in case of an error
(omitting rows or logging) I believe it is useful
Let's not mince words about what this was: it was public shaming and
bullying.
Looking at that thread you linked: Zoltan was trying to describe why he
thought this was not a big problem. I can't say well enough whether he
is right or not (that's beside the point). It was completely
I’m not too concerned about the "Do you aim to get an entry in
accidentallyquadratic?” comment — it could be interpreted humorously, if it
were not at a end of a long, contentious review thread.
I am more concerned that it was a long contentious review thread. The problem
is that Vladimir is
Is it OK for a PMC member of this community to engage with a new contributor to
the project in this way?
https://github.com/apache/calcite/commit/b470a0cd4572c9f6c4c0e9b51926b97c5af58d3f#r30950660
I wanted to bring everyone´s attention to the issue because I do not believe
this behavior
Hi,
Thanks for opening this discussion and thank you all for your replies.
The reason why I would like to help solve CALCITE-525 is because I agree that
an function error should not easily break a large job, this "job" could
indicate a large ad-hoc query or a query on a stream, or like what
Zoltan Haindrich created CALCITE-2632:
-
Summary: Add hashCode and equals implementations to RexNode
Key: CALCITE-2632
URL: https://issues.apache.org/jira/browse/CALCITE-2632
Project: Calcite
Hi,
Thanks for opening this discussion and thank you all for your replies.
The reason why I would like to help solve CALCITE-525 is because I agree that
an function error should not easily break a large job, this "job" could
indicate a large ad-hoc query or a query on a stream, or like what
Zoltan Haindrich created CALCITE-2631:
-
Summary: Address small issues in case simplification
Key: CALCITE-2631
URL: https://issues.apache.org/jira/browse/CALCITE-2631
Project: Calcite
11 matches
Mail list logo
