Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Ralph Goers
On Aug 18, 2009, at 11:07 PM, Mario Ivankovits wrote: Hi! IF you use the options in a way which allows you to know which kind of filesystem will be used - good - but then the builder is just another layer, but not awkward and brittle I think. No. They are awkward and brittle. WebDavFileSys

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
Hi Ralph, Ralph Goers wrote at Mittwoch, 19. August 2009 00:54: > > On Aug 18, 2009, at 12:48 PM, Jörg Schaible wrote: > >> Hi Mario, >> >> Mario Ivankovits wrote: >> >>> I wont say that there aren't other ways to solve that, but using >>> simple >>> inheritance and instanceof is not the correc

RE: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Mario Ivankovits
Hi! > > IF you use the options in a way which allows you to know which kind > > of filesystem will be used - good - but then the builder is just > > another layer, but not awkward and brittle I think. > > No. They are awkward and brittle. WebDavFileSystemConfigBuilder > extends HttpFileSystemCon

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Ralph Goers
On Aug 18, 2009, at 12:48 PM, Jörg Schaible wrote: Hi Mario, Mario Ivankovits wrote: I wont say that there aren't other ways to solve that, but using simple inheritance and instanceof is not the correct way. +1 The current solution is somewhat unconventional, but this way you always

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Ralph Goers
On Aug 18, 2009, at 10:18 AM, Mario Ivankovits wrote: Hi! From personal experience, I've found working with it to be awkward and brittle. I would much prefer to have each provider subclass FileSystemOptions and provide the getters and setters there. Then, at least, you could do an instanceo

RE: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
Hi Mario, Mario Ivankovits wrote: > Hi! > >> From personal experience, I've found working with it >> to be awkward and brittle. I would much prefer to have each provider >> subclass FileSystemOptions and provide the getters and setters there. >> Then, at least, you could do an instanceof on the

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
sebb wrote: > On 18/08/2009, Jörg Schaible wrote: >> Hi Sebb, >> >> sebb wrote at Dienstag, 18. August 2009 14:48: >> >> >> >> + >> >> +/** >> >> + * {...@inheritdoc} >> >> + */ >> >> +public Object clone() { >> >> +FileSystemOptions clone = new FileSystemOpti

Re: [net] trunk vs branches

2009-08-18 Thread Niall Pemberton
On Thu, Aug 13, 2009 at 11:08 AM, Stefan Bodewig wrote: > Hi, > > over in Ant land we've received a bug report that Ant's ftp task > wouldn't compile against commons-net 2,0 because the IMAGE_FILE_TYPE > constant was removed from the FTP class. > > Given that trunk still has that constant, is trunk

RE: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Mario Ivankovits
Hi! > From personal experience, I've found working with it > to be awkward and brittle. I would much prefer to have each provider > subclass FileSystemOptions and provide the getters and setters there. Then, > at least, you could do an instanceof on the FileSystemOptions and determine > what optio

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread ralph.goers @dslextreme.com
On Tue, Aug 18, 2009 at 7:48 AM, sebb wrote: > On 18/08/2009, Jörg Schaible wrote: > > Hi Sebb, > > > > sebb wrote at Dienstag, 18. August 2009 14:48: > > > > > > >> + > > >> +/** > > >> + * {...@inheritdoc} > > >> + */ > > >> +public Object clone() { > > >> +

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread sebb
On 18/08/2009, Jörg Schaible wrote: > Hi Sebb, > > sebb wrote at Dienstag, 18. August 2009 14:48: > > > >> + > >> +/** > >> + * {...@inheritdoc} > >> + */ > >> +public Object clone() { > >> +FileSystemOptions clone = new FileSystemOptions(); > >> +clo

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
Hi Sebb, sebb wrote at Dienstag, 18. August 2009 14:48: >> + >> +/** >> + * {...@inheritdoc} >> + */ >> +public Object clone() { >> +FileSystemOptions clone = new FileSystemOptions(); >> +clone.options = new TreeMap(options); >> +return clone; >> +

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread sebb
On 18/08/2009, joe...@apache.org wrote: > Author: joehni > Date: Tue Aug 18 12:22:35 2009 > New Revision: 805384 > > URL: http://svn.apache.org/viewvc?rev=805384&view=rev > Log: > Make FileSystemOptions cloneable (VFS-278). > > Modified: > > commons/proper/vfs/trunk/core/src/main/java/o

[Commons Wiki] Trivial Update of "Daemon" by JaroslawStrzelecki

2009-08-18 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The following page has been changed by JaroslawStrzelecki: http://wiki.apache.org/commons/Daemon -- Hint:

[Commons Wiki] Update of "Daemon" by JaroslawStrzelecki

2009-08-18 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The following page has been changed by JaroslawStrzelecki: http://wiki.apache.org/commons/Daemon The comment on the change is: http://www.mkyong.com/tomcat/tomcat-error-prunsrvc-failed