[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-11-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-153517264 LGTM. Tested on an Android 6.0 device and on an Android 5.1.1 emulator and ran mobilespec. I'll merge this in at the end of the day. --- If your project

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-10-30 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152657405 @infil00p or @riknoll can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-10-30 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152661034 Oh, yeah "unit test" was probably not the right term. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-10-30 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/144 Fix CB-9752: FileEntry.getDirectory fails with assets filesystem Calls to FileEntry.getDirectory() on an asset entry would internally call the AssetFileSystem.listAssets() method

[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...

2015-10-30 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152660125 Where are you adding the unit test? We currently don't have a way to unit test plugins. --- If your project is set up for it, you can reply to this