Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-72178283
@purplecabbage I'll take care of it right away. Thanks for the heads-up.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-72090746
Looks good @oliversalzburg !
I don't see a CLA on file, but I'll accept this pr without it; also I see
you have already landed commits in apache cordova proj
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71988363
Okay, job's done (hopefully) :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71624489
@purplecabbage That sounds like a good idea. I'll do that, rebase on top
master and replace this feature branch. But it could take me a couple of hours
until I
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71620695
@oliversalzburg Oops, My last change to add the comment looks like it means
this has to be rebased.
I will pull this in, but I have one more small change.
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71618719
While I was looking into this, I realized what my original intention for
this change was. There is a certain period before `cordova-plugin-console` is
register
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71451850
Sounds good, thank you @oliversalzburg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71448490
Okay, I gave this a brief look and I'm not quite sure right now what the
point of `ConsoleHelper.cs` is. When I simply don't instantiate it, then
`cordova-plug
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71444942
@sgrebnov Humm, good point. I haven't really looked into why this code
isn't in the plugin. I'll see what I can do!
---
If your project is set up for it, you
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71434596
Hey @oliversalzburg, thank you for the proposed improvement! I think the
right place for it is
https://github.com/apache/cordova-plugin-console/
This way oth
GitHub user oliversalzburg opened a pull request:
https://github.com/apache/cordova-wp8/pull/66
Improved console logging
Previously, when using console.log facilities, only the first argument was
respected by ConsoleHelper, resulting in information not being logged when
`console.lo
12 matches
Mail list logo