Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159676223
Created https://issues.apache.org/jira/browse/CB-10080 for the disk-cache
issue.
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-labs/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159510578
@dblotsky, @stevengill, @shazron - Can you please advice on how to handle
this issue?
Should we switch to manual form parsing or to some lib supporting in-memory
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159401871
Do you think we can have some tests for this file? It's tedious to test it
manually with `curl`. :/
---
If your project is set up for it, you can reply to this
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/9#discussion_r45791335
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
port = process.env.PORT || 5000;
stringify =
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/9#discussion_r45791347
--- Diff: server.js ---
@@ -35,15 +37,34 @@ http.createServer(function (req, res) {
res.writeHead(200, {'Content-Type': 'text/plain'});
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/9#discussion_r45791371
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
port = process.env.PORT || 5000;
stringify =
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159403068
The `formidable` package writes `multipart-form` files to a temporary file
on disk. This is a **huge** security problem.
---
If your project is set up for it, you
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159402244
Also... hold on... this server actually writes the files to disk. It should
*not* do that.
---
If your project is set up for it, you can reply to this email and
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159411134
Please rewrite the form code so that nothing gets written to disk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159402700
I usually test it locally or with Heroku along with
cordova-plugin-test-framework and the plugin auto tests.
What do you mean by writing to disk? Can you please
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/9#discussion_r45790663
--- Diff: server.js ---
@@ -35,15 +37,34 @@ http.createServer(function (req, res) {
res.writeHead(200, {'Content-Type': 'text/plain'});
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/9#discussion_r45790741
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
port = process.env.PORT || 5000;
stringify =
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/9#discussion_r45791254
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
port = process.env.PORT || 5000;
stringify =
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-labs/pull/9
CB-9563 Mulptipart form data is used even a header named Content-Typeâ¦
⦠is present
Adds direct upload endpoint
[Jira issue](https://issues.apache.org/jira/browse/CB-9563)
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159399788
@dblotsky, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-labs/pull/9#issuecomment-159524926
We were only running this on one machine, and we took that machine down and
requested for it to be rebuilt, so no worries. As for the change, we should
either look
17 matches
Mail list logo
