[GitHub] cxf pull request: 3.1.x fixes

2016-04-19 Thread vikash32504
Github user vikash32504 commented on the pull request: https://github.com/apache/cxf/pull/131#issuecomment-212079691 Closing this ... I am doing change in Pull Request 132. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cxf pull request: - implemented AutoCloseable Client

2016-04-19 Thread cschneider
Github user cschneider commented on the pull request: https://github.com/apache/cxf/pull/124#issuecomment-212021075 No problem. I had also had a lot of issue with git when I started. I just updated the getting involved guide to show how you ideally structure your work in git.

[GitHub] cxf pull request: - implemented AutoCloseable Client

2016-04-19 Thread bilak
Github user bilak commented on the pull request: https://github.com/apache/cxf/pull/124#issuecomment-211990480 Yes I've reformatted the code because I didn't knew about your formatter (then I found it). So probably you can fix the issue better if you know how. Sorry for bundling all

[GitHub] cxf pull request: 3.1.x fixes

2016-04-19 Thread vikash32504
Github user vikash32504 closed the pull request at: https://github.com/apache/cxf/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cxf pull request: 3.1.x fixes

2016-04-19 Thread cschneider
Github user cschneider commented on the pull request: https://github.com/apache/cxf/pull/131#issuecomment-211961655 This PR does not seem to build. It also contains so many commits that it is not possible to do a review. --- If your project is set up for it, you can reply to this

[GitHub] cxf pull request: - implemented AutoCloseable Client

2016-04-19 Thread cschneider
Github user cschneider commented on the pull request: https://github.com/apache/cxf/pull/124#issuecomment-211961022 This code does not seem to build. I got somee checkstyle errors. I also think setting the classloader on the bus is not correct as the bus may be for a complete

[GitHub] cxf pull request: Fixes a NPE if Bus is not registered

2016-04-19 Thread cschneider
Github user cschneider commented on the pull request: https://github.com/apache/cxf/pull/129#issuecomment-211933996 I think this is still not correct. When a config update is received it takes a bus service from the ServiceTracker. The problem is that there is not only one CXF bus

[GitHub] cxf pull request: Remove reduntant blueprint

2016-04-19 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/cxf/pull/128#issuecomment-211919981 Thanks @cschneider. I made the change analogously to https://github.com/apache/cxf/commit/dae56b90c1de0dce1c00abe12108e364934eccf7 which removes the corresponding meta

[GitHub] cxf pull request: Tentative pom to create an OBR index for CXF run...

2016-04-19 Thread mrulli
Github user mrulli commented on the pull request: https://github.com/apache/cxf/pull/101#issuecomment-211885260 Yes, thanks! Matteo Il 19/apr/2016 01:31 PM, "Christian Schneider" ha scritto: > I added a repository some time ago. Do

[GitHub] cxf pull request: Remove reduntant blueprint

2016-04-19 Thread cschneider
Github user cschneider commented on the pull request: https://github.com/apache/cxf/pull/128#issuecomment-211880141 In your PR you also removed the meta type xml. I kept the meta type in my commit. I hope this is what you intended. --- If your project is set up for it, you can reply

[GitHub] cxf pull request: Tentative pom to create an OBR index for CXF run...

2016-04-19 Thread cschneider
Github user cschneider commented on the pull request: https://github.com/apache/cxf/pull/101#issuecomment-211867986 I added a repository some time ago. Do you think we can close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cxf pull request: Remove reduntant blueprint

2016-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cxf/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cxf pull request: Use !== instead of != for explicit type validati...

2016-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cxf/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cxf pull request: AccessTokenIntrospectionClient throws NPE

2016-04-19 Thread sberyozkin
Github user sberyozkin commented on the pull request: https://github.com/apache/cxf/pull/130#issuecomment-211834956 See also http://git-wip-us.apache.org/repos/asf/cxf/commit/2f881786, thanks --- If your project is set up for it, you can reply to this email and have your reply appear