[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-650694408 > @cgivre I've added more tests. The tests are not passing, something about `Error while applying rule DrillScanRule`. However, I was able to successfully execute the test queries

[GitHub] [drill] cgivre opened a new pull request #2089: Drill-7751: Add Storage Plugin for Splunk

cgivre opened a new pull request #2089: URL: https://github.com/apache/drill/pull/2089 # [DRILL-7751](https://issues.apache.org/jira/browse/DRILL-7751): Add Storage Plugin for Splunk ## Description # Drill Connector for Splunk This plugin enables Drill to query Splunk.

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446665500 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSPeer.java ## @@ -0,0 +1,107 @@ +/* + * Copyright (c) 2018-2020 Bowen

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446667334 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446669408 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446669488 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446669668 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446669892 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,202 @@ +/* + * Copyright (c) 2018-2020 Bowe

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-650790085 @cgivre it turned out what was blocking the tests was that the default number of providers in test config was too large, as a result IPFS could not find any other providers in tim

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r446672603 ## File path: contrib/storage-ipfs/src/test/java/org/apache/drill/exec/store/ipfs/TestIPFSQueries.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache S

[GitHub] [drill] KazydubB opened a new pull request #2090: DRILL-7759: Code compilation exception for queries containing (untyped) NULL

KazydubB opened a new pull request #2090: URL: https://github.com/apache/drill/pull/2090 # [DRILL-7759](https://issues.apache.org/jira/browse/DRILL-7759): Code compilation exception for queries containing (untyped) NULL ## Description (Please describe the change. If more than

[GitHub] [drill] vvysotskyi opened a new pull request #2091: DRILL-7761: Drill fails with OOM for the case of large filter conditions

vvysotskyi opened a new pull request #2091: URL: https://github.com/apache/drill/pull/2091 # [DRILL-7761](https://issues.apache.org/jira/browse/DRILL-7761): Drill fails with OOM for the case of large filter conditions ## Description Added threshold for the number of nodes that can

[GitHub] [drill] vvysotskyi merged pull request #2091: DRILL-7761: Drill fails with OOM for the case of large filter conditions

vvysotskyi merged pull request #2091: URL: https://github.com/apache/drill/pull/2091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] KazydubB merged pull request #2090: DRILL-7759: Code compilation exception for queries containing (untyped) NULL

KazydubB merged pull request #2090: URL: https://github.com/apache/drill/pull/2090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [drill] cgivre opened a new pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre opened a new pull request #2092: URL: https://github.com/apache/drill/pull/2092 # [DRILL-7763](https://issues.apache.org/jira/browse/DRILL-7763): Add Limit Pushdown to File Based Storage Plugins ## Description As currently implemented, when querying a file, Drill will r

[GitHub] [drill] vvysotskyi commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

vvysotskyi commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-653427039 @cgivre, how it would work for the case when there was created multiple fragments with their own scan? From the code, it looks like every fragment would read the same number of

[GitHub] [drill] KazydubB commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

KazydubB commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r449480526 ## File path: contrib/format-spss/src/test/java/org/apache/drill/exec/store/spss/TestSpssReader.java ## @@ -108,7 +108,7 @@ public void testStarQuery() th

[GitHub] [drill] KazydubB commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

KazydubB commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r449480526 ## File path: contrib/format-spss/src/test/java/org/apache/drill/exec/store/spss/TestSpssReader.java ## @@ -108,7 +108,7 @@ public void testStarQuery() th

[GitHub] [drill] KazydubB opened a new pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

KazydubB opened a new pull request #2093: URL: https://github.com/apache/drill/pull/2093 # [DRILL-7764](https://issues.apache.org/jira/browse/DRILL-7764): Cleanup warning messages in GuavaPatcher class ## Description Removed unnecessary logging of stack trace (on `WARN` level)

[GitHub] [drill] sanel commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

sanel commented on a change in pull request #2093: URL: https://github.com/apache/drill/pull/2093#discussion_r449513573 ## File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java ## @@ -73,7 +73,8 @@ private static void patchStopwatch() { logger.

[GitHub] [drill] sanel commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

sanel commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r449517251 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java ## @@ -180,6 +182,10 @@ private String byteArrayToString

[GitHub] [drill] KazydubB commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

KazydubB commented on a change in pull request #2093: URL: https://github.com/apache/drill/pull/2093#discussion_r449575594 ## File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java ## @@ -73,7 +73,8 @@ private static void patchStopwatch() { logg

[GitHub] [drill] cgivre commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-653570450 @vvysotskyi Thanks for taking a look. > @cgivre, how it would work for the case when there was created multiple fragments with their own scan? From the code, it looks l

[GitHub] [drill] cgivre commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-653570853 @vvysotskyi One more thought, it might make sense, if we can get the metastore sorted out, to do the same thing for parquet format. -

[GitHub] [drill] cgivre commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r451255529 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java ## @@ -180,6 +182,10 @@ private String byteArrayToStrin

[GitHub] [drill] KazydubB merged pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

KazydubB merged pull request #2093: URL: https://github.com/apache/drill/pull/2093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [drill] cgivre commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r451646671 ## File path: contrib/format-spss/src/test/java/org/apache/drill/exec/store/spss/TestSpssReader.java ## @@ -108,7 +108,7 @@ public void testStarQuery() thro

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r449034470 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSubScan.java ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-656170430 > Cleaning up the PR. I was thinking about the unit tests and it might be good to include unit tests using Mockito to mock up some of the various components. That way we can test

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452279329 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSchemaFactory.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apach

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452281356 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSchemaFactory.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452297400 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSubScan.java ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Soft

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452319373 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSubScan.java ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Soft

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452319560 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSubScan.java ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Soft

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452320145 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSSchemaFactory.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apach

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452320526 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to the

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452321021 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to the

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r452321224 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to the

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-656479289 > > Cleaning up the PR. I was thinking about the unit tests and it might be good to include unit tests using Mockito to mock up some of the various components. That way we can test

[GitHub] [drill] vvysotskyi commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

vvysotskyi commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-660886165 @cgivre, there already was a similar functionality for Parquet: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/colu

[GitHub] [drill] vvysotskyi commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

vvysotskyi commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r457178768 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/metastore/TestMetastoreWithEasyFormatPlugin.java ## @@ -1079,14 +1079,14 @@ public void

[GitHub] [drill] cgivre commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r458052450 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java ## @@ -172,6 +175,26 @@ private EasyGroupScan(final EasyG

[GitHub] [drill] oleg-zinovev opened a new pull request #2094: DRILL-7773: Incorrect conversion result to TIME_EPOCH_BE

oleg-zinovev opened a new pull request #2094: URL: https://github.com/apache/drill/pull/2094 # [DRILL-7773](https://issues.apache.org/jira/browse/DRILL-7773): Incorrect conversion result to TIME_EPOCH_BE ## Description An error was made when converting to BIG ENGIAN. First

[GitHub] [drill] cgivre merged pull request #2094: DRILL-7773: Incorrect conversion result to TIME_EPOCH_BE

cgivre merged pull request #2094: URL: https://github.com/apache/drill/pull/2094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [drill] vvysotskyi opened a new pull request #2095: DRILL-7774: IS NOT NULL predicate fails with NPE for the case of non-existing columns with non-deterministic expression

vvysotskyi opened a new pull request #2095: URL: https://github.com/apache/drill/pull/2095 # [DRILL-7774](https://issues.apache.org/jira/browse/DRILL-7774): IS NOT NULL predicate fails with NPE for the case of non-existing columns with non-deterministic expression ## Description

[GitHub] [drill] vvysotskyi commented on pull request #2095: DRILL-7774: IS NOT NULL predicate fails with NPE for the case of non-existing columns with non-deterministic expression

vvysotskyi commented on pull request #2095: URL: https://github.com/apache/drill/pull/2095#issuecomment-670187689 @KazydubB, could you please take a look? This is an automated message from the Apache Git Service. To respond t

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-670308917 @dbw9580 I'll take a look over the weekend. Thanks for the contribution! This is an automated message from the

[GitHub] [drill] vvysotskyi merged pull request #2095: DRILL-7774: IS NOT NULL predicate fails with NPE for the case of non-existing columns with non-deterministic expression

vvysotskyi merged pull request #2095: URL: https://github.com/apache/drill/pull/2095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r467667133 ## File path: contrib/storage-ipfs/src/test/java/org/apache/drill/exec/store/ipfs/TestIPFSGroupScan.java ## @@ -0,0 +1,162 @@ +package org.apache.drill.exec

[GitHub] [drill] dzamo opened a new pull request #2096: Documentation updates for 1.18

dzamo opened a new pull request #2096: URL: https://github.com/apache/drill/pull/2096 TODO: Either open a Jira ticket for this work and replace this description with the template below or avoid the Jira process for docs and delete the template below. # [DRILL-](https://issues.ap

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r467923605 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r467934049 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r467938032 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2096: Documentation updates for 1.18

cgivre commented on a change in pull request #2096: URL: https://github.com/apache/drill/pull/2096#discussion_r467897882 ## File path: _docs/configure-drill/configuration-options/030-planning-and-exececution-options.md ## @@ -27,11 +27,11 @@ You can run the following query to

[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18

cgivre commented on pull request #2096: URL: https://github.com/apache/drill/pull/2096#issuecomment-671404618 Could you also please add the following docs to the section about querying files? - https://github.com/apache/drill/tree/master/contrib/format-excel - https://github.com/a

[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18

cgivre commented on pull request #2096: URL: https://github.com/apache/drill/pull/2096#issuecomment-671406571 One more thing... take a look here https://github.com/apache/drill/tree/master/contrib/udfs for UDFs included with Drill. Ideally these should be in the docs. --

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r467971039 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r468469590 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r469626333 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673221990 @dbw9580 Please verify that the project builds and passes all checkstyles. `TestIPFQueries` fails the checkstyle due to unused imports. --

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r469944365 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache So

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r469960924 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470025016 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470035068 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache So

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673543986 > `TestIPFQueries` fails the checkstyle due to unused imports. @cgivre Hmm I don't see any unused imports in this file and my builds are passing. -

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673552669 @dbw9580 I redownloaded and it built for me. Please disregard previous comments. This is an automated message

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470080197 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470081506 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470082144 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470083089 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470084386 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470085822 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470086686 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470087561 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470088211 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470087869 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470089240 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470091514 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSScanSpec.java ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Soft

[GitHub] [drill] cgivre commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470091789 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSScanSpec.java ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Soft

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470098319 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470098319 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673615795 > I'm still having issues actually getting the unit tests that require the IPFS daemon to actually execute. @cgivre Actually I am having trouble making that test run, too. I

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673621711 If I leave an instance of Drill running and then run the unit test (`TestIPFSQueries`), then it passes. I think the unit test does not actually build and run a full Drill server,

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r469944365 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache So

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673636877 @dbw9580 The `ClusterTest` class is supposed to start a Drill cluster so that you can execute queries. You should not need to have a Drill cluster running for the unit tests t

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-673976246 @cgivre Does Drill support connections from IPv6 sockets? Is it enabled by default or do I have to toggle some configuration items? The "protocol family unavailable" error could b

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-674043258 @dbw9580 I believe Drill does support connections from IPv6 sockets. There was a recent PR for this in fact: (https://github.com/apache/drill/pull/1857) but I'm not sure if that i

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-674045895 The `connection rejected: /127.0.0.1:31011` failure was because sometimes Drill does not bind to the default ports (`31010, 31011, 31012`). It can bind to later ports like `31013,

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-674047192 > @dbw9580 I believe Drill does support connections from IPv6 sockets. There was a recent PR for this in fact: (#1857) but I'm not sure if that is directly relevant. > Were you

[GitHub] [drill] cgivre commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

cgivre commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-674062414 @dbw9580 The unit tests are passing now on my machine. This is an automated message from the Apache Git Service

[GitHub] [drill] dbw9580 commented on pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on pull request #2084: URL: https://github.com/apache/drill/pull/2084#issuecomment-674079153 @cgivre I tried to set the ports to their default values in c090a43, but it did not seem to do the trick. Why is that? ---

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470673138 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSCompat.java ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470673442 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache So

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470673620 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache So

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470675112 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSGroupScan.java ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache So

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470675247 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470676009 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSHelper.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470676371 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSScanSpec.java ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470676806 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSScanSpec.java ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] dbw9580 commented on a change in pull request #2084: DRILL-7745: Add storage plugin for IPFS

dbw9580 commented on a change in pull request #2084: URL: https://github.com/apache/drill/pull/2084#discussion_r470681998 ## File path: contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSStoragePluginConfig.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the

<    3   4   5   6   7   8   9   10   11   12   >