[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin

2018-12-12 Thread GitBox
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446661541 Thanks so much @vdiravka for merging it in. Yes, I plan to create a JIRA to track the di

[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin

2018-12-11 Thread GitBox
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446417564 @amansinha100 thanks for the review and approval. I have addressed your remaining review

[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin

2018-12-11 Thread GitBox
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446398113 @amansinha100 I have made the changes you requested. Please take a look. ---

[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin

2018-12-10 Thread GitBox
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446035159 @amansinha100 I have modified the rowkeyjoin pushdown testcases. With these changes I no