Re: [FalconJx] state/no state

2013-01-20 Thread Erik de Bruin
Mike, I see what you mean, I've added a TODO for me in the Class emitter (where all the members are gathered ;-)) EdB On Sun, Jan 20, 2013 at 1:14 PM, Michael Schmalle wrote: > > Quoting Avi Kessner : > >> Uneducated question here. >> If we can't read what is spit out, how can make tests to m

Re: [FalconJx] state/no state

2013-01-20 Thread Michael Schmalle
Quoting Avi Kessner : Uneducated question here. If we can't read what is spit out, how can make tests to make sure that the gestalt is correct? Erik didn't mean we can't read, when emitting all String data is pushed into a Writer buffer. If we can read what is spit out, why not read it a

Re: [FalconJx] state/no state

2013-01-20 Thread Avi Kessner
Uneducated question here. If we can't read what is spit out, how can make tests to make sure that the gestalt is correct? If we can read what is spit out, why not read it and remain stateless? I'm assuming that as time goes on, we'll want to read the output to optimize it on some level. brought t

Re: [FalconJx] state/no state

2013-01-20 Thread Michael Schmalle
I knew I looked at what you did before. I see no problem with that Erik, if you test visitAcessor() and it does what you want and in the context of the method which is to test the production of a unit where the unit here is a field and Object.defineProperty() so that is good. Does my thin

Re: [FalconJx] state/no state

2013-01-20 Thread Michael Schmalle
Hey, I have to admit, after this last week, I am not on my game. My kids finally decided to share what seems to be the flu, although I feel like I am in limbo with really getting sick, so my head and focus is being affected. :) I need to look at what you have done. But, there is a philoso

[FalconJx] state/no state

2013-01-20 Thread Erik de Bruin
Hi, I'm aware we're trying to keep a state-less thing going with FJx, but I ran into an issue that I'm not sure how to solve without adding some kind of storage (private variable) on the 'goog' emitter. The thing is that a property has/can have both a getter and a setter accessor. For a full 'goo