Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/234
LGTM. Merged with fixing the nitpick
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/234
---
[
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221373#comment-16221373
]
ASF GitHub Bot commented on GEARPUMP-359:
-
Github user manuzhang commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manu Zhang resolved GEARPUMP-359.
-
Resolution: Fixed
Fix Version/s: 0.8.5
Issue resolved by pull request 234
[
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221366#comment-16221366
]
ASF GitHub Bot commented on GEARPUMP-359:
-
Github user asfgit closed the pull request at:
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/233
@karol-brejna-i @huafengw rebased. Please help to verify again
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/234#discussion_r147105502
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala
---
@@ -209,7 +202,8 @@ class Subscription(
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/233
Docker image problem solved with
https://github.com/apache/incubator-gearpump/pull/235.
---
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/235
done!
---
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/235
#
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/235?src=pr=h1)
Report
> Merging
[#235](https://codecov.io/gh/apache/incubator-gearpump/pull/235?src=pr=desc)
GitHub user karol-brejna-i opened a pull request:
https://github.com/apache/incubator-gearpump/pull/235
Use alpine-based image for gearpump-runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/235
Great ! Could you create a JIRA issue and update your commit comment
accordingly ?
---
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/227#discussion_r147065810
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala ---
@@ -361,10 +358,11 @@ class TaskActor(
}
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/234
#
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr=h1)
Report
> Merging
[#234](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr=desc)
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/234
[GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ]
[
https://issues.apache.org/jira/browse/GEARPUMP-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220308#comment-16220308
]
ASF GitHub Bot commented on GEARPUMP-361:
-
Github user manuzhang commented on the issue:
Manu Zhang created GEARPUMP-361:
---
Summary: Build Gearpump Docker Image locally for integration test
Key: GEARPUMP-361
URL: https://issues.apache.org/jira/browse/GEARPUMP-361
Project: Apache Gearpump
[
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220294#comment-16220294
]
ASF GitHub Bot commented on GEARPUMP-359:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karol Brejna updated GEARPUMP-360:
--
Fix Version/s: 0.8.5
> gearpump-launcher image broken
> --
>
>
[
https://issues.apache.org/jira/browse/GEARPUMP-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220288#comment-16220288
]
Manu Zhang commented on GEARPUMP-360:
-
Fixed in
[
https://issues.apache.org/jira/browse/GEARPUMP-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manu Zhang resolved GEARPUMP-360.
-
Resolution: Fixed
> gearpump-launcher image broken
> --
>
>
Karol Brejna created GEARPUMP-360:
-
Summary: gearpump-launcher image broken
Key: GEARPUMP-360
URL: https://issues.apache.org/jira/browse/GEARPUMP-360
Project: Apache Gearpump
Issue Type: Bug
[
https://issues.apache.org/jira/browse/GEARPUMP-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220112#comment-16220112
]
ASF GitHub Bot commented on GEARPUMP-350:
-
Github user huafengw commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220074#comment-16220074
]
ASF GitHub Bot commented on GEARPUMP-359:
-
Github user codecov-io commented on the issue:
24 matches
Mail list logo