[PATCH] fix prep_walk_cache performance

2001-12-25 Thread Brian Pane
This change may be controversial, so I'm soliciting comments before committing... The prep_walk_cache() function in server/request.c is one of the slower parts of the core server. About 60% of its run time is due to the apr_pool_userdata_* functions. The attached patch eliminates the use of the

Re: setsockopt error

2001-12-25 Thread Aaron Bannert
On Tue, Dec 25, 2001 at 02:46:08PM -0500, Don Hughes wrote: > Apache2.0 > > If all of my vhosts are of the form: > > > > and if there is a Listen for a port (81) that does NOT appear in a VirtualHost > directive, then I get: > > ... [crit] (88)Socket operation on non-socket: make_sock: for

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2001-12-25 Thread Aaron Bannert
Ugh! I've been meaning to patch the prototype for apr_thread_exit for a long time (so that it takes an apr_status_t instead of a pointer), but it got lost in the shuffle. I'll see if I can fix this sometime this week so we don't have to have ackward &rv stuff like this. -aaron On Sun, Dec 23, 2

Re: related config directives

2001-12-25 Thread Aaron Bannert
On Mon, Dec 24, 2001 at 09:40:03AM -0800, Ryan Bloom wrote: > I thought of another reason to do this in the tree itself. The point of the config > tree is to keep the current config in memory. If you are going to modify the > config, you need to modify it in the tree. By doing to work on the tr

Re: PR 7492

2001-12-25 Thread Jeff Trawick
"Don Hughes" <[EMAIL PROTECTED]> writes: > I converted a working Apache1.3 server to Apache2.0 on a SuSE Linux system > with IPV6 support. > > All httpd.conf address references are in IPV4 format, all log/status/error messages > show all addresses in IPV4 format. However, I had to use IPV6 ad

Re: PR 7492

2001-12-25 Thread Jeff Trawick
"Don Hughes" <[EMAIL PROTECTED]> writes: > I converted a working Apache1.3 server to Apache2.0 on a SuSE Linux system > with IPV6 support. > > All httpd.conf address references are in IPV4 format, all log/status/error messages > show all addresses in IPV4 format. However, I had to use IPV6 ad

Re: setsockopt error

2001-12-25 Thread Jeff Trawick
"Don Hughes" <[EMAIL PROTECTED]> writes: > Apache2.0 > > If all of my vhosts are of the form: > > > > and if there is a Listen for a port (81) that does NOT appear in a VirtualHost > directive, then I get: > > ... [crit] (88)Socket operation on non-socket: make_sock: for address [::]:81,

Re: configtest

2001-12-25 Thread Brian Pane
It should be working now. I just committed some code to catch this case and exit with a more informative error message. --Brian Jeff Trawick wrote: >"Don Hughes" <[EMAIL PROTECTED]> writes: > >>Trying to use configtest with a httpd.conf file that has a line like: >> >> >> >>gives: >> >>../apach

Re: configtest

2001-12-25 Thread Jeff Trawick
"Don Hughes" <[EMAIL PROTECTED]> writes: > Trying to use configtest with a httpd.conf file that has a line like: > > > > gives: > > ../apachectl: line 187: 2066 Sementation fault $HTTPD - t cool! easy to reproduce, probably easy to fix... keep those cards and letters coming -- Jeff Tra

setsockopt error

2001-12-25 Thread Don Hughes
Apache2.0 If all of my vhosts are of the form: and if there is a Listen for a port (81) that does NOT appear in a VirtualHost directive, then I get: ... [crit] (88)Socket operation on non-socket: make_sock: for address [::]:81, setsockopt: (SO_REUSEADDR) ...don [EMAIL PROTECTED]

configtest

2001-12-25 Thread Don Hughes
Trying to use configtest with a httpd.conf file that has a line like: gives: ../apachectl: line 187: 2066 Sementation fault $HTTPD - t ...don [EMAIL PROTECTED]

Re: PR 7492

2001-12-25 Thread Don Hughes
I converted a working Apache1.3 server to Apache2.0 on a SuSE Linux system with IPV6 support. All httpd.conf address references are in IPV4 format, all log/status/error messages show all addresses in IPV4 format. However, I had to use IPV6 address in the VHosts sections or the incoming reques