Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-05-04 Thread William A. Rowe Jr.
On 5/3/2011 11:51 PM, pqf wrote: > Here is the new patch, anyone review it? I will commmit it if no one respond > :) +1, commit away

Re: Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-05-03 Thread pqf
0, sizeof(procnode->proc_id)); return APR_CHILD_DONE; } 2011-05-04 Ryan 发件人: "pqf" 发送时间: 2011-04-18 09:58 主 题: Re: mod_fcgid can kill all the services on the server via kill -15 -1 收件人: "dev" Hi, all Another question, does proc_wait_process() sho

Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-04-26 Thread Igor Seletskiy
Ryan, I like this approach. Do you want us to prepare a patch against latest version? Also, we never committed to apache project. Would it be enough if we post a patch here. Or what would be the process? On Sun, Apr 17, 2011 at 9:58 PM, pqf wrote: > Hi, all > Another question, does proc_wait_

Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-04-19 Thread Igor Seletskiy
I like this idea better then just checking for pid == -1, though sending TERM signal to 0 shouldn't be that damaging (if damaging at all). Mostly because apachectl will run in different process group, so it will not be killed, and will finish restarting apache. And unless apache itself is embeded o

Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-04-17 Thread pqf
Hi, all Another question, does proc_wait_process() should update procnode->proc_id to 0 too? or else mod_fcgid may send a signal to another irrelevant process while apache is shutting down? I don't follow up mod_fcgid for a while, I just took a glance, maybe it's updated somewhere else? By the w

mod_fcgid can kill all the services on the server via kill -15 -1

2011-04-17 Thread Igor Seletskiy
Hello, There is a very interesting, and quite a rare bug in mod_fcgid. It is easy to reproduce if you can cause fork to fail (which can be done with CloudLinux -- if anyone wants to replicate it). *Here is how it works: * mod_fcgid tries to spawn a new process (proc_spawn_process in fcgid_proc_un