Re: CacheIgnoreHeaders not working correctly

2009-02-11 Thread Ruediger Pluem
On 02/11/2009 02:10 PM, Lars Eilebrecht wrote: > Ruediger Pluem wrote: > >> http://svn.apache.org/viewvc?view=rev&revision=649162 >> http://svn.apache.org/viewvc?view=rev&revision=649791 > > Hmm ... I'm not sure I understand the logic in this one: > > CACHE_DECLARE(apr_table_t *)ap_cache_cache

Re: CacheIgnoreHeaders not working correctly

2009-02-11 Thread Lars Eilebrecht
Ruediger Pluem wrote: > http://svn.apache.org/viewvc?view=rev&revision=649162 > http://svn.apache.org/viewvc?view=rev&revision=649791 Hmm ... I'm not sure I understand the logic in this one: CACHE_DECLARE(apr_table_t *)ap_cache_cacheable_headers_out(request_rec * r) { apr_table_t *headers_ou

Re: CacheIgnoreHeaders not working correctly

2009-02-10 Thread Graham Leggett
Ruediger Pluem wrote: Have a look at http://svn.apache.org/viewvc?view=rev&revision=649162 http://svn.apache.org/viewvc?view=rev&revision=649791 This needed an MMN bump though, so it won't work for v2.2. :( Regards, Graham -- smime.p7s Description: S/MIME Cryptographic Signature

Re: CacheIgnoreHeaders not working correctly

2009-02-10 Thread Ruediger Pluem
On 02/09/2009 09:21 PM, Lars Eilebrecht wrote: > Hi, > > I have a question about the header handling logic of > mod_cache/mod_disk_cache. > > With an installation running mod_disk_cache and a custom module > which fiddles with Cookie and Set-Cookie headers I am running into > the problem that m

Re: CacheIgnoreHeaders not working correctly

2009-02-10 Thread Lars Eilebrecht
Lars Eilebrecht wrote: [...] > So it copies r->headers_out to the local headers_out variable, and > removes all unwanted headers. However, then r->err_headers_out > gets merged into headers_out which is then stored in the cache. > > Is there a reason why this is done? This could lead to quite a >

CacheIgnoreHeaders not working correctly

2009-02-09 Thread Lars Eilebrecht
Hi, I have a question about the header handling logic of mod_cache/mod_disk_cache. With an installation running mod_disk_cache and a custom module which fiddles with Cookie and Set-Cookie headers I am running into the problem that mod_disk_cache was storing Set-Cookie headers in the cache. It is