Re: How to align shm in an neat way?

2012-08-15 Thread Rainer Jung
On 14.08.2012 23:20, Jim Jagielski wrote: slotmem handles this well, afaict ;) The fix applied in r1373270 which Joe also had a look at is very similar to the handling in slotmem. I added some macros as proposed by Joe. Fortunately the code in shmcb already did all the address calculations u

Re: How to align shm in an neat way?

2012-08-14 Thread Jim Jagielski
slotmem handles this well, afaict ;) On Aug 13, 2012, at 12:32 PM, Jeff Trawick wrote: > On Mon, Aug 13, 2012 at 12:30 PM, Rainer Jung wrote: >> Hi, >> >> PR 53040 reveals, that mod_socache_shmcb has an alignment problem. One of >> the three structs mapped into shm contains an apr_time_t membe

Re: How to align shm in an neat way?

2012-08-14 Thread Joe Orton
On Mon, Aug 13, 2012 at 10:19:47PM +0200, Rainer Jung wrote: > I went the "choose right alignment" way now: > > http://people.apache.org/~rjung/patches/mod_socache_shmcb-alignment.patch > > It actually wasn't that complicated. Alignment problems never die with that code! +1, that looks good, mi

Re: How to align shm in an neat way?

2012-08-13 Thread Rainer Jung
On 13.08.2012 21:02, Rainer Jung wrote: On 13.08.2012 19:40, Jeff Trawick wrote: On Mon, Aug 13, 2012 at 1:27 PM, Rainer Jung wrote: On 13.08.2012 18:32, Jeff Trawick wrote: On Mon, Aug 13, 2012 at 12:30 PM, Rainer Jung wrote: Hi, PR 53040 reveals, that mod_socache_shmcb has an alignment

Re: How to align shm in an neat way?

2012-08-13 Thread Rainer Jung
On 13.08.2012 19:40, Jeff Trawick wrote: On Mon, Aug 13, 2012 at 1:27 PM, Rainer Jung wrote: On 13.08.2012 18:32, Jeff Trawick wrote: On Mon, Aug 13, 2012 at 12:30 PM, Rainer Jung wrote: Hi, PR 53040 reveals, that mod_socache_shmcb has an alignment problem. One of the three structs mapped

Re: How to align shm in an neat way?

2012-08-13 Thread Jeff Trawick
On Mon, Aug 13, 2012 at 1:27 PM, Rainer Jung wrote: > On 13.08.2012 18:32, Jeff Trawick wrote: >> >> On Mon, Aug 13, 2012 at 12:30 PM, Rainer Jung >> wrote: >>> >>> Hi, >>> >>> PR 53040 reveals, that mod_socache_shmcb has an alignment problem. One of >>> the three structs mapped into shm contains

Re: How to align shm in an neat way?

2012-08-13 Thread Rainer Jung
On 13.08.2012 18:32, Jeff Trawick wrote: On Mon, Aug 13, 2012 at 12:30 PM, Rainer Jung wrote: Hi, PR 53040 reveals, that mod_socache_shmcb has an alignment problem. One of the three structs mapped into shm contains an apr_time_t member, which at least on Sparc is 8 Bytes, whereas for 32 bit bu

Re: How to align shm in an neat way?

2012-08-13 Thread Jeff Trawick
On Mon, Aug 13, 2012 at 12:30 PM, Rainer Jung wrote: > Hi, > > PR 53040 reveals, that mod_socache_shmcb has an alignment problem. One of > the three structs mapped into shm contains an apr_time_t member, which at > least on Sparc is 8 Bytes, whereas for 32 bit builds long is only 4 Bytes. > > Curr

How to align shm in an neat way?

2012-08-13 Thread Rainer Jung
Hi, PR 53040 reveals, that mod_socache_shmcb has an alignment problem. One of the three structs mapped into shm contains an apr_time_t member, which at least on Sparc is 8 Bytes, whereas for 32 bit builds long is only 4 Bytes. Currently everything is aligned for 4 Bytes, so we get bus error