[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nit0906 commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r942455212 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndex.java: ## @@ -765,6 +765,8 @@ private static void addNonFullTextConstraints(Li

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nfsantos commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r942448782 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndex.java: ## @@ -765,6 +765,8 @@ private static void addNonFullTextConstraints(L

[GitHub] [jackrabbit-oak] nfsantos commented on pull request #644: OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and without index.

nfsantos commented on PR #644: URL: https://github.com/apache/jackrabbit-oak/pull/644#issuecomment-1210664665 > > > nitpicking: May be we should add common in SameQueryResultsWithAndWithoutIndexTest, to indicate that it is a common test for both lucene and elastic. > > > > > > @t

[GitHub] [jackrabbit-oak] reschke merged pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

reschke merged PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbi

[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #662: OAK-9893 Prefetch for queries

joerghoh commented on code in PR #662: URL: https://github.com/apache/jackrabbit-oak/pull/662#discussion_r942366479 ## oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java: ## @@ -576,6 +577,8 @@ public Oak with(@NotNull Whiteboard whiteboard) { newSettings.se

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #662: OAK-9893 Prefetch for queries

nit0906 commented on code in PR #662: URL: https://github.com/apache/jackrabbit-oak/pull/662#discussion_r942332159 ## oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryEngineSettings.java: ## @@ -59,7 +61,9 @@ public class QueryEngineSettings implements QueryEngineSet

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #644: OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and withou

nfsantos commented on code in PR #644: URL: https://github.com/apache/jackrabbit-oak/pull/644#discussion_r942126583 ## oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/SameQueryResultsWithAndWithoutIndexTest.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apac

[GitHub] [jackrabbit-oak] nit0906 commented on pull request #644: OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and without index.

nit0906 commented on PR #644: URL: https://github.com/apache/jackrabbit-oak/pull/644#issuecomment-1210264254 > > nitpicking: May be we should add common in SameQueryResultsWithAndWithoutIndexTest, to indicate that it is a common test for both lucene and elastic. > > @thomasmueller su

[GitHub] [jackrabbit-oak] nfsantos commented on pull request #644: OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and without index.

nfsantos commented on PR #644: URL: https://github.com/apache/jackrabbit-oak/pull/644#issuecomment-1210261265 > nitpicking: May be we should add common in SameQueryResultsWithAndWithoutIndexTest, to indicate that it is a common test for both lucene and elastic. @thomasmueller suggest

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nit0906 commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r942013257 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndex.java: ## @@ -765,6 +765,8 @@ private static void addNonFullTextConstraints(Li

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nit0906 commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r942009423 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndex.java: ## @@ -765,6 +765,8 @@ private static void addNonFullTextConstraints(Li

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #662: OAK-9893 Prefetch for queries

nit0906 commented on code in PR #662: URL: https://github.com/apache/jackrabbit-oak/pull/662#discussion_r942003183 ## oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java: ## @@ -576,6 +577,8 @@ public Oak with(@NotNull Whiteboard whiteboard) { newSettings.set

[GitHub] [jackrabbit-oak] anchela merged pull request #661: OAK-9892 : Improve query statement for ExternalGroupPrincipalProvider..findPrincipals

anchela merged PR #661: URL: https://github.com/apache/jackrabbit-oak/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbi

[GitHub] [jackrabbit-oak] anchela merged pull request #660: OAK-9868 : Introduce interface to extract tree from users

anchela merged PR #660: URL: https://github.com/apache/jackrabbit-oak/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbi

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #660: OAK-9868 : Introduce interface to extract tree from users

anchela commented on code in PR #660: URL: https://github.com/apache/jackrabbit-oak/pull/660#discussion_r941388377 ## oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/DynamicGroupUtil.java: ## @@ -65,7 +66,7 @@ static

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #644: OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and without

tihom88 commented on code in PR #644: URL: https://github.com/apache/jackrabbit-oak/pull/644#discussion_r941373857 ## oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/SameQueryResultsWithAndWithoutIndexTest.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apach

[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

joerghoh commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r941273824 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStoreThrottling.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #660: OAK-9868 : Introduce interface to extract tree from users

joerghoh commented on code in PR #660: URL: https://github.com/apache/jackrabbit-oak/pull/660#discussion_r941256920 ## oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/DynamicGroupUtil.java: ## @@ -65,7 +66,7 @@ static

[GitHub] [jackrabbit-oak] anchela opened a new pull request, #660: OAK-9868 : Introduce interface to extract tree from users

anchela opened a new pull request, #660: URL: https://github.com/apache/jackrabbit-oak/pull/660 @joerghoh , i would appreciate if you had time to take a look at this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

reschke commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r941032932 ## oak-upgrade/pom.xml: ## @@ -134,12 +139,12 @@ org.apache.jackrabbit jackrabbit-core - ${jackrabbit.version} + ${jackrabbit.test.ver

[GitHub] [jackrabbit-oak] anchela merged pull request #648: OAK-9803 : Extend DynamicSyncHandler to allow for dynamic groups

anchela merged PR #648: URL: https://github.com/apache/jackrabbit-oak/pull/648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbi

[GitHub] [jackrabbit-oak] anchela commented on pull request #648: OAK-9803 : Extend DynamicSyncHandler to allow for dynamic groups

anchela commented on PR #648: URL: https://github.com/apache/jackrabbit-oak/pull/648#issuecomment-1209102966 @telegrapher , i am going to merge the PR to avoid running into conflicts. i will keep the jira ticket open and will address additional review-findings as they appear. hope that is o

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

reschke commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r941048533 ## oak-upgrade/pom.xml: ## @@ -31,6 +31,11 @@ Oak upgrade Tooling for upgrading Jackrabbit repositories to Oak + + +2.20.4 Review Comment: it

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

anchela commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r941046395 ## oak-upgrade/pom.xml: ## @@ -31,6 +31,11 @@ Oak upgrade Tooling for upgrading Jackrabbit repositories to Oak + + +2.20.4 Review Comment: @r

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

reschke commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r941032932 ## oak-upgrade/pom.xml: ## @@ -134,12 +139,12 @@ org.apache.jackrabbit jackrabbit-core - ${jackrabbit.version} + ${jackrabbit.test.ver

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

reschke commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r941031859 ## oak-upgrade/pom.xml: ## @@ -31,6 +31,11 @@ Oak upgrade Tooling for upgrading Jackrabbit repositories to Oak + + +2.20.4 Review Comment: Th

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #648: OAK-9803 : Extend DynamicSyncHandler to allow for dynamic groups

anchela commented on code in PR #648: URL: https://github.com/apache/jackrabbit-oak/pull/648#discussion_r941018006 ## oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java: ## @@ -272,6 +272,23 @@ public cl

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

anchela commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r940970815 ## oak-upgrade/pom.xml: ## @@ -31,6 +31,11 @@ Oak upgrade Tooling for upgrading Jackrabbit repositories to Oak + + +2.20.4 Review Comment: hi

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nfsantos commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r940965614 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -746,15 +746,14 @@ private static Query

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nfsantos commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r940965614 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -746,15 +746,14 @@ private static Query

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nfsantos commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r940963346 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -746,15 +746,14 @@ private static Query

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #659: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

mreutegg commented on code in PR #659: URL: https://github.com/apache/jackrabbit-oak/pull/659#discussion_r940949640 ## oak-upgrade/pom.xml: ## @@ -134,12 +139,12 @@ org.apache.jackrabbit jackrabbit-core - ${jackrabbit.version} + ${jackrabbit.test.ve

[GitHub] [jackrabbit-oak] reschke closed pull request #658: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5

reschke closed pull request #658: OAK-9720: Update Oak 1.22 to Jackrabbit 2.20.5 URL: https://github.com/apache/jackrabbit-oak/pull/658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] nit0906 merged pull request #653: OAK-9878 | OAK-9858 | Fixing failing(Ignored) tests for ES

nit0906 merged PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbi

[GitHub] [jackrabbit-oak] telegrapher commented on a diff in pull request #648: OAK-9803 : Extend DynamicSyncHandler to allow for dynamic groups

telegrapher commented on code in PR #648: URL: https://github.com/apache/jackrabbit-oak/pull/648#discussion_r940742613 ## oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java: ## @@ -272,6 +272,23 @@ publi

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

thomasmueller commented on code in PR #657: URL: https://github.com/apache/jackrabbit-oak/pull/657#discussion_r940367285 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -746,15 +746,14 @@ private static

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #657: OAK-9881 - Unreachable code in the logic that processes like constraints in Elastic

nfsantos opened a new pull request, #657: URL: https://github.com/apache/jackrabbit-oak/pull/657 Fix unreachable code in Elastic plugin when processing like constraints. The intention of the unreachable code is to transform constraints of the form "like abc%" into ElasticSearch prefix queri

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #653: OAK-9878 | OAK-9858 | Fixing failing(Ignored) tests for ES

nit0906 commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r940119212 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -225,7 +227,12 @@ public Query baseQuery

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #653: OAK-9878 | OAK-9858 | Fixing failing(Ignored) tests for ES

nit0906 commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r940107910 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -740,27 +747,32 @@ private static Query

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #653: OAK-9878 | OAK-9858 | Fixing failing(Ignored) tests for ES

nfsantos commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r940034971 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -740,27 +747,32 @@ private static Query

[GitHub] [jackrabbit-oak] mreutegg merged pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg merged PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] mreutegg merged pull request #656: OAK-9883: Add assertion to CacheWarmingTest

mreutegg merged PR #656: URL: https://github.com/apache/jackrabbit-oak/pull/656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #656: OAK-9883: Add assertion to CacheWarmingTest

mreutegg opened a new pull request, #656: URL: https://github.com/apache/jackrabbit-oak/pull/656 New assertion is not stable. Disable for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] mreutegg merged pull request #655: OAK-9826: Flaky test: DataStoreBlobStoreStatsTest

mreutegg merged PR #655: URL: https://github.com/apache/jackrabbit-oak/pull/655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #653: OAK-9878 | OAK-9858 | Fixing failing(Ignored) tests for ES

fabriziofortino commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r939551385 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -225,7 +227,14 @@ public Query b

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #653: OAK-9858 | Fixing failing(Ignored) tests for ES

nit0906 commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r939521373 ## oak-core/src/test/java/org/apache/jackrabbit/oak/query/AbstractQueryTest.java: ## @@ -227,7 +228,16 @@ protected void test(String file) throws Exception {

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #653: OAK-9858 | Fixing failing(Ignored) tests for ES

nit0906 commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r939518445 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -225,7 +226,12 @@ public Query baseQuery

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #653: OAK-9858 | Fixing failing(Ignored) tests for ES

nit0906 commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r939518445 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -225,7 +226,12 @@ public Query baseQuery

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #653: OAK-9858 | Fixing failing(Ignored) tests for ES

fabriziofortino commented on code in PR #653: URL: https://github.com/apache/jackrabbit-oak/pull/653#discussion_r939507963 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -225,7 +226,12 @@ public Query b

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #655: OAK-9826: Flaky test: DataStoreBlobStoreStatsTest

mreutegg opened a new pull request, #655: URL: https://github.com/apache/jackrabbit-oak/pull/655 The statistics update interval is one second. Give the test a bit more time than that and increase maximum wait time to 1.5 seconds. -- This is an automated message from the Apache Git Service

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg commented on PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#issuecomment-1206548350 > a test case that would have failed without this fix @stefan-egli there is now a simple test that illustrates why changes to NodeDocumentCache are necessary. `NodeDocumentCac

[GitHub] [jackrabbit-oak] mreutegg merged pull request #654: OAK-9883: Add assertion to CacheWarmingTest

mreutegg merged PR #654: URL: https://github.com/apache/jackrabbit-oak/pull/654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #651: OAK-9880 : simplify rgc query

mreutegg commented on PR #651: URL: https://github.com/apache/jackrabbit-oak/pull/651#issuecomment-1206428802 > one concern that just came to mind with this: obviously this would increase the number of queries executed - and that scales with the number of clusterNodeIds in use... We

[GitHub] [jackrabbit-oak] mreutegg merged pull request #637: OAK-9854: Remove version information from Oak pages

mreutegg merged PR #637: URL: https://github.com/apache/jackrabbit-oak/pull/637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] kwin merged pull request #592: OAK-9800 update Maven plugins to most recent version

kwin merged PR #592: URL: https://github.com/apache/jackrabbit-oak/pull/592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.a

[GitHub] [jackrabbit-oak] rombert commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

rombert commented on code in PR #592: URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r938557981 ## oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/checks/NodeTypeDefinitionNodeStoreChecker.java: ## @@ -75,6 +75,11 @@ public void onConstra

[GitHub] [jackrabbit-filevault] kwin merged pull request #242: JCRVLT-649 improve logging of errors in ActivityLog and ProgressTracker

kwin merged PR #242: URL: https://github.com/apache/jackrabbit-filevault/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

[GitHub] [jackrabbit-oak] kwin commented on pull request #637: OAK-9854: Remove version information from Oak pages

kwin commented on PR #637: URL: https://github.com/apache/jackrabbit-oak/pull/637#issuecomment-1206124067 I am also fine with removing it, maybe clarifies that this is a living document and may change independent of releases. -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #637: OAK-9854: Remove version information from Oak pages

mreutegg commented on PR #637: URL: https://github.com/apache/jackrabbit-oak/pull/637#issuecomment-1206122813 @kwin looks like others aren't interested in this topic. I'm aware you would rather keep the snapshot version on the pages. How strongly do you oppose this change? I'm fine if you r

[GitHub] [jackrabbit-filevault] kwin merged pull request #241: JCRVLT-647 restore old save() interval after failed save() attempts

kwin merged PR #241: URL: https://github.com/apache/jackrabbit-filevault/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

[GitHub] [jackrabbit-filevault] kwin closed pull request #243: JCRVLT-647: Restore old intermediate save() interval after failed save

kwin closed pull request #243: JCRVLT-647: Restore old intermediate save() interval after failed save URL: https://github.com/apache/jackrabbit-filevault/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [jackrabbit-filevault] kwin commented on pull request #243: JCRVLT-647: Restore old intermediate save() interval after failed save

kwin commented on PR #243: URL: https://github.com/apache/jackrabbit-filevault/pull/243#issuecomment-1206118300 Superseded by #241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [jackrabbit-oak] nit0906 opened a new pull request, #653: OAK-9858 | Making ES indexing sync(similar to lucene) for IndexQueryC…

nit0906 opened a new pull request, #653: URL: https://github.com/apache/jackrabbit-oak/pull/653 …ommonTests that are based on text files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [jackrabbit-oak] nit0906 merged pull request #645: OAK-9870 | Escaped characters from client get unescaped in ES implementation

nit0906 merged PR #645: URL: https://github.com/apache/jackrabbit-oak/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbi

[GitHub] [jackrabbit-oak] amit-jain merged pull request #634: OAK-9807: On DataStore initialization create the reference.key if absent

amit-jain merged PR #634: URL: https://github.com/apache/jackrabbit-oak/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[GitHub] [jackrabbit-filevault] kwin commented on pull request #241: JCRVLT-647 restore old save() interval after failed save() attempts

kwin commented on PR #241: URL: https://github.com/apache/jackrabbit-filevault/pull/241#issuecomment-1205595393 > ... back to a threshold of 1. This should be fixed now in https://github.com/apache/jackrabbit-filevault/pull/241/commits/4d4407c8b774a0be9b2119937acc2a318eb5e50e

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #652: OAK-9879: CacheLIRS statistics may return incorrect load count

mreutegg opened a new pull request, #652: URL: https://github.com/apache/jackrabbit-oak/pull/652 Synchronize access to loadSuccessCount Enable test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-filevault] kwin commented on pull request #243: JCRVLT-647: Restore old intermediate save() interval after failed save

kwin commented on PR #243: URL: https://github.com/apache/jackrabbit-filevault/pull/243#issuecomment-1205502344 @reschke See #241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [jackrabbit-filevault] reschke commented on pull request #243: JCRVLT-647: Restore old intermediate save() interval after failed save

reschke commented on PR #243: URL: https://github.com/apache/jackrabbit-filevault/pull/243#issuecomment-1205500986 ...1024 instead of 10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

kwin commented on code in PR #592: URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r937996547 ## oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/checks/NodeTypeDefinitionNodeStoreChecker.java: ## @@ -75,6 +75,11 @@ public void onConstraint

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

kwin commented on code in PR #592: URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r937995709 ## oak-parent/pom.xml: ## @@ -34,6 +34,8 @@ pom +3.3.9 +1.8 Review Comment: Done in https://github.com/apache/jackrabbit-oak/pull/592/commits/27f

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

kwin commented on code in PR #592: URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r937992571 ## oak-parent/pom.xml: ## @@ -34,6 +34,8 @@ pom +3.3.9 +1.8 Review Comment: Yes, good point, although `java.version` is a poor name for a Maven Pr

[GitHub] [jackrabbit-oak] mreutegg merged pull request #650: OAK-9879: CacheLIRS statistics may return incorrect load count

mreutegg merged PR #650: URL: https://github.com/apache/jackrabbit-oak/pull/650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #651: OAK-9880 : simplify rgc query

stefan-egli commented on PR #651: URL: https://github.com/apache/jackrabbit-oak/pull/651#issuecomment-1205369027 Maybe to compensate for that, do less frequent RGC, currently it runs every 5sec by default - changing that to every 1min might not have too much of an impact -- This is an au

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #651: OAK-9880 : simplify rgc query

stefan-egli commented on PR #651: URL: https://github.com/apache/jackrabbit-oak/pull/651#issuecomment-1205351817 one concern that just came to mind with this: obviously this would increase the number of queries executed - and that scales with the number of clusterNodeIds in use... -- Thi

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #650: OAK-9879: CacheLIRS statistics may return incorrect load count

mreutegg opened a new pull request, #650: URL: https://github.com/apache/jackrabbit-oak/pull/650 Add ignored test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

nfsantos opened a new pull request, #649: URL: https://github.com/apache/jackrabbit-oak/pull/649 In ES, for properties with `analyzed=true`, create a field `full:` for use with full text search queries. The field `` is still used but only for non-full-text search queries. This fixes

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg commented on PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#issuecomment-1205152398 Test failure in oak-blob-plugins seems unrelated. I can reproduce the failure locally and created https://issues.apache.org/jira/browse/OAK-9879 -- This is an automated message fr

[GitHub] [jackrabbit-oak] rombert commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

rombert commented on code in PR #592: URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r937616751 ## oak-parent/pom.xml: ## @@ -34,6 +34,8 @@ pom +3.3.9 +1.8 Review Comment: The value is duplicated with the java.version property. Shouldn't t

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg commented on code in PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937565923 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1411,7 +1411,7 @@ public void prefetch(Collec

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

thomasmueller commented on code in PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937451455 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1411,7 +1411,7 @@ public void prefetch(C

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

thomasmueller commented on code in PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937448763 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1411,7 +1411,7 @@ public void prefetch(C

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

thomasmueller commented on code in PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937444976 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1411,7 +1411,7 @@ public void prefetch(C

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg commented on PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#issuecomment-1204864960 > Was wondering if it would make sense to try and come up with a test case that would have failed without this fix. Running `ConcurrentPrefetchAndUpdateIT` in a loop eventuall

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg commented on code in PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937430348 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1411,7 +1411,7 @@ public void prefetch(Collec

[GitHub] [jackrabbit-oak] mreutegg merged pull request #647: OAK-9873: Prefetch node states: composite node store support

mreutegg merged PR #647: URL: https://github.com/apache/jackrabbit-oak/pull/647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabb

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #647: OAK-9873: Prefetch node states: composite node store support

mreutegg commented on PR #647: URL: https://github.com/apache/jackrabbit-oak/pull/647#issuecomment-1204847972 oak-core-spi failure looks like an infra glitch. ``` builds41 was marked offline: Connection was broken: java.io.IOException: Pipe closed after 0 cycles at org.apache.

[GitHub] [jackrabbit-filevault] kwin opened a new pull request, #241: Add test for AutoSave

kwin opened a new pull request, #241: URL: https://github.com/apache/jackrabbit-filevault/pull/241 Verify that counters behave correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

thomasmueller commented on code in PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r936801356 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1411,7 +1411,7 @@ public void prefetch(C

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

stefan-egli commented on PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#issuecomment-1202971935 Wsa wondering if it would make sense to try and come up with a test case that would have failed without this fix. Maybe it could help finding or explaining other issues (like som

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg commented on PR #646: URL: https://github.com/apache/jackrabbit-oak/pull/646#issuecomment-1202893432 I think that's possible. The added else clause in NodeDocumentCache.putNonConflictingDocs() is not specific to prefetching. -- This is an automated message from the Apache Git Ser

[GitHub] [jackrabbit-oak] stefan-egli commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

stefan-egli commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r935601535 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed t

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #646: OAK-9850: ConcurrentPrefetchAndUpdateIT.cacheConsistency fails occasi…

mreutegg opened a new pull request, #646: URL: https://github.com/apache/jackrabbit-oak/pull/646 …onally Keys collection passed to registerTracker must not be modified later. NodeDocumentCache.putNonConflictingDocs() must always notify other trackers. Enable test again. -- Thi

[GitHub] [jackrabbit-oak] nit0906 opened a new pull request, #645: OAK-9870 | Escaped characters from client get unescaped in ES implementation

nit0906 opened a new pull request, #645: URL: https://github.com/apache/jackrabbit-oak/pull/645 As part of https://github.com/apache/jackrabbit-oak/commit/695d5ab33ec23ad5cae9fd47dc5f207d6dc0cd6c, we handled the case of double negation in case of ES implementation by not using raw text fro

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #642: OAK-9873 Prefetch node states: composite node store support

thomasmueller commented on code in PR #642: URL: https://github.com/apache/jackrabbit-oak/pull/642#discussion_r933436389 ## oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryOptions.java: ## @@ -39,6 +39,7 @@ public class QueryOptions { public Optional limit = Opt

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #642: OAK-9873 Prefetch node states: composite node store support

rishabhdaim commented on code in PR #642: URL: https://github.com/apache/jackrabbit-oak/pull/642#discussion_r932443554 ## oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryOptions.java: ## @@ -39,6 +39,7 @@ public class QueryOptions { public Optional limit = Optio

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #642: OAK-9873 Prefetch node states: composite node store support

thomasmueller merged PR #642: URL: https://github.com/apache/jackrabbit-oak/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #644: OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and without index.

nfsantos opened a new pull request, #644: URL: https://github.com/apache/jackrabbit-oak/pull/644 The unit tests in this PR reproduces the issue in [OAK-9874](https://issues.apache.org/jira/browse/OAK-9874) -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #642: OAK-9873 Prefetch node states: composite node store support

thomasmueller commented on code in PR #642: URL: https://github.com/apache/jackrabbit-oak/pull/642#discussion_r933289347 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/prefetch/CacheWarming.java: ## @@ -48,6 +52,9 @@ public void prefetch(@NotNull

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #642: OAK-9873 Prefetch node states: composite node store support

thomasmueller commented on code in PR #642: URL: https://github.com/apache/jackrabbit-oak/pull/642#discussion_r933289347 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/prefetch/CacheWarming.java: ## @@ -48,6 +52,9 @@ public void prefetch(@NotNull

<    6   7   8   9   10   11   12   13   14   15   >