[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #48: JCRVLT-471 allow to include additional files/folders in META-INF

2020-12-10 Thread GitBox
sonarcloud[bot] commented on pull request #48: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/48#issuecomment-742520888 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pullReque

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #48: JCRVLT-471 allow to include additional files/folders in META-INF

2020-12-10 Thread GitBox
sonarcloud[bot] commented on pull request #48: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/48#issuecomment-742524604 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pullReque

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] removed a comment on pull request #48: JCRVLT-471 allow to include additional files/folders in META-INF

2020-12-10 Thread GitBox
sonarcloud[bot] removed a comment on pull request #48: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/48#issuecomment-742520888 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&p

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] removed a comment on pull request #48: JCRVLT-471 allow to include additional files/folders in META-INF

2020-12-10 Thread GitBox
sonarcloud[bot] removed a comment on pull request #48: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/48#issuecomment-742524604 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&p

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #48: JCRVLT-471 allow to include additional files/folders in META-INF

2020-12-10 Thread GitBox
sonarcloud[bot] commented on pull request #48: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/48#issuecomment-742570128 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pullReque

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #111: JCRVLT-487 persist RepositoryCopier options as well

2020-12-11 Thread GitBox
kwin opened a new pull request #111: URL: https://github.com/apache/jackrabbit-filevault/pull/111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #111: JCRVLT-487 persist RepositoryCopier options as well

2020-12-11 Thread GitBox
sonarcloud[bot] commented on pull request #111: URL: https://github.com/apache/jackrabbit-filevault/pull/111#issuecomment-743339272 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=111&resolved=false&types=BUG) [](htt

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2020-12-14 Thread GitBox
stefan-egli commented on pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#issuecomment-744327016 @mreutegg I had a 2nd look but no further comments, so other than the previous ones it lgtm. This is a

[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2020-12-14 Thread GitBox
mreutegg commented on a change in pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#discussion_r542492381 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/migration/FilteringNodeState.java ## @@ -60,6 +66,8 @@ public static

[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2020-12-14 Thread GitBox
mreutegg commented on a change in pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#discussion_r542527343 ## File path: oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/migration/version/VersionCopierTest.java ## @@ -0,0 +1,167 @@ +/* + * Licens

[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2020-12-14 Thread GitBox
mreutegg commented on a change in pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#discussion_r542527844 ## File path: oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/migration/FilteringNodeStateTest.java ## @@ -43,6 +46,7 @@ import static o

[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2020-12-14 Thread GitBox
mreutegg commented on a change in pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#discussion_r542531104 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/migration/NodeStateCopier.java ## @@ -308,6 +316,8 @@ private static NodeBui

[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2020-12-14 Thread GitBox
mreutegg commented on a change in pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#discussion_r542539751 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/migration/FilteringNodeState.java ## @@ -60,6 +66,8 @@ public static

[GitHub] [jackrabbit-filevault] kwin merged pull request #111: JCRVLT-487 persist RepositoryCopier options as well

2020-12-17 Thread GitBox
kwin merged pull request #111: URL: https://github.com/apache/jackrabbit-filevault/pull/111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin merged pull request #48: JCRVLT-471 allow to include additional files/folders in META-INF

2020-12-17 Thread GitBox
kwin merged pull request #48: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin merged pull request #47: JCRVLT-483 do not copy thumbnail image twice if it's already at the correct location in the source folder

2020-12-17 Thread GitBox
kwin merged pull request #47: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-filevault] rombert opened a new pull request #112: JCRVLT-488 - PlatformNameFormat incorrectly sets repository names for nodes with double colons

2020-12-17 Thread GitBox
rombert opened a new pull request #112: URL: https://github.com/apache/jackrabbit-filevault/pull/112 Minor cleanups + a failing test case. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #113: JCRVLT-489 ignore properties "jcr:isCheckedOut" and "oak:counter"

2021-01-01 Thread GitBox
kwin opened a new pull request #113: URL: https://github.com/apache/jackrabbit-filevault/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #113: JCRVLT-489 ignore properties "jcr:isCheckedOut" and "oak:counter"

2021-01-01 Thread GitBox
sonarcloud[bot] commented on pull request #113: URL: https://github.com/apache/jackrabbit-filevault/pull/113#issuecomment-753372366 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=113&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] kwin merged pull request #113: JCRVLT-489 ignore properties "jcr:isCheckedOut" and "oak:counter"

2021-01-02 Thread GitBox
kwin merged pull request #113: URL: https://github.com/apache/jackrabbit-filevault/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2021-01-04 Thread GitBox
mreutegg commented on pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261#issuecomment-754468062 Changes have been committed to SVN. This is an automated message from the Apache Git Service. To respond t

[GitHub] [jackrabbit-oak] mreutegg closed pull request #261: OAK-9290: Respect nt:frozenNode definition on upgrade and migration

2021-01-04 Thread GitBox
mreutegg closed pull request #261: URL: https://github.com/apache/jackrabbit-oak/pull/261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [jackrabbit-filevault] karollewandowski opened a new pull request #114: Fix filter mode attribute definition in filter.xsd

2021-01-07 Thread GitBox
karollewandowski opened a new pull request #114: URL: https://github.com/apache/jackrabbit-filevault/pull/114 I noticed that the filter `mode` attribute is simply defined as a string, rather than a reference to the `mode` attribute definition from line 33. It may result in incorrect sche

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #112: JCRVLT-488 - PlatformNameFormat incorrectly sets repository names for nodes with double colons

2021-01-07 Thread GitBox
sonarcloud[bot] commented on pull request #112: URL: https://github.com/apache/jackrabbit-filevault/pull/112#issuecomment-756347382 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=112&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] kwin merged pull request #114: Fix filter mode attribute definition in filter.xsd

2021-01-07 Thread GitBox
kwin merged pull request #114: URL: https://github.com/apache/jackrabbit-filevault/pull/114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-filevault] kwin commented on pull request #114: Fix filter mode attribute definition in filter.xsd

2021-01-07 Thread GitBox
kwin commented on pull request #114: URL: https://github.com/apache/jackrabbit-filevault/pull/114#issuecomment-756604229 @karollewandowski Thanks for the contribution, it is merged and part of the upcoming release. This is

[GitHub] [jackrabbit-filevault] kwin merged pull request #112: JCRVLT-488 - PlatformNameFormat incorrectly sets repository names for nodes with double colons

2021-01-07 Thread GitBox
kwin merged pull request #112: URL: https://github.com/apache/jackrabbit-filevault/pull/112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-filevault-package-maven-plugin] stefanseifert opened a new pull request #49: JCRVLT-490 fix issue with file name relativization when file resides on different drive than project (

2021-01-08 Thread GitBox
stefanseifert opened a new pull request #49: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin opened a new pull request #50: JCRVLT-490 only relativize path if it starts with the given base

2021-01-10 Thread GitBox
kwin opened a new pull request #50: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/50 Also fixes issue with IAE on paths with different roots (e.g. Windows, different drive letters) This is a

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #50: JCRVLT-490 only relativize path if it starts with the given base

2021-01-11 Thread GitBox
sonarcloud[bot] commented on pull request #50: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/50#issuecomment-75153 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pu

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin merged pull request #50: JCRVLT-490 only relativize path if it starts with the given base

2021-01-11 Thread GitBox
kwin merged pull request #50: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin closed pull request #49: JCRVLT-490 fix issue with file name relativization when file resides on different drive than project (on windows file

2021-01-11 Thread GitBox
kwin closed pull request #49: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin commented on pull request #49: JCRVLT-490 fix issue with file name relativization when file resides on different drive than project (on window

2021-01-11 Thread GitBox
kwin commented on pull request #49: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/49#issuecomment-758146031 Superseded by #50 This is an automated message from the Apache Git Service. To resp

[GitHub] [jackrabbit-oak] GeezerPelletier opened a new pull request #262: OAK-9322 - Add reference node id to integrity exception message

2021-01-13 Thread GitBox
GeezerPelletier opened a new pull request #262: URL: https://github.com/apache/jackrabbit-oak/pull/262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-oak] GeezerPelletier commented on pull request #262: OAK-9322 - Add reference node id to integrity exception message

2021-01-13 Thread GitBox
GeezerPelletier commented on pull request #262: URL: https://github.com/apache/jackrabbit-oak/pull/262#issuecomment-759605246 Hang tight need to make a test update. This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] GeezerPelletier removed a comment on pull request #262: OAK-9322 - Add reference node id to integrity exception message

2021-01-13 Thread GitBox
GeezerPelletier removed a comment on pull request #262: URL: https://github.com/apache/jackrabbit-oak/pull/262#issuecomment-759605246 Hang tight need to make a test update. This is an automated message from the Apache Git Ser

[GitHub] [jackrabbit-oak] trekawek commented on pull request #262: OAK-9322 - Add reference node id to integrity exception message

2021-01-14 Thread GitBox
trekawek commented on pull request #262: URL: https://github.com/apache/jackrabbit-oak/pull/262#issuecomment-760004554 The PR looks good to me. @stillalex, @mreutegg - it's a simple update but will make the debugging much easier. Could you take a look? Thanks! -

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #262: OAK-9322 - Add reference node id to integrity exception message

2021-01-14 Thread GitBox
mreutegg commented on pull request #262: URL: https://github.com/apache/jackrabbit-oak/pull/262#issuecomment-760024834 This looks good to me as well. I will commit this to trunk. This is an automated message from the Apache G

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #115: JCRVLT-492 document install hooks

2021-01-14 Thread GitBox
kwin opened a new pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #115: JCRVLT-492 document install hooks

2021-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-760510840 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #115: JCRVLT-492 document install hooks

2021-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-760514638 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] sonarcloud[bot] removed a comment on pull request #115: JCRVLT-492 document install hooks

2021-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-760510840 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&typ

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #115: JCRVLT-492 document install hooks

2021-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-760521788 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] sonarcloud[bot] removed a comment on pull request #115: JCRVLT-492 document install hooks

2021-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-760514638 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&typ

[GitHub] [jackrabbit-filevault] kwin merged pull request #115: JCRVLT-492 document install hooks

2021-01-15 Thread GitBox
kwin merged pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #115: JCRVLT-492 document install hooks

2021-01-15 Thread GitBox
sonarcloud[bot] commented on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-761124980 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] sonarcloud[bot] removed a comment on pull request #115: JCRVLT-492 document install hooks

2021-01-15 Thread GitBox
sonarcloud[bot] removed a comment on pull request #115: URL: https://github.com/apache/jackrabbit-filevault/pull/115#issuecomment-760521788 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=115&resolved=false&typ

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #116: JCRVLT-493 document package types

2021-01-18 Thread GitBox
kwin opened a new pull request #116: URL: https://github.com/apache/jackrabbit-filevault/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [jackrabbit-filevault] kwin commented on pull request #116: JCRVLT-493 document package types

2021-01-18 Thread GitBox
kwin commented on pull request #116: URL: https://github.com/apache/jackrabbit-filevault/pull/116#issuecomment-762184682 @DominikSuess would appreciate your feedback as well. This is an automated message from the Apache Git

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #116: JCRVLT-493 document package types

2021-01-18 Thread GitBox
sonarcloud[bot] commented on pull request #116: URL: https://github.com/apache/jackrabbit-filevault/pull/116#issuecomment-762331928 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=116&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] kwin merged pull request #116: JCRVLT-493 document package types

2021-01-19 Thread GitBox
kwin merged pull request #116: URL: https://github.com/apache/jackrabbit-filevault/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-oak] nit0906 opened a new pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-19 Thread GitBox
nit0906 opened a new pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-19 Thread GitBox
fabriziofortino commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560303698 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticOutOfBandIndexer.java ## @@ -0,0 +1,65 @@ +package org.ap

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-19 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560684885 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java ## @@ -0,0 +1,201 @@ +package org.apache.jackra

[GitHub] [jackrabbit-oak] nit0906 commented on pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-19 Thread GitBox
nit0906 commented on pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#issuecomment-763348572 @fabriziofortino - Thanks, made the suggested changes. This is an automated message from the Apache Git S

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
thomasmueller commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560764575 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java ## @@ -0,0 +1,204 @@ +package org.apache.

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560792790 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java ## @@ -0,0 +1,204 @@ +package org.apache.jackra

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560793575 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java ## @@ -0,0 +1,204 @@ +package org.apache.jackra

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560795087 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java ## @@ -0,0 +1,204 @@ +package org.apache.jackra

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560795175 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java ## @@ -0,0 +1,204 @@ +package org.apache.jackra

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560795897 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticOutOfBandIndexer.java ## @@ -0,0 +1,64 @@ +package org.apache.jac

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560796787 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java ## @@ -0,0 +1,55 @@ +packag

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on a change in pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#discussion_r560797435 ## File path: oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/run/Main.java ## @@ -0,0 +1,35 @@ +package org.apache.jackrabbit.oak.run; + +im

[GitHub] [jackrabbit-oak] nit0906 commented on pull request #263: OAK-9312 | Add reindex support for elastic in oak-run (new module added)

2021-01-20 Thread GitBox
nit0906 commented on pull request #263: URL: https://github.com/apache/jackrabbit-oak/pull/263#issuecomment-763456871 @thomasmueller - did the changes. This is an automated message from the Apache Git Service. To respond to

[GitHub] [jackrabbit-oak] GeezerPelletier opened a new pull request #264: OAK-9326 - Provide option to remove target version history from VersionCopier.copyVersionStorage

2021-01-21 Thread GitBox
GeezerPelletier opened a new pull request #264: URL: https://github.com/apache/jackrabbit-oak/pull/264 @trekawek fyi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [jackrabbit-oak] trekawek commented on pull request #264: OAK-9326 - Provide option to remove target version history from VersionCopier.copyVersionStorage

2021-01-21 Thread GitBox
trekawek commented on pull request #264: URL: https://github.com/apache/jackrabbit-oak/pull/264#issuecomment-764704744 Looks good. I'll merge it once the check passes. This is an automated message from the Apache Git Service.

[GitHub] [jackrabbit-oak] trekawek commented on pull request #264: OAK-9326 - Provide option to remove target version history from VersionCopier.copyVersionStorage

2021-01-21 Thread GitBox
trekawek commented on pull request #264: URL: https://github.com/apache/jackrabbit-oak/pull/264#issuecomment-764704744 Looks good. I'll merge it once the check passes. This is an automated message from the Apache Git Service.

[GitHub] [jackrabbit-oak] thomasmueller opened a new pull request #265: OAK-9325 Tool to compare index definitions

2021-01-22 Thread GitBox
thomasmueller opened a new pull request #265: URL: https://github.com/apache/jackrabbit-oak/pull/265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
kwin opened a new pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
sonarcloud[bot] commented on pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117#issuecomment-767150012 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=117&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
sonarcloud[bot] commented on pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117#issuecomment-767172499 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=117&resolved=false&types=BUG)

[GitHub] [jackrabbit-filevault] sonarcloud[bot] removed a comment on pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
sonarcloud[bot] removed a comment on pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117#issuecomment-767150012 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=117&resolved=false&typ

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
sonarcloud[bot] commented on pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117#issuecomment-767150012 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [jackrabbit-filevault] sonarcloud[bot] removed a comment on pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
sonarcloud[bot] removed a comment on pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117#issuecomment-767150012 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=117&resolved=false&typ

[GitHub] [jackrabbit-filevault] kwin merged pull request #117: JCRVLT-494 clarify javadoc of ExecutionPlanBuilder.execute(...)

2021-01-25 Thread GitBox
kwin merged pull request #117: URL: https://github.com/apache/jackrabbit-filevault/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #265: OAK-9325 Tool to compare index definitions

2021-01-26 Thread GitBox
fabriziofortino commented on a change in pull request #265: URL: https://github.com/apache/jackrabbit-oak/pull/265#discussion_r564318272 ## File path: oak-run/src/main/java/org/apache/jackrabbit/oak/index/merge/IndexDiff.java ## @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #265: OAK-9325 Tool to compare index definitions

2021-01-28 Thread GitBox
thomasmueller commented on a change in pull request #265: URL: https://github.com/apache/jackrabbit-oak/pull/265#discussion_r566231204 ## File path: oak-run/src/main/java/org/apache/jackrabbit/oak/index/merge/IndexDiff.java ## @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache S

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #118: JCRVLT-499 parse dates with timezone designator "Z" correctly

2021-01-28 Thread GitBox
kwin opened a new pull request #118: URL: https://github.com/apache/jackrabbit-filevault/pull/118 rely on PackageProperties API for reading from package expose unwrapped package properties without type conversions This is

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #118: JCRVLT-499 parse dates with timezone designator "Z" correctly

2021-01-28 Thread GitBox
sonarcloud[bot] commented on pull request #118: URL: https://github.com/apache/jackrabbit-filevault/pull/118#issuecomment-769536119 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=118&resolved=false&types=BUG) [](htt

[GitHub] [jackrabbit-filevault] kwin merged pull request #118: JCRVLT-499 parse dates with timezone designator "Z" correctly

2021-01-29 Thread GitBox
kwin merged pull request #118: URL: https://github.com/apache/jackrabbit-filevault/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #119: JCRVLT-497 correctly switch context if authorizable node is first

2021-01-29 Thread GitBox
kwin opened a new pull request #119: URL: https://github.com/apache/jackrabbit-filevault/pull/119 detected as simple nt:folder This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-filevault] sonarcloud[bot] commented on pull request #119: JCRVLT-497 correctly switch context if authorizable node is first

2021-01-29 Thread GitBox
sonarcloud[bot] commented on pull request #119: URL: https://github.com/apache/jackrabbit-filevault/pull/119#issuecomment-770033725 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=119&resolved=false&types=BUG) [](htt

[GitHub] [jackrabbit-filevault] tmaret opened a new pull request #120: JCRVLT-500 - Add a failing unit and integration test to show the issue

2021-01-30 Thread GitBox
tmaret opened a new pull request #120: URL: https://github.com/apache/jackrabbit-filevault/pull/120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-filevault] kwin merged pull request #119: JCRVLT-497 correctly switch context if authorizable node is first

2021-02-01 Thread GitBox
kwin merged pull request #119: URL: https://github.com/apache/jackrabbit-filevault/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin opened a new pull request #51: JCRVLT-249 add parameter for internal install hook

2021-02-01 Thread GitBox
kwin opened a new pull request #51: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #51: JCRVLT-249 add parameter for internal install hook

2021-02-01 Thread GitBox
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/51#issuecomment-770956244 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pullReque

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin merged pull request #51: JCRVLT-249 add parameter for internal install hook

2021-02-01 Thread GitBox
kwin merged pull request #51: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-filevault] tmaret opened a new pull request #121: JCRVLT-500 - support quoted pattern to decide absolute filter

2021-02-01 Thread GitBox
tmaret opened a new pull request #121: URL: https://github.com/apache/jackrabbit-filevault/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-filevault] tmaret closed pull request #120: JCRVLT-500 - Add a failing unit and integration test to show the issue

2021-02-01 Thread GitBox
tmaret closed pull request #120: URL: https://github.com/apache/jackrabbit-filevault/pull/120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [jackrabbit-filevault] tmaret commented on pull request #120: JCRVLT-500 - Add a failing unit and integration test to show the issue

2021-02-01 Thread GitBox
tmaret commented on pull request #120: URL: https://github.com/apache/jackrabbit-filevault/pull/120#issuecomment-771115934 Closing this PR in favour of https://github.com/apache/jackrabbit-filevault/pull/121 which contains the tests and a fix

[GitHub] [jackrabbit-filevault] kwin merged pull request #121: JCRVLT-500 - support quoted pattern to decide absolute filter

2021-02-02 Thread GitBox
kwin merged pull request #121: URL: https://github.com/apache/jackrabbit-filevault/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-oak] fabriziofortino opened a new pull request #266: OAK-9145: oak analyzer filters order

2021-02-02 Thread GitBox
fabriziofortino opened a new pull request #266: URL: https://github.com/apache/jackrabbit-oak/pull/266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-oak] dlh3 commented on pull request #266: OAK-9145: oak analyzer filters order

2021-02-02 Thread GitBox
dlh3 commented on pull request #266: URL: https://github.com/apache/jackrabbit-oak/pull/266#issuecomment-771857031 Relates to #242. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [jackrabbit-filevault] kwin merged pull request #121: JCRVLT-500 - support quoted pattern to decide absolute filter

2021-02-02 Thread GitBox
kwin merged pull request #121: URL: https://github.com/apache/jackrabbit-filevault/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [jackrabbit-oak] dlh3 commented on pull request #266: OAK-9145: oak analyzer filters order

2021-02-02 Thread GitBox
dlh3 commented on pull request #266: URL: https://github.com/apache/jackrabbit-oak/pull/266#issuecomment-771857031 Relates to #242. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin opened a new pull request #52: JCRVLT-495 allow to limit filtering to certain extensions

2021-02-03 Thread GitBox
kwin opened a new pull request #52: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [jackrabbit-oak] ShangwenWang opened a new pull request #267: Change the method name "serialize" to "serializeReferences"

2021-02-03 Thread GitBox
ShangwenWang opened a new pull request #267: URL: https://github.com/apache/jackrabbit-oak/pull/267 The function of this method is to serialize the passed references. However, only naming it as "serialize" cannot describe it clearly. Given that the class name (_GetReferencesResponseEnco

[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #52: JCRVLT-495 allow to limit filtering to certain extensions

2021-02-03 Thread GitBox
sonarcloud[bot] commented on pull request #52: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/52#issuecomment-772662507 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pu

[GitHub] [jackrabbit-oak] fabriziofortino closed pull request #266: OAK-9145: oak analyzer filters order

2021-02-04 Thread GitBox
fabriziofortino closed pull request #266: URL: https://github.com/apache/jackrabbit-oak/pull/266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [jackrabbit-oak] fabriziofortino commented on pull request #266: OAK-9145: oak analyzer filters order

2021-02-04 Thread GitBox
fabriziofortino commented on pull request #266: URL: https://github.com/apache/jackrabbit-oak/pull/266#issuecomment-773304619 See [OAK-9145 comment](https://issues.apache.org/jira/browse/OAK-9145?focusedCommentId=17278672&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpan

<    1   2   3   4   5   6   7   8   9   10   >