[GitHub] jmeter pull request: Added changes to track hits in cumulatedMetri...

2015-07-11 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/26#issuecomment-120600212 Thanks for your contribution. It has been integrated with some slight changes within : https://bz.apache.org/bugzilla/show_bug.cgi?id=58122 http

[GitHub] jmeter pull request: UBIKLOADPACK json plugin donation to Apache J...

2015-10-17 Thread pmouawad
Github user pmouawad commented on a diff in the pull request: https://github.com/apache/jmeter/pull/28#discussion_r42308993 --- Diff: src/components/org/apache/jmeter/extractor/json/jsonpath/JSONManager.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[GitHub] jmeter pull request: UBIKLOADPACK json plugin donation to Apache J...

2015-10-17 Thread pmouawad
Github user pmouawad commented on a diff in the pull request: https://github.com/apache/jmeter/pull/28#discussion_r42309300 --- Diff: xdocs/usermanual/component_reference.xml --- @@ -6078,6 +6080,34 @@ This can be useful if your JDBC Sample changes some data and you want to reset

[GitHub] jmeter pull request: Plugin to run load test for a JINI based RMIS...

2015-10-17 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/21#issuecomment-148918446 Hello, Thanks for the offer of the code. The plugin seems to the team to be rather specialized, and unlikely to be used by many other JMeter users

[GitHub] jmeter pull request: fixed spelling typo in example password

2015-11-16 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/29#issuecomment-157161782 Thanks, fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jmeter pull request: fixed spelling typo in example password

2015-11-16 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/29#issuecomment-157170292 Hi, Absolutely. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] jmeter pull request: Added changes to track hits in cumulatedMetri...

2015-11-29 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/26#issuecomment-160441530 Hi, Sorry for late reply. Could you provide a PR based on current code so that I see what you mean ? Thanks --- If your project is set up for it, you can

[GitHub] jmeter pull request: Added changes to track hits in cumulatedMetri...

2015-11-29 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/26#issuecomment-160442852 After further analysis, I understand you might be talking about the piece of code in GraphiteBackendListenerClient#addMetrics

[GitHub] jmeter pull request: Bug 58675 : Module Controller error message e...

2015-12-01 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/32#issuecomment-161085669 Fixed by : http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java?view=diff&r1=1717512&r2=1717513

[GitHub] jmeter pull request: Bug 58679 Xstream : Replace the xpp pull pars...

2015-12-02 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/35#issuecomment-161428163 Fixed by commit: http://svn.apache.org/viewvc?rev=1717619&view=rev --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] jmeter pull request: Bug 58678 Module Controller : limit target el...

2015-12-02 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/34#issuecomment-161428250 Fixed by commit: http://svn.apache.org/viewvc?rev=1717618&view=rev --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] jmeter pull request: Bug 58689 : Add shortcuts to expand / collaps...

2015-12-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/40#issuecomment-161957773 Fixed by http://svn.apache.org/viewvc?rev=1717952&view=rev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] jmeter pull request: Bug 58687 : ButtonPanel should die

2015-12-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/39#issuecomment-161958032 Fixed by http://svn.apache.org/viewvc?rev=1717953&view=rev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] jmeter pull request: Bug 58685 JDateField : Make the modification ...

2015-12-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/38#issuecomment-161958206 Fixed by http://svn.apache.org/viewvc?rev=1717954&view=rev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] jmeter pull request: Ubikloadpack report dashboard donation

2015-12-08 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/42#issuecomment-163032210 Fixed by http://svn.apache.org/viewvc?rev=1718425&view=rev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1 to allow mig...

2015-12-15 Thread pmouawad
GitHub user pmouawad opened a pull request: https://github.com/apache/jmeter/pull/62 Migrate CookieManager to HC4.5.1 to allow migration to HC 4.5.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ubikloadpack/jmeter HC4_5

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1 to allow mig...

2015-12-15 Thread pmouawad
Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1

2015-12-15 Thread pmouawad
GitHub user pmouawad opened a pull request: https://github.com/apache/jmeter/pull/63 Migrate CookieManager to HC4.5.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ubikloadpack/jmeter HC4_5 Alternatively you can review and

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1

2015-12-18 Thread pmouawad
Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1

2015-12-18 Thread pmouawad
GitHub user pmouawad opened a pull request: https://github.com/apache/jmeter/pull/64 Migrate CookieManager to HC4.5.1 Pull request migrating to HC 4.5.1 Fixing Test cases (thanks to the precious help of Oleg) Fixing issue in current HC4CookieHandler You can merge this pull

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1

2015-12-28 Thread pmouawad
Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: addded .gitignore

2015-12-28 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/24#issuecomment-167620360 Thanks for contribution , but would it be possible to customize it for JMeter ? I see lot of extensions that are not used and will never be in the project. --- If

[GitHub] jmeter pull request: Migrate CookieManager to HC4.5.1

2015-12-28 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/64#issuecomment-167619954 Fixed through http://svn.apache.org/viewvc?rev=1721032&view=rev --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] jmeter pull request: MQTT plugin for Jmeter

2016-01-13 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/72#issuecomment-171421826 Hello, First , big thanks for your PR. We will have a look at it soon, but if teams agrees on integrating it to Core, it should happen in N+2 release (not the

[GitHub] jmeter pull request: Ability to set font for JSyntaxTextArea

2016-01-28 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/91#issuecomment-176471792 Hi, Thanks for PR. I created https://bz.apache.org/bugzilla/show_bug.cgi?id=58933 for follow up. @milamberspace I let you handle this. @d0k1 , if

[GitHub] jmeter pull request: MQTT plugin for Jmeter

2016-02-01 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/72#issuecomment-178402985 Hi, As I said, for nowwe are preparing the next version. This sampler if acceptedby team would be in n+2 version. I have opened a dev discussion regarding its

[GitHub] jmeter pull request: Remove "Building a Web Test Plan" template

2016-02-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/92#issuecomment-180068466 I think this template can be useful to see a simple structure of a test plan. It is also used by the manual. I use it for debugging. So IMHO, we should keep

[GitHub] jmeter pull request: Remove "Building an Advanced Web Test Plan" t...

2016-02-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/93#issuecomment-180068637 I think this template can be useful to see a sample structure of a web test plan. It is also used by the manual. I use it for debugging. So IMHO, we should

[GitHub] jmeter pull request: Bug58980

2016-02-07 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/111#issuecomment-181113020 Hi, Thanks for PR. Do you think 404 is a good response code ? Why not a 500 ? Regards --- If your project is set up for it, you can reply to

[GitHub] jmeter pull request: Removing duplicate code.

2016-02-17 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/126#issuecomment-185104753 Note from sebb on dev mailing list: > -1 > Auto boxing is generally a bad idea as it can hide poor design (wrong >choice of long/Long). >

[GitHub] jmeter pull request: Removing duplicate code.

2016-02-17 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/126#issuecomment-185104857 Thanks for PR , if you can restrict it to String.format as per sebb notes. Thanks --- If your project is set up for it, you can reply to this email and have your

[GitHub] jmeter pull request: Removing unnecessary (un)boxing

2016-02-17 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/123#issuecomment-185315216 Note from sebb on dev mailing list: > -1 > Auto boxing is generally a bad idea as it can hide poor design (wrong >choice of long/Long). >

[GitHub] jmeter pull request: Removing duplicate code.

2016-02-17 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/126#issuecomment-185315393 Yes :-) fixed the comments Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

2016-02-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/129#issuecomment-185728403 Hello, I think there is an issue with your refactoring of AbstractGraphConsumer. at lines 341 to 351, you have refactored the Map iteration but: 1) One

[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...

2016-02-21 Thread pmouawad
GitHub user pmouawad opened a pull request: https://github.com/apache/jmeter/pull/135 Bug 59034 - Parallel downloads connection management is not realistic Draft of a patch making parallel downloads more realistic by sharing the HttpClient instance between Main browser thread and

[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...

2016-02-21 Thread pmouawad
GitHub user pmouawad opened a pull request: https://github.com/apache/jmeter/pull/136 Bug 59034 - Parallel downloads connection management is not realistic Based on https://github.com/apache/jmeter/pull/135 with following improvements: - no thread pool creation if there&#

[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...

2016-02-21 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/135#issuecomment-186914681 Replaced by PR-136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...

2016-02-21 Thread pmouawad
Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Refactoring of HTTPSamplerBase

2016-02-21 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/131#issuecomment-186923437 Hi, At Team, Please avoid merging this PR for now as it would introduce a conflict on : https://bz.apache.org/bugzilla/show_bug.cgi?id=59033 which is

[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...

2016-02-21 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/136#issuecomment-186926416 Commited in trunk through: - http://svn.apache.org/viewvc?rev=1731570&view=rev --- If your project is set up for it, you can reply to this email and have

[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...

2016-02-21 Thread pmouawad
Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Bug 59067 JMeter fail to iterate over SimpleC...

2016-02-26 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/141#issuecomment-189364775 Commited within: http://svn.apache.org/viewvc?rev=1732514&view=rev Thanks --- If your project is set up for it, you can reply to this email and have your r

[GitHub] jmeter pull request: Change the running indicator

2016-03-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/152#issuecomment-192498248 @milamberspace , I leave it to you ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] jmeter pull request: [59105] TableEditor: add from clipboard

2016-03-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/153#issuecomment-192499523 Thanks for contribution ! In my opinion, no need for an additional property unless you think there might be a bug. Could you provide a Test Plan with some

[GitHub] jmeter pull request: Refactoring of HTTPSamplerBase

2016-03-04 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/131#issuecomment-192510866 Hello, Thanks for PR. Would it be possible to either resubmit it after 3.0 release or resubmit one updated ? Thanks --- If your project is set up for

[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...

2016-03-09 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/155#issuecomment-194273164 Fixed within: http://svn.apache.org/viewvc?rev=1734228&view=rev --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...

2016-03-09 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/162#issuecomment-194522474 Hi Antonio, If file name is empty what is the use of CSV DataSet ? I think maybe we should make the test fail and stop , which does not appear to be the

[GitHub] jmeter pull request: deprecate some methods in JMeterUtils

2016-03-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/148#issuecomment-198560249 pong Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/168#issuecomment-197859425 Fixed with commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/168#issuecomment-197558458 Hello Maxime, Could you provide a simple test plan showing the bug you faced ? Thank you --- If your project is set up for it, you can reply to this email and

[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...

2016-04-03 Thread pmouawad
GitHub user pmouawad opened a pull request: https://github.com/apache/jmeter/pull/179 Bug 59258 : GUI Mode : OOM Protection for View Results Tree or View Results in Table This PR is a first try to base protection on memory estimation. Memory estimation of SampleResult is too

[GitHub] jmeter pull request: Compress PNGs

2016-04-03 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/177#issuecomment-204964432 +1 for me once Tests that are broken due to the change of size are fixed --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jmeter pull request: Refactor TestCacheManager: replace duplicated...

2016-04-03 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/178#issuecomment-204965129 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

2016-04-03 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/176#issuecomment-204965711 Hi Vladimir, Exposing public method for testing might introduce issues. Users can think that field is persisted in JMX while it's not. Can&#x

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

2016-04-03 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/176#issuecomment-204978544 +1 for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

2016-04-03 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/176#issuecomment-204978538 Sorry , I had some hallucination although I checked twice :-) , it is package protected. --- If your project is set up for it, you can reply to this email and have

[GitHub] jmeter pull request: addded .gitignore

2016-04-03 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/24#issuecomment-205054140 Fixed by : http://svn.apache.org/viewvc?rev=1737500&view=rev http://svn.apache.org/viewvc?rev=1737499&view=rev --- If your project is set up for it,

[GitHub] jmeter pull request: Bug59305DefaultReportHTMLStatisticsColumnSort

2016-04-14 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/193#issuecomment-210050073 Hi, The choice was made to highlight transactions with upper error. So the sorting based on Error% looks ok for me. Clicking on the column to sort against

[GitHub] jmeter pull request: Bug 59281 testTimeDurationGUI

2016-04-14 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/182#issuecomment-210055924 I voluntarily made it like this because I found it more visible :-) So I don't know what to do with this PR. --- If your project is set up for it, you can rep

[GitHub] jmeter pull request: Bug 59281 testTimeDurationGUI

2016-04-14 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/182#issuecomment-210117693 Hi Antonio, I would be very interested by a UX Expert proposal on all JMeter GUI :-), not just this part. This would really help us, provided the advice is not

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

2016-04-19 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/203#issuecomment-212119330 Hi Antonio, I think it's a good idea. But if you want to create a PR for docs, you must update changes.xml . All html files are generated fro

[GitHub] jmeter pull request: Refactor TestCacheManager: replace duplicated...

2016-04-19 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/178#issuecomment-212119461 Hi @vlsi , Will you commit this ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jmeter pull request: Compress PNGs

2016-04-19 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/177#issuecomment-212119570 Hi @vlsi , Will you commit this ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...

2016-04-19 Thread pmouawad
Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...

2016-04-19 Thread pmouawad
Github user pmouawad commented on a diff in the pull request: https://github.com/apache/jmeter/pull/202#discussion_r60310491 --- Diff: src/components/org/apache/jmeter/control/IncludeController.java --- @@ -121,19 +121,20 @@ protected HashTree loadIncludedElements

[GitHub] jmeter pull request: Fix 'statisfied' typo

2016-04-26 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/205#issuecomment-214866111 Thanks for your tests and PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] jmeter issue #209: Bug59620_BrowserFileAndDirectory

2016-06-10 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/209 Hi, Thanks for contribution. But I think it is too coarse as it allows choosing Folder where it does not have a meaning. You should make this more specific so that it applies only to

[GitHub] jmeter issue #210: Added a Graphite sender to send metrics in statsd protoco...

2016-07-31 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/210 @nitinpadalia , any update on this PR ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jmeter issue #210: Added a Graphite sender to send metrics in statsd protoco...

2016-07-31 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/210 No problem. Will you submit a new PR taking into account the comments ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 Hello @jloisel , Thanks for your contribution. I agree with your analysis of "race condition" and it impact on performances. But do you have some benchmark that

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 @jloisel , my note was not on using ConcurrentHashmap :-) (I am aware of this), but on the usage of Guava. Ok thanks for feedback, I'll commit the PR after further review --- If

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 @vlsi, that was my main concern but @jloisel convinced me, if you have a better option without guava , feel free to amend PR. Shall I wait or do I commit ? For now I may not commit the

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 @vlsi regarding guava compatibility: http://stackoverflow.com/questions/21867295/is-guava-binary-compatible-with-previous-versions Regarding your proposal, there is only 1

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 >The idea is JMeter releases are very rare, This is supposed to change :-) >CHM has no way to evict old entries, ... I hope you don't think I ignore that :-) What I mea

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 Let's not diverge too much :-) 1. I opened a discussion threads on dev mailing list on Java8 migration. 2. @vlsi OSGI approach is a huge & complex piece of work, frankly I doubt

[GitHub] jmeter issue #221: Bug 59934

2016-08-03 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 @ben-manes , thanks for those clarifications and your work on CLHM and caffeine, very interesting. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] jmeter issue #224: Bug59948 html formated render

2016-08-05 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/224 Yes you're correct, I meant Text renderer but in that case formatting does not really make sense as it can be anything (not only html) --- If your project is set up for it, you can reply to

[GitHub] jmeter issue #224: Bug59948 html formated render

2016-08-05 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/224 +1 for commiting it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] jmeter issue #225: BUG59951_BetterScriptLanguageChooseDisplayJSR223

2016-08-05 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/225 Hello, I find it interesting to have the version of libraries . So I am not keen on changing it. Regards --- If your project is set up for it, you can reply to this email and have

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

2016-08-05 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/223 Hello, In my opinion, you should commit it and we can improve it with further commits. I agree with @vlsi on the performance involvement of warn logging , but we'll find a solution i

[GitHub] jmeter issue #221: Bug 59934

2016-08-10 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/221 Hello, I'll wait 2 more days for reaction on guava subject. Unless there is a nogo, I'll commit the patch as is. Regards --- If your project is set up for it, you can rep

[GitHub] jmeter issue #230: Add README.md

2016-09-26 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/230 +1 for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2016-10-10 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/231 Hello, Thanks for the patch. First review look good to me. Any reason for not using ThreadLocalRandom.current() instead of Random ? Regards Philippe --- If your project is

[GitHub] jmeter issue #233: Bug 60274

2016-10-18 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/233 Thanks for this contribution ! We will review it ASAP and give you feedback. Regards Philippe M. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] jmeter issue #233: Bug 60274

2016-10-31 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/233 Hi Thorson, Sorry for late reply, we are in the middle of 3.1 release preparation and I was on holiday. Thanks again for you PR. I started reviewing, few notes

[GitHub] jmeter issue #233: Bug 60274

2016-10-31 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/233 Hi Again, For info, in your commit, no need to include the HTML files, only XML for documentation. Thanks --- If your project is set up for it, you can reply to this email and have your

[GitHub] jmeter issue #233: Bug 60274

2016-11-12 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/233 Hi @blindio , Did you have time working on the reported issues ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jmeter issue #236: Bug 59937: Sub menus addition

2016-12-13 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/236 Hello, Thanks for contribution. Could you provide a screenshot of what the result will look like ? Thank you --- If your project is set up for it, you can reply to this email and have

[GitHub] jmeter issue #236: Bug 59937: Sub menus addition

2016-12-14 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/236 Thanks a lot for your screenshots which give a better view of the feature and your work on this. Unfortunately As discussed in : - https://bz.apache.org/bugzilla/show_bug.cgi?id=59937

[GitHub] jmeter issue #237: Adds a time boxed sampling for backend listeners

2016-12-14 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/237 Hello @max3163, Thank you for your contribution. Could you (as requested by Felix) give more details on the use case for this PR ? Thank you Regards --- If your project is set up

[GitHub] jmeter issue #227: Bug 55258

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/227 Hi Team, Shall I merge this one ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jmeter issue #241: Support variable for all JMS messages (bytes, object, ......

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/241 Hello @loganmzz , Is this PR a duplicate of PR 239 ? If so, could you close 239? Did you check the performance impact of this feature ? Thanks a lot for your contribution

[GitHub] jmeter issue #240: Improves JMS component robustness

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/240 Thanks for contribution. Few notes: - docs (component-reference.xml) should be updated - In handleError, I think you should surround close line 232 with try/catch

[GitHub] jmeter issue #237: Adds a time boxed sampling for backend listeners

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/237 Hello Team, PR looks fine to me. Do you agree with enhancement ? Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] jmeter issue #238: Adds API to create JMeter threads on the fly

2016-12-29 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/238 Thanks for contribution. I reviewed the patch. It doesn't break current code but I think there may be an issue in : `Map.Entry entry = allThreads.entrySet().iterator()

[GitHub] jmeter issue #238: Adds API to create JMeter threads on the fly

2016-12-29 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/238 See: https://bz.apache.org/bugzilla/show_bug.cgi?id=60530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] jmeter issue #244: Bug60535 error prone boxed primitive constructor

2016-12-30 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/244 Hi Antonio, I wouldn't create a bugzilla and a PR for only this. Besides, the PR modifies other files that shouldn't . In this particular case, just commit directly as you have

[GitHub] jmeter issue #243: Bug60534 error prone default charset sample result java v...

2016-12-30 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/243 Hi Antonio, Same remark as for other PR. Just commit directly the code unless you have a doubt. Regards --- If your project is set up for it, you can reply to this email and have

[GitHub] jmeter issue #237: Adds a time boxed sampling for backend listeners

2016-12-30 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/237 @max3163 , are you using GraphiteBackendListener or something else (I don't fully understand your comment on "I'm thinking to send a PR to share it too". If not, why

[GitHub] jmeter issue #237: Adds a time boxed sampling for backend listeners

2017-01-02 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/237 Hello, Thanks for proposal. What is the quantity of code ? Does it have any dependency on Influx library or it is standalone using socket ? Thank you --- If your project is set up

  1   2   3   4   >