[jira] [Commented] (KAFKA-4576) Log segments close to max size break on fetch

2017-01-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795130#comment-15795130 ] Ismael Juma commented on KAFKA-4576: In theory, we should eventually reach the end of

[jira] [Commented] (KAFKA-4576) Log segments close to max size break on fetch

2017-01-03 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795040#comment-15795040 ] huxi commented on KAFKA-4576: - If we use a loop structure to collect all the 12 bytes, there i

[jira] [Commented] (KAFKA-4576) Log segments close to max size break on fetch

2017-01-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794645#comment-15794645 ] Ismael Juma commented on KAFKA-4576: Great catch [~huxi_2b]. The code in trunk has cha

[jira] [Commented] (KAFKA-4576) Log segments close to max size break on fetch

2017-01-03 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794567#comment-15794567 ] Onur Karaman commented on KAFKA-4576: - I think you're right, [~huxi_2b]. It looks like

[jira] [Commented] (KAFKA-4576) Log segments close to max size break on fetch

2017-01-02 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794042#comment-15794042 ] huxi commented on KAFKA-4576: - Seems FileChannel.read does not fill up the 12-byte buffer alth