[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy

2022-07-18 Thread GitBox
divijvaidya commented on code in PR #421: URL: https://github.com/apache/kafka-site/pull/421#discussion_r923575015 ## includes/_top.htm: ## @@ -150,6 +150,48 @@

[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy

2022-07-18 Thread GitBox
divijvaidya commented on code in PR #421: URL: https://github.com/apache/kafka-site/pull/421#discussion_r923575649 ## includes/_top.htm: ## @@ -150,6 +150,48 @@

[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy

2022-07-18 Thread GitBox
divijvaidya commented on code in PR #421: URL: https://github.com/apache/kafka-site/pull/421#discussion_r923583008 ## includes/_top.htm: ## @@ -150,6 +150,48 @@

[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-18 Thread GitBox
divijvaidya commented on code in PR #420: URL: https://github.com/apache/kafka-site/pull/420#discussion_r923600664 ## css/fonts.css: ## @@ -0,0 +1,352 @@ +/* latin-ext */ +@font-face { +font-family: 'Cutive Mono'; +font-style: normal; +font-weight: 400; +src: ur

[GitHub] [kafka-site] divijvaidya commented on pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-18 Thread GitBox
divijvaidya commented on PR #420: URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188046357 > As an alternative, have you tried getting rid of these custom fonts and using a standard one like helvetica? No. Roboto is a fairly common and popular font used across websit

[GitHub] [kafka-site] showuon commented on a diff in pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy

2022-07-19 Thread GitBox
showuon commented on code in PR #421: URL: https://github.com/apache/kafka-site/pull/421#discussion_r924146761 ## includes/_top.htm: ## @@ -150,6 +150,48 @@

[GitHub] [kafka-site] showuon commented on pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
showuon commented on PR #420: URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188708449 @scott-confluent , could you help review this PR since you added the google font into this project? Thanks. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka-site] divijvaidya commented on pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
divijvaidya commented on PR #420: URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188739303 > @divijvaidya , why do you use https://google-webfonts-helper.herokuapp.com/fonts/ to download the fonts, instead of the original link: [https://fonts.googleapis.com/css?family=Cut

[GitHub] [kafka-site] showuon commented on pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
showuon commented on PR #420: URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188822349 @divijvaidya , I see. But in https://fonts.googleapis.com/css?family=Cutive+Mono%7CRoboto:100,300,400,700,900%7CRoboto+Condensed:300 , we can download all the fonts in `woff2` format via

[GitHub] [kafka-site] divijvaidya commented on pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
divijvaidya commented on PR #420: URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188923709 > We can download the font via https://fonts.gstatic.com/s/cutivemono/v14/m8JWjfRfY7WVjVi2E-K9H6RMTm6o39ucNvc.woff2 Oh yes. We can do that but I think that would be less mainta

[GitHub] [kafka-site] mimaison merged pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy

2022-07-19 Thread GitBox
mimaison merged PR #421: URL: https://github.com/apache/kafka-site/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache

[GitHub] [kafka-site] showuon commented on pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
showuon commented on PR #420: URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1189006953 > That is a very fair question to ask. The number of actual font files are lesser because the new font files contain all the charset in one file. I see. Thanks. > I

[GitHub] [kafka-site] divijvaidya opened a new pull request, #424: KAFKA-13868: Replace Google Analytics with Matomo

2022-07-19 Thread GitBox
divijvaidya opened a new pull request, #424: URL: https://github.com/apache/kafka-site/pull/424 As per the [ASF privacy policy](https://privacy.apache.org/faq/committers.html), Google Analytics should be replaced with Apache hosted version of Matomo to remain complaint with GDPR. Em

[GitHub] [kafka-site] divijvaidya commented on pull request #424: KAFKA-13868: Replace Google Analytics with Matomo

2022-07-19 Thread GitBox
divijvaidya commented on PR #424: URL: https://github.com/apache/kafka-site/pull/424#issuecomment-1189065641 @mimaison please review for the GDPR compliance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka-site] tombentley commented on a diff in pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
tombentley commented on code in PR #420: URL: https://github.com/apache/kafka-site/pull/420#discussion_r924521925 ## css/fonts.css: ## @@ -0,0 +1,82 @@ +/* cutive-mono-regular - latin-ext_latin */ +@font-face { +font-family: 'Cutive Mono'; +font-style: normal; +font-

[GitHub] [kafka-site] bbejeck merged pull request #406: Add Qudosoft to powered-by

2022-07-19 Thread GitBox
bbejeck merged PR #406: URL: https://github.com/apache/kafka-site/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] bbejeck commented on pull request #406: Add Qudosoft to powered-by

2022-07-19 Thread GitBox
bbejeck commented on PR #406: URL: https://github.com/apache/kafka-site/pull/406#issuecomment-1189089886 @StephanZimmermann thanks for rebasing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
divijvaidya commented on code in PR #420: URL: https://github.com/apache/kafka-site/pull/420#discussion_r924561314 ## css/fonts.css: ## @@ -0,0 +1,82 @@ +/* cutive-mono-regular - latin-ext_latin */ +@font-face { +font-family: 'Cutive Mono'; +font-style: normal; +font

[GitHub] [kafka-site] tombentley commented on a diff in pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-19 Thread GitBox
tombentley commented on code in PR #420: URL: https://github.com/apache/kafka-site/pull/420#discussion_r924595805 ## css/fonts.css: ## @@ -0,0 +1,82 @@ +/* cutive-mono-regular - latin-ext_latin */ +@font-face { +font-family: 'Cutive Mono'; +font-style: normal; +font-

[GitHub] [kafka-site] bbejeck merged pull request #315: Adding La Redoute as powered by Kafka

2022-07-19 Thread GitBox
bbejeck merged PR #315: URL: https://github.com/apache/kafka-site/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] bbejeck commented on pull request #357: Update powered-by.html

2022-07-19 Thread GitBox
bbejeck commented on PR #357: URL: https://github.com/apache/kafka-site/pull/357#issuecomment-1189341290 Sorry for the delayed response - looks like this PR didn't add the `orcHome.jpg` can you add this? Then we'll get the PR merged -- This is an automated message from the Apache Git Serv

[GitHub] [kafka-site] bbejeck merged pull request #409: Add AllegroGraph to powerdy-by

2022-07-19 Thread GitBox
bbejeck merged PR #409: URL: https://github.com/apache/kafka-site/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] orchome commented on pull request #357: Update powered-by.html

2022-07-19 Thread GitBox
orchome commented on PR #357: URL: https://github.com/apache/kafka-site/pull/357#issuecomment-1189707477 > Sorry for the delayed response - looks like this PR didn't add the `orcHome.jpg` can you add this? Then we'll get the PR merged I can't `ERROR: Permission to apache/kafka-site

[GitHub] [kafka-site] mimaison merged pull request #424: KAFKA-13868: Replace Google Analytics with Matomo

2022-07-20 Thread GitBox
mimaison merged PR #424: URL: https://github.com/apache/kafka-site/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache

[GitHub] [kafka-site] 941design opened a new pull request, #426: fixed typos in powered-by for Qudosoft (#406)

2022-07-20 Thread GitBox
941design opened a new pull request, #426: URL: https://github.com/apache/kafka-site/pull/426 - 'micro service' -> 'microservice' - 'strife' -> 'strive' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] bbejeck merged pull request #426: fixed typos in powered-by for Qudosoft (#406)

2022-07-20 Thread GitBox
bbejeck merged PR #426: URL: https://github.com/apache/kafka-site/pull/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] bbejeck commented on pull request #425: Adding moengage in powered-by

2022-07-20 Thread GitBox
bbejeck commented on PR #425: URL: https://github.com/apache/kafka-site/pull/425#issuecomment-1190521598 @amrit-moengage can you rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka-site] amrit-moengage commented on pull request #425: Adding moengage in powered-by

2022-07-20 Thread GitBox
amrit-moengage commented on PR #425: URL: https://github.com/apache/kafka-site/pull/425#issuecomment-1191083293 @bbejeck [bbejeck](https://github.com/bbejeck) Rebased the branch, please get this merged. Thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka-site] bbejeck merged pull request #425: Adding moengage in powered-by

2022-07-21 Thread GitBox
bbejeck merged PR #425: URL: https://github.com/apache/kafka-site/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] mimaison merged pull request #420: KAFKA-13868: Self host fonts with project website

2022-07-22 Thread GitBox
mimaison merged PR #420: URL: https://github.com/apache/kafka-site/pull/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache

[GitHub] [kafka-site] divijvaidya opened a new pull request, #427: KAFKA-13868: Replace YouTube embedded video with hyperlinks

2022-07-25 Thread GitBox
divijvaidya opened a new pull request, #427: URL: https://github.com/apache/kafka-site/pull/427 As per the [discussion in the community](https://lists.apache.org/thread/p24xvbf8nkvxpbj668vc0g3x3lojsnk4), we want to replace the embedded YouTube videos with hyperlinks to satisfy the [ASF pri

[GitHub] [kafka-site] divijvaidya commented on pull request #427: KAFKA-13868: Replace YouTube embedded video with hyperlinks

2022-07-25 Thread GitBox
divijvaidya commented on PR #427: URL: https://github.com/apache/kafka-site/pull/427#issuecomment-1194393568 @bbejeck perhaps you would like to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] bbejeck merged pull request #427: KAFKA-13868: Replace YouTube embedded video with hyperlinks

2022-07-25 Thread GitBox
bbejeck merged PR #427: URL: https://github.com/apache/kafka-site/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] bbejeck commented on pull request #427: KAFKA-13868: Replace YouTube embedded video with hyperlinks

2022-07-25 Thread GitBox
bbejeck commented on PR #427: URL: https://github.com/apache/kafka-site/pull/427#issuecomment-1194536588 Thanks for this fix @divijvaidya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka-site] C0urante merged pull request #428: Add Chris Egerton to committers

2022-07-25 Thread GitBox
C0urante merged PR #428: URL: https://github.com/apache/kafka-site/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache

[GitHub] [kafka-site] C0urante commented on pull request #428: Add Chris Egerton to committers

2022-07-25 Thread GitBox
C0urante commented on PR #428: URL: https://github.com/apache/kafka-site/pull/428#issuecomment-1194548517 Thanks Bill! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka-site] divijvaidya opened a new pull request, #429: KAFKA-13868: Replace embedded YouTube links with hyperlinks on streams page

2022-07-27 Thread GitBox
divijvaidya opened a new pull request, #429: URL: https://github.com/apache/kafka-site/pull/429 This is a hot fix to merge the https://github.com/apache/kafka/pull/12438 into kafka-site to satisfy the ASF privacy policy requirements. ## Testing Tested locally. ![Screenshot 2022

[GitHub] [kafka-site] divijvaidya commented on pull request #429: KAFKA-13868: Replace embedded YouTube links with hyperlinks on streams page

2022-07-27 Thread GitBox
divijvaidya commented on PR #429: URL: https://github.com/apache/kafka-site/pull/429#issuecomment-1196687885 @mimaison please review. Last one before we can close KAFKA-13868. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka-site] showuon commented on pull request #429: KAFKA-13868: Replace embedded YouTube links with hyperlinks on streams page

2022-07-27 Thread GitBox
showuon commented on PR #429: URL: https://github.com/apache/kafka-site/pull/429#issuecomment-1196778133 @mimaison , do you want to have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka-site] mimaison merged pull request #429: KAFKA-13868: Replace embedded YouTube links with hyperlinks on streams page

2022-07-27 Thread GitBox
mimaison merged PR #429: URL: https://github.com/apache/kafka-site/pull/429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache

[GitHub] [kafka-site] bbejeck opened a new pull request, #430: MINOR: Add clickable images to load iframe videos

2022-07-29 Thread GitBox
bbejeck opened a new pull request, #430: URL: https://github.com/apache/kafka-site/pull/430 This PR is a follow-up #427. This PR adds a clickable link that will load an `iframe`; in line with the [ASF privacy policy](https://privacy.apache.org/faq/committers.html) on embedded YouTube vid

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-07-29 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1199820791 ping @divijvaidya, @mimaison , and @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-07-29 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1199926659 >One suggestion if it's not too much trouble, and if you agree... It might be obvious from context that that image is a button that plays a video, but it would be clearer if we superimpo

[GitHub] [kafka-site] vvcephei commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-07-29 Thread GitBox
vvcephei commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1200082801 Oh, that works! I was just thinking of editing the placeholder image itself to paste a stock play arrow on it. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka-site] sadatrafsan opened a new pull request, #431: Brain Station 23 adopted Kafka

2022-07-30 Thread GitBox
sadatrafsan opened a new pull request, #431: URL: https://github.com/apache/kafka-site/pull/431 Brain Station 23 is software development firm based in Dhaka, Bangladesh. Since its inception in 2006, Brain Station 23 has emerged as the hub of tech professionals, minds and enthusiasts. One of

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-07-30 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1200264008 @vvcephei I took a stab at putting a play button on the image - I think this version wins. Let me know what you think -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka-site] mimaison commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-01 Thread GitBox
mimaison commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1200929194 Thanks @bbejeck. I tested it locally and it looks good. Can we do the same to the Streams videos on https://kafka.apache.org/32/documentation/streams/ ? -- This is an automate

[GitHub] [kafka-site] divijvaidya commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-01 Thread GitBox
divijvaidya commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201010516 Thank you for fixing this @bbejeck! Two questions: 1. How do we know that this code will work on all (or reasonable number of) browsers? 2. As per the [ASF guideline

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-01 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201356851 > Thanks @bbejeck. > > I tested it locally and it looks good. Can we do the same to the Streams videos on https://kafka.apache.org/32/documentation/streams/ ? Hi @mimaison -

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-01 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201359633 > Thank you for fixing this @bbejeck! > > Two questions: > > 1. How do we know that this code will work on all (or reasonable number of) browsers? > 2. As per the [ASF g

[GitHub] [kafka-site] vvcephei commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-01 Thread GitBox
vvcephei commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201526829 Thanks, @bbejeck ! My suggestion is addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-01 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201532009 @divijvaidya[ I found a free online JS compatibility tester ](https://seedmanc.github.io/jscc/) Here is the result https://user-images.githubusercontent.com/199238/182212411-c3b

[GitHub] [kafka-site] mumrah merged pull request #432: Update website and javadocs for 3.2.1 release

2022-08-01 Thread GitBox
mumrah merged PR #432: URL: https://github.com/apache/kafka-site/pull/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.o

[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-02 Thread GitBox
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1202658336 Updated to include a warning about loading a video from a third party -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka-site] divijvaidya commented on pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-02 Thread GitBox
divijvaidya commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1202677727 > Updated to include a warning about loading a video from a third party @bbejeck you might have forgotten to push the commit? 😅 -- This is an automated message from the Apach

[GitHub] [kafka-site] bbejeck merged pull request #430: MINOR: Add clickable images to load iframe videos

2022-08-02 Thread GitBox
bbejeck merged PR #430: URL: https://github.com/apache/kafka-site/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] bbejeck opened a new pull request, #433: MINOR: Add placeholder images that will load iframe.

2022-08-03 Thread GitBox
bbejeck opened a new pull request, #433: URL: https://github.com/apache/kafka-site/pull/433 This PR is a follow-up from #430 and https://github.com/apache/kafka-site/pull/427. This PR adds a clickable image that will load an iframe for each one of the Kafka Streams videos. This aligns with

[GitHub] [kafka-site] bbejeck commented on pull request #433: MINOR: Add placeholder images that will load iframe.

2022-08-03 Thread GitBox
bbejeck commented on PR #433: URL: https://github.com/apache/kafka-site/pull/433#issuecomment-1204506779 Ping @vvcephei @mimaison @divijvaidya for review. Once this PR is approved, I'll do a mirror PR for the Apache Kafka repo -- This is an automated message from the Apache

[GitHub] [kafka-site] mimaison commented on pull request #433: MINOR: Add placeholder images that will load iframe.

2022-08-04 Thread GitBox
mimaison commented on PR #433: URL: https://github.com/apache/kafka-site/pull/433#issuecomment-1205049698 It does not seem to render quite right for me. The first video is fine: https://user-images.githubusercontent.com/903615/182822374-326f590b-c5bb-4ec8-af0f-9bc2e9e473e3.png";>

[GitHub] [kafka-site] bbejeck commented on pull request #433: MINOR: Add placeholder images that will load iframe.

2022-08-04 Thread GitBox
bbejeck commented on PR #433: URL: https://github.com/apache/kafka-site/pull/433#issuecomment-1205402084 @mimaison, I've addressed your comments - thanks for the review I think it's important to get back the original look and feel -- This is an automated message from the Apache Git Servi

[GitHub] [kafka-site] mimaison commented on pull request #433: MINOR: Add placeholder images that will load iframe.

2022-08-05 Thread GitBox
mimaison commented on PR #433: URL: https://github.com/apache/kafka-site/pull/433#issuecomment-1206863596 Thanks @bbejeck ! I think the placeholder images could be improved a bit more. They are pretty low resolution, not quite the same size and the play icon is not centered on some of th

[GitHub] [kafka-site] bbejeck commented on pull request #433: MINOR: Add placeholder images that will load iframe.

2022-08-05 Thread GitBox
bbejeck commented on PR #433: URL: https://github.com/apache/kafka-site/pull/433#issuecomment-1206877070 Thanks @mimaison I'll do a follow-up PR soon to try and get those cleaned up a bit -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] bbejeck merged pull request #433: MINOR: Add placeholder images that will load iframe.

2022-08-05 Thread GitBox
bbejeck merged PR #433: URL: https://github.com/apache/kafka-site/pull/433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] ableegoldman opened a new pull request, #434: Update my entry to include PMC membership

2022-08-08 Thread GitBox
ableegoldman opened a new pull request, #434: URL: https://github.com/apache/kafka-site/pull/434 cc @mjsax @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka-site] guozhangwang merged pull request #434: Update my entry to include PMC membership

2022-08-09 Thread GitBox
guozhangwang merged PR #434: URL: https://github.com/apache/kafka-site/pull/434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.ap

[GitHub] [kafka-site] guozhangwang commented on pull request #434: Update my entry to include PMC membership

2022-08-09 Thread GitBox
guozhangwang commented on PR #434: URL: https://github.com/apache/kafka-site/pull/434#issuecomment-1209614487 LGTM! Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka-site] bbejeck opened a new pull request, #435: MINOR:Clean up images

2022-08-10 Thread GitBox
bbejeck opened a new pull request, #435: URL: https://github.com/apache/kafka-site/pull/435 This PR is a follow-up to #433. The images have been cleaned up, and the play buttons are centered. Also, the `width` and `height` attributes have been removed, so the images render at their norma

[GitHub] [kafka-site] bbejeck commented on pull request #435: MINOR:Clean up images

2022-08-10 Thread GitBox
bbejeck commented on PR #435: URL: https://github.com/apache/kafka-site/pull/435#issuecomment-1210639264 @mimaison - this address comments for #433 - let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka-site] SimonRenault86 opened a new pull request, #436: HelloSafe Kafta

2022-08-11 Thread GitBox
SimonRenault86 opened a new pull request, #436: URL: https://github.com/apache/kafka-site/pull/436 HelloSafe is an international online insurance policy comparison platform. It is a completely free site, made available to consumers with the aim of helping them to facilitate their choice of

[GitHub] [kafka-site] SimonRenault86 closed pull request #436: HelloSafe Kafka

2022-08-11 Thread GitBox
SimonRenault86 closed pull request #436: HelloSafe Kafka URL: https://github.com/apache/kafka-site/pull/436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [kafka-site] SimonRenault86 opened a new pull request, #437: HelloSafe Kafta

2022-08-11 Thread GitBox
SimonRenault86 opened a new pull request, #437: URL: https://github.com/apache/kafka-site/pull/437 HelloSafe is an international online insurance policy comparison platform. It is a completely free site, made available to consumers with the aim of helping them to facilitate their choice of

[GitHub] [kafka-site] jsancio opened a new pull request, #438: MINOR; Add new signing key for jsan...@apache.org

2022-08-15 Thread GitBox
jsancio opened a new pull request, #438: URL: https://github.com/apache/kafka-site/pull/438 This key can also be found on keys.opengpg.org -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka-site] jsancio merged pull request #438: MINOR; Add new signing key for jsan...@apache.org

2022-08-15 Thread GitBox
jsancio merged PR #438: URL: https://github.com/apache/kafka-site/pull/438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] mimaison commented on pull request #435: MINOR:Clean up images

2022-08-16 Thread GitBox
mimaison commented on PR #435: URL: https://github.com/apache/kafka-site/pull/435#issuecomment-1216973319 @bbejeck I pushed new placeholders to your branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] bbejeck commented on a diff in pull request #431: Brain Station 23 adopted Kafka

2022-08-23 Thread GitBox
bbejeck commented on code in PR #431: URL: https://github.com/apache/kafka-site/pull/431#discussion_r953115247 ## powered-by.html: ## @@ -2,6 +2,12 @@

[GitHub] [kafka-site] sadatrafsan commented on pull request #431: Brain Station 23 adopted Kafka

2022-08-23 Thread GitBox
sadatrafsan commented on PR #431: URL: https://github.com/apache/kafka-site/pull/431#issuecomment-1225242243 > Hi @sadatrafsan, thanks for the PR - can you add the image `bs-23.png` to the `images/powered-by` directory? remote: Permission to apache/kafka-site.git denied to sadatrafsan

[GitHub] [kafka-site] sadatrafsan commented on pull request #431: Brain Station 23 adopted Kafka

2022-08-23 Thread GitBox
sadatrafsan commented on PR #431: URL: https://github.com/apache/kafka-site/pull/431#issuecomment-1225247466 image added to the instructed folder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka-site] mimaison merged pull request #435: MINOR:Clean up images

2022-08-24 Thread GitBox
mimaison merged PR #435: URL: https://github.com/apache/kafka-site/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache

[GitHub] [kafka-site] SimonRenault86 commented on pull request #437: HelloSafe Kafka

2022-08-29 Thread GitBox
SimonRenault86 commented on PR #437: URL: https://github.com/apache/kafka-site/pull/437#issuecomment-122633 Hello @bbejeck thanks a lot for your feedbacks, i added the picture -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka-site] bbejeck commented on pull request #431: Brain Station 23 adopted Kafka

2022-08-31 Thread GitBox
bbejeck commented on PR #431: URL: https://github.com/apache/kafka-site/pull/431#issuecomment-1233076438 > image added to the instructed folder Hi @sadatrafsan - did you forget to commit the image? I still don't see `bs-23.png` on your branch -- This is an automated message from th

[GitHub] [kafka-site] bbejeck merged pull request #437: HelloSafe Kafka

2022-08-31 Thread GitBox
bbejeck merged PR #437: URL: https://github.com/apache/kafka-site/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[GitHub] [kafka-site] bbejeck commented on pull request #437: HelloSafe Kafka

2022-08-31 Thread GitBox
bbejeck commented on PR #437: URL: https://github.com/apache/kafka-site/pull/437#issuecomment-1233090781 merged #437 into asf-site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka-site] bbejeck commented on pull request #437: HelloSafe Kafka

2022-08-31 Thread GitBox
bbejeck commented on PR #437: URL: https://github.com/apache/kafka-site/pull/437#issuecomment-1233091319 Thanks @SimonRenault86 for the addition to the Powered By page! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka-site] vvcephei commented on a change in pull request #301: Redo 2.6 docs commit

2020-09-08 Thread GitBox
vvcephei commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485142442 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can be us

[GitHub] [kafka-site] ableegoldman commented on a change in pull request #301: Redo 2.6 docs commit

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can b

[GitHub] [kafka-site] ableegoldman commented on a change in pull request #301: Redo 2.6 docs commit

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can b

[GitHub] [kafka-site] vvcephei merged pull request #301: Redo 2.6 docs commit

2020-09-09 Thread GitBox
vvcephei merged pull request #301: URL: https://github.com/apache/kafka-site/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka-site] viktorsomogyi edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo (and perhaps get someone to merge it).

[GitHub] [kafka-site] viktorsomogyi commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo. This is an automated

[GitHub] [kafka-site] ankit-kumar-25 commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
ankit-kumar-25 commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project: https://github.com/apache/kafka/pull/9314

[GitHub] [kafka-site] viktorsomogyi edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo (and perhaps get someone to merge it).

[GitHub] [kafka-site] viktorsomogyi commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo. This is an automated

[GitHub] [kafka-site] ankit-kumar-25 commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
ankit-kumar-25 commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project: https://github.com/apache/kafka/pull/9314

[GitHub] [kafka-site] ankit-kumar-25 edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread GitBox
ankit-kumar-25 edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project: https://github.com/apache/kafka/pu

[GitHub] [kafka-site] ankit-kumar-25 closed pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread GitBox
ankit-kumar-25 closed pull request #220: URL: https://github.com/apache/kafka-site/pull/220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka-site] scott-confluent opened a new pull request #302: Updating title on videos page

2020-10-13 Thread GitBox
scott-confluent opened a new pull request #302: URL: https://github.com/apache/kafka-site/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] mjsax merged pull request #302: Updating title on videos page

2020-10-13 Thread GitBox
mjsax merged pull request #302: URL: https://github.com/apache/kafka-site/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka-site] dajac opened a new pull request #303: Add dajac to committers

2020-10-16 Thread GitBox
dajac opened a new pull request #303: URL: https://github.com/apache/kafka-site/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka-site] dajac merged pull request #303: Add dajac to committers

2020-10-16 Thread GitBox
dajac merged pull request #303: URL: https://github.com/apache/kafka-site/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka-site] chia7712 opened a new pull request #304: Add chia7712 to committers

2020-10-16 Thread GitBox
chia7712 opened a new pull request #304: URL: https://github.com/apache/kafka-site/pull/304 hello Kafka :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

<    1   2   3   4   5   6   7   8   9   >