[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-03-29 Thread Nikola Tankovic (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241286#comment-13241286 ] Nikola Tankovic commented on LUCENE-3312: - Hi folks, I think this one could be

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241354#comment-13241354 ] Michael McCandless commented on LUCENE-3312: Hi Nikola, I think this plus LU

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-04-04 Thread Nikola Tankovic (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246424#comment-13246424 ] Nikola Tankovic commented on LUCENE-3312: - Hi guys, I submited first draft of pr

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-04-13 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253716#comment-13253716 ] Uwe Schindler commented on LUCENE-3312: --- Hi Michael, I would take the mentorship. W

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-04-14 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254162#comment-13254162 ] Uwe Schindler commented on LUCENE-3312: --- We had the GSoC interview today: [http://

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-04-23 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259939#comment-13259939 ] Nikola Tankovic commented on LUCENE-3312: - I want to thank you guys for the oppor

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-04-23 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259960#comment-13259960 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, I am glad to work with you this

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-04-27 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263826#comment-13263826 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, what's the plan to start with?

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279704#comment-13279704 ] Uwe Schindler commented on LUCENE-3312: --- While at the Lucene Revolution Conference,

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279786#comment-13279786 ] Yonik Seeley commented on LUCENE-3312: -- I'd argue that TopDocs is also expert level

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279793#comment-13279793 ] Uwe Schindler commented on LUCENE-3312: --- The TopDocs class is what IndexSearcher.se

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279799#comment-13279799 ] Yonik Seeley commented on LUCENE-3312: -- bq. The TopDocs class is what IndexSearcher.

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279810#comment-13279810 ] Uwe Schindler commented on LUCENE-3312: --- My intention wa snot to remove it complete

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279811#comment-13279811 ] Robert Muir commented on LUCENE-3312: - But its wrong now to put an IndexSearcher in T

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279979#comment-13279979 ] Uwe Schindler commented on LUCENE-3312: --- Robert, I agree about that! I am just disc

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284717#comment-13284717 ] Michael McCandless commented on LUCENE-3312: Patch looks great! I'm not sure

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-29 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284719#comment-13284719 ] Chris Male commented on LUCENE-3312: {quote} I'm not sure IndexableField should exten

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-29 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284721#comment-13284721 ] Nikola Tankovic commented on LUCENE-3312: - OK, I agree with decoupling. Can I mak

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-29 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284724#comment-13284724 ] Chris Male commented on LUCENE-3312: I'm not sure that's needed. In the end Indexabl

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-29 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284726#comment-13284726 ] Nikola Tankovic commented on LUCENE-3312: - OK, thank you! I was not sure about th

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-31 Thread Andrzej Bialecki (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286909#comment-13286909 ] Andrzej Bialecki commented on LUCENE-3312: --- Comments to patch 04: * index.Doc

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-05-31 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287136#comment-13287136 ] Chris Male commented on LUCENE-3312: bq. index.Document is an interface, I think for

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-01 Thread Eks Dev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287213#comment-13287213 ] Eks Dev commented on LUCENE-3312: - bq. My assumption is that StoredField-s will never be

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-01 Thread Andrzej Bialecki (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287267#comment-13287267 ] Andrzej Bialecki commented on LUCENE-3312: --- bq. We already have Document and i

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-01 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287294#comment-13287294 ] Chris Male commented on LUCENE-3312: bq. With the Field class implementing IndexableF

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287364#comment-13287364 ] Michael McCandless commented on LUCENE-3312: I think I like this decoupling .

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-01 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287380#comment-13287380 ] Chris Male commented on LUCENE-3312: I am all for the decoupling too, just want to th

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287987#comment-13287987 ] Michael McCandless commented on LUCENE-3312: {quote} Separately, I think even

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-02 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287999#comment-13287999 ] Nikola Tankovic commented on LUCENE-3312: - bq. Nikola, before you modify any of t

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288003#comment-13288003 ] Uwe Schindler commented on LUCENE-3312: --- I am back @ office, trying to catch up.

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-07-27 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423853#comment-13423853 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, should I merge up the branch to

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-07-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424319#comment-13424319 ] Uwe Schindler commented on LUCENE-3312: --- Thanks Nikola, I applied your patch in rev

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-07-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424320#comment-13424320 ] Uwe Schindler commented on LUCENE-3312: --- Merged up to trunk in revision: 1366643

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-08 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431240#comment-13431240 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, next week is "pencils down", so

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-08 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431433#comment-13431433 ] Uwe Schindler commented on LUCENE-3312: --- bq. Some tests throw OutOfMemory errors (b

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431712#comment-13431712 ] Uwe Schindler commented on LUCENE-3312: --- Patch applied revision: 1371131

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431717#comment-13431717 ] Uwe Schindler commented on LUCENE-3312: --- I merged the branch up to current trunk (r

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431719#comment-13431719 ] Chris Male commented on LUCENE-3312: Hey Nikola, bq. except for mentioned TestQualit

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431728#comment-13431728 ] Nikola Tankovic commented on LUCENE-3312: - Well some stats in this test are hurt:

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431807#comment-13431807 ] Robert Muir commented on LUCENE-3312: - Something is going wrong with the indexing of

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431828#comment-13431828 ] Chris Male commented on LUCENE-3312: Wow, I have replicated the same behaviour. On t

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431833#comment-13431833 ] Chris Male commented on LUCENE-3312: Ah I think I found the problem, it's in Document

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431836#comment-13431836 ] Robert Muir commented on LUCENE-3312: - nice: the bug wasn't obvious to me (i glanced

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431838#comment-13431838 ] Nikola Tankovic commented on LUCENE-3312: - I found the problem, will report in a

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431839#comment-13431839 ] Chris Male commented on LUCENE-3312: Yup found it. The problem is in the branch {{

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431841#comment-13431841 ] Chris Male commented on LUCENE-3312: Nikola, we should probably move all of Document'

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431843#comment-13431843 ] Robert Muir commented on LUCENE-3312: - Can we not return a new list? I don't think we

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431845#comment-13431845 ] Robert Muir commented on LUCENE-3312: - {quote} I don't mind if we want to make getFie

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431848#comment-13431848 ] Nikola Tankovic commented on LUCENE-3312: - Yes, that is the problem. clear() meat

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431849#comment-13431849 ] Chris Male commented on LUCENE-3312: Yeah we definitely shouldn't return a new list.

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431851#comment-13431851 ] Chris Male commented on LUCENE-3312: Oh we should also include a unit test that verif

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431852#comment-13431852 ] Robert Muir commented on LUCENE-3312: - +1, nobody should have to debug TestQualityRun

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431858#comment-13431858 ] Nikola Tankovic commented on LUCENE-3312: - OK, will do that, and also a Document.

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431867#comment-13431867 ] Chris Male commented on LUCENE-3312: Nikola, On a totally note totally unrelated to

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431874#comment-13431874 ] Nikola Tankovic commented on LUCENE-3312: - I'm sure someone knows a better way to

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431880#comment-13431880 ] Chris Male commented on LUCENE-3312: {code} public final List getFields() { return

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431884#comment-13431884 ] Nikola Tankovic commented on LUCENE-3312: - Chris, I tried to go with StorableFie

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432041#comment-13432041 ] Michael McCandless commented on LUCENE-3312: Branch + current patch looks gre

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432049#comment-13432049 ] Robert Muir commented on LUCENE-3312: - I was confused about one thing, Norm.java has

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432182#comment-13432182 ] Uwe Schindler commented on LUCENE-3312: --- I applied patch to current branch, but it

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-13 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433093#comment-13433093 ] Uwe Schindler commented on LUCENE-3312: --- Your patch is also missing the replacement

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-13 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433150#comment-13433150 ] Uwe Schindler commented on LUCENE-3312: --- Applied patch to branch in revision 137242

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-13 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433161#comment-13433161 ] Uwe Schindler commented on LUCENE-3312: --- Merged up to trunk revision: 1372438 Ther

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-15 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434968#comment-13434968 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, we should now use the remainin

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-15 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434970#comment-13434970 ] Chris Male commented on LUCENE-3312: Is it going to be possible to address IndexableF

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-15 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434972#comment-13434972 ] Uwe Schindler commented on LUCENE-3312: --- Hi, I merged up to trunk (to get jenkins c

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-15 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434996#comment-13434996 ] Uwe Schindler commented on LUCENE-3312: --- First build succeeded: http://jenkins.sd-

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-15 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435324#comment-13435324 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, the first build was not done us

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-16 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436142#comment-13436142 ] Uwe Schindler commented on LUCENE-3312: --- OK, applied and committed the patch, rev 1

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436713#comment-13436713 ] Uwe Schindler commented on LUCENE-3312: --- How should we proceed with this? I think t

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-17 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436755#comment-13436755 ] Chris Male commented on LUCENE-3312: We definitely need to clean up StorableFieldType

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-19 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437489#comment-13437489 ] Uwe Schindler commented on LUCENE-3312: --- Merged up to trunk revision: 1374718

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-19 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437575#comment-13437575 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, afetr the branch merge, the mor

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437905#comment-13437905 ] Uwe Schindler commented on LUCENE-3312: --- Applied patch in revision 1375040. Thanks

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-25 Thread Uwe Schindler (JIRA)
Uwe Schindler

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-25 Thread Uwe Schindler (JIRA)
Uwe Schindler

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-25 Thread Chris Male (JIRA)
Chris Male c

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-25 Thread Uwe Schindler (JIRA)
Uwe Schindler

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-25 Thread Chris Male (JIRA)
Chris Male c

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445383#comment-13445383 ] Uwe Schindler commented on LUCENE-3312: --- I merged in the recent changes in trunk (r

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445462#comment-13445462 ] Robert Muir commented on LUCENE-3312: - {code} * If you also need to store the value,

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445481#comment-13445481 ] Robert Muir commented on LUCENE-3312: - I echo Chris on the confusion of StorableField

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445484#comment-13445484 ] Robert Muir commented on LUCENE-3312: - and some of my javadocs warnings on DocumentSt

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445503#comment-13445503 ] Robert Muir commented on LUCENE-3312: - By the way, these werent meant to be objection

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445669#comment-13445669 ] Uwe Schindler commented on LUCENE-3312: --- bq. and some of my javadocs warnings on Do

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-31 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445842#comment-13445842 ] Chris Male commented on LUCENE-3312: I've thought about this a little bit. {quote} T

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445853#comment-13445853 ] Robert Muir commented on LUCENE-3312: - This is not really a viable option. its n rand

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445852#comment-13445852 ] Uwe Schindler commented on LUCENE-3312: --- bq. What if they were returned? Because yo

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-08-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445854#comment-13445854 ] Uwe Schindler commented on LUCENE-3312: --- Yeah right! Every value is a seek.

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446923#comment-13446923 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, I am about to reintegrate the

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-02 Thread Nikola Tankovic (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446939#comment-13446939 ] Nikola Tankovic commented on LUCENE-3312: - Hi Uwe, it would be most helpful if

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446944#comment-13446944 ] Uwe Schindler commented on LUCENE-3312: --- Hi Nikola, just download the 4.0-BETA rele

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-02 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446962#comment-13446962 ] Chris Male commented on LUCENE-3312: Thanks Uwe and Nikola! > Break

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446966#comment-13446966 ] Uwe Schindler commented on LUCENE-3312: --- I opened LUCENE-4347 as container issue fo

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451238#comment-13451238 ] David Smiley commented on LUCENE-3312: -- Uwe, can you please explain why you changed

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451574#comment-13451574 ] Uwe Schindler commented on LUCENE-3312: --- s/Uwe/Nikola/; > Break ou

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-09-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451579#comment-13451579 ] Chris Male commented on LUCENE-3312: David, just at a guess I imagine the branch used

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292389#comment-13292389 ] Michael McCandless commented on LUCENE-3312: I think, given the discussions i

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-09 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292467#comment-13292467 ] Chris Male commented on LUCENE-3312: Following on from that, I don't think we should

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-06-10 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292486#comment-13292486 ] Uwe Schindler commented on LUCENE-3312: --- I think as we have 2 interfaces, we should

  1   2   >