[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005735#comment-14005735 ] Shai Erera commented on LUCENE-5693: So the question is, if we think the common case

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005736#comment-14005736 ] Michael McCandless commented on LUCENE-5693: bq. So if we want to rename the

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005740#comment-14005740 ] Michael McCandless commented on LUCENE-5693: bq. couldn't we change the code

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005751#comment-14005751 ] ASF subversion and git services commented on LUCENE-5693: - Commit

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005754#comment-14005754 ] Shai Erera commented on LUCENE-5693: I don't see what's wrong w/ not sending the

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005787#comment-14005787 ] Simon Willnauer commented on LUCENE-5693: - I really wonder if this issue matters.

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005795#comment-14005795 ] Shai Erera commented on LUCENE-5693: Hmm, I reviewed SortedDVWriter and I understand

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005828#comment-14005828 ] Michael McCandless commented on LUCENE-5693: bq. I really wonder if this

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005837#comment-14005837 ] Shai Erera commented on LUCENE-5693: bq. But I'll resolve this as WONTFIX ... looks

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005862#comment-14005862 ] Robert Muir commented on LUCENE-5693: - {quote} I guess what bothers me here is this

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006306#comment-14006306 ] ASF subversion and git services commented on LUCENE-5693: - Commit

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004821#comment-14004821 ] Robert Muir commented on LUCENE-5693: - This only makes sense for postings though.

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004835#comment-14004835 ] Shai Erera commented on LUCENE-5693: Today we apply the deletes (update the bitset)

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004902#comment-14004902 ] Michael McCandless commented on LUCENE-5693: bq. how would we do that while

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004906#comment-14004906 ] Michael McCandless commented on LUCENE-5693: bq. This only makes sense for

[jira] [Commented] (LUCENE-5693) don't write deleted documents on flush

2014-05-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005450#comment-14005450 ] Robert Muir commented on LUCENE-5693: - {quote} I disagree: I think we discover places