Re: Reproducible builds between OSes

2023-02-12 Thread Romain Manni-Bucau
Since it can be set in MAVEN_OPTS issue is maybe not that a big deal. Le lun. 13 févr. 2023 à 07:22, Christoph Läubrich a écrit : > > On the bright side, `System.lineSeparator()` is almost never used > > I use that all day long in my code, and probably this will change for > other classes as we

Re: [VOTE] Release Maven Deploy Plugin 3.1.0

2023-02-12 Thread Tamás Cservenák
Howdy, Well, IMHO MDEPLOY-206 should be in release notes, as it carries substantial code change that needs to be explained: These both commits run under that issue: https://github.com/apache/maven-deploy-plugin/commit/59bee05f8a935f4c8ac9fcf0da47bab60c425e92 https://github.com/apache/maven-deploy-

Re: [VOTE] Release Maven Invoker Plugin version 3.5.0

2023-02-12 Thread Olivier Lamy
+1 On Mon, 13 Feb 2023 at 05:42, Michael Osipov wrote: > > Hi, > > we solved 9 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317525&version=12352645 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MIN

Re: Reproducible builds between OSes

2023-02-12 Thread Christoph Läubrich
> On the bright side, `System.lineSeparator()` is almost never used I use that all day long in my code, and probably this will change for other classes as well, so relying on that people use the system property seems broken by design. Am 12.02.23 um 23:28 schrieb Piotr P. Karwasz: Hi Elliott

Re: Reproducible builds between OSes

2023-02-12 Thread Elliotte Rusty Harold
On Sun, Feb 12, 2023 at 10:28 PM Piotr P. Karwasz wrote: > Unfortunately it is used whenever `BufferedWriter` or `PrintStream` is > used, so the simplest build that uses the "jar" plugin will already be > system dependent ("pom.properties" uses the line separator). Yes, I am aware. Believe it o

Re: Reproducible builds between OSes

2023-02-12 Thread Piotr P. Karwasz
Hi Elliotte, On Sat, 11 Feb 2023 at 14:02, Elliotte Rusty Harold wrote: > IMHO in 2023 the problem is that anything relies on a system dependent > line.separator instead of explicitly specifying which bytes are > output. I've fixed some instances of that antipattern over the years. > Please file

[VOTE] Release Maven Invoker Plugin version 3.5.0

2023-02-12 Thread Michael Osipov
Hi, we solved 9 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317525&version=12352645 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MINVOKER%20AND%20resolution%20%3D%20Unresolved Staging repo: https://rep

[VOTE] Release Maven Fluido Skin version 2.0.0-M3

2023-02-12 Thread Michael Osipov
IMPORTANT: Requires Maven Site Plugin 4.0.0-M5 vote/staging repo! Hi, We solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12352919 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS

[VOTE] Release Maven Javadoc Plugin version 3.5.0

2023-02-12 Thread Michael Osipov
Hi, We solved 8 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12352256 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MJAVADOC/issues Staging repo: https://repository.apache.org/content/repositories/maven-1870

Re: GitHub release notes ...

2023-02-12 Thread Jorge Solórzano
Hi, First, with every vote for a release, there is a link for the issues fixed in Jira, but I have seen that some links to the Release Notes of Jira, and others just link to the filter of "Fix version" in Jira, to me the link should always be the Release Notes, not the filter of issues. A second

Re: GitHub release notes ...

2023-02-12 Thread Falko Modler
Hi, > what about just set a link to the JIRA release notes for all GitHub release > notes. I like this minimalist approach, better than having no changes info in GitHub at all. GH release notes are very handy for update bots like renovate. Most of the time I don't see any release notes in such

Re: GitHub release notes ...

2023-02-12 Thread tison
Hi, > I agree the source of truth is our jira release notes. I'm new to maven projects here. If the quoted statement is true, what about just set a link to the JIRA release notes for all GitHub release notes. Then the task is eased and we don't maintain multiple pages with full content. ... or t

GitHub release notes ...

2023-02-12 Thread Slawomir Jaranowski
Hi, I know the subject is returning again ... When we once create GitHub release notes we should maintain it for each new release ... I agree the source of truth is our jira release notes. In other cases we have missing information about releases and users can be confused. Dependabot uses GitHu

Re: [VOTE] Release Maven Site Plugin version 4.0.0-M5

2023-02-12 Thread Michael Osipov
Am 2023-02-11 um 21:42 schrieb Michael Osipov: Hi, IMPORTANT: Requires Maven Reporting Impl 4.0.0-M4 vote/staging repo! We solved 9 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12352751 There are still a couple of issues left in JIRA: https://issues

Re: [VOTE] Release Apache Maven Reporting Impl version 4.0.0-M4

2023-02-12 Thread Michael Osipov
Am 2023-02-11 um 20:48 schrieb Michael Osipov: Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12352665 There are a few issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20U

Re: [VOTE] Release Maven Deploy Plugin 3.1.0

2023-02-12 Thread Slawomir Jaranowski
Hi, Agree with Olivier MDEPLOY-206 will be resolved by MRESOLVER-32 so should not be a part of current release notes. wt., 7 lut 2023 o 00:36 Olivier Lamy napisał(a): > +1 > But https://issues.apache.org/jira/browse/MDEPLOY-206 should not be > part of the release notes as it doesn't work yet s

Re: [VOTE] Apache Maven Surefire 3.0.0-M9

2023-02-12 Thread Olivier Lamy
On Sat, 11 Feb 2023 at 20:50, Michael Osipov wrote: > > Am 2023-02-10 um 10:21 schrieb Olivier Lamy: > > Hi, > > I'd like to release Apache Maven Surefire 3.0.0-M9 > > We fixed 4 issues. > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12352730 > > > > Staging

Re: [VOTE] Apache Maven Surefire 3.0.0-M9

2023-02-12 Thread Karl Heinz Marbaise
Hi, +1 from me. Kind regards Karl Heinz Marbaise On 10.02.23 10:21, Olivier Lamy wrote: Hi, I'd like to release Apache Maven Surefire 3.0.0-M9 We fixed 4 issues. https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12352730 Staging repo: https://repository.apache.o