Re: MNG-6069 2nd - seconders

2019-05-17 Thread Robert Scholte
My concern is that somebody sees a deprecated GnuParser and will replace it without knowing why we left it here, hence I've added a simple unittest that should reflect the usecase and which fails once replacing GnuParser with DefaultParser. So now it is +1 for me On 16-5-2019 23:40:06, Sylweste

Re: MNG-6069 2nd - seconders

2019-05-16 Thread Sylwester Lachiewicz
Hi Robert, I tested this change locally and yes it works fine with additional space after -D Here is note in Jira: For now, leave GnuParser. Despite the upgrade advice in the GnuParser Javadoc > ("since 1.3, use the DefaultParser instead"), it behaves differently (see this > Stack Overflow answer

Re: MNG-6069 2nd - seconders

2019-05-15 Thread Robert Scholte
There's an important line in the description: "Ensure that the following command succeeds: mvn -X -D x=1 -D y=2 test ( watch out for the space after -D )" Maybe I'm not looking good enough, but I don't see any related codechanges for this. thanks, Robert On Wed, 15 May 2019 21:10:43 +0200

Re: MNG-6069 2nd - seconders

2019-05-15 Thread Sylwester Lachiewicz
kindly reminder, anyone to look and confirm on ML? W dniu niedz., 12.05.2019 o 23:08 Sylwester Lachiewicz < slachiew...@gmail.com> napisaƂ(a): > Hi, > We have fix for MNG-6069 Migrate to non deprecated parts of Commons CLI - > 2nd attempt > https://issues.apache.org/jira/browse/MNG-6069 > PR: htt

MNG-6069 2nd - seconders

2019-05-12 Thread Sylwester Lachiewicz
Hi, We have fix for MNG-6069 Migrate to non deprecated parts of Commons CLI - 2nd attempt https://issues.apache.org/jira/browse/MNG-6069 PR: https://github.com/apache/maven/pull/247 commit: https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b01f861729214e45a1f3754ed5456bcdc1c3b4fc CI build: