Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 17, 2014, 6:53 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review57113 --- Bad patch! Reviews applied: [26610, 26861, 26862] Failed command:

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/ --- (Updated Oct. 17, 2014, 2:11 a.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26861: Schedule docker containers for removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/#review57112 --- Patch looks great! Reviews applied: [26610, 26861] All tests passe

Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript

Review Request 26861: Schedule docker containers for removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [26736] > > > > Failed command: git apply --index 26736.patch > > > > Error: > > error: patch failed: src/docker/docker.cpp:472 > > error: src/docker/docker.cpp: patch does not apply > > error: patc

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/#review57106 --- Bad patch! Reviews applied: [26857, 26859, 26857] Failed command:

Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw

> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [26736] > > > > Failed command: git apply --index 26736.patch > > > > Error: > > error: patch failed: src/docker/docker.cpp:472 > > error: src/docker/docker.cpp: patch does not apply > > error: patc

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57104 --- Sorry for this non-throrrough review but one thing that popped up fo

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/#review57102 --- Patch looks great! Reviews applied: [26855] All tests passed. - M

Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 17, 2014, 4:08 a.m.) Review request for mesos, Adam B, Benjamin H

Review Request 26859: Integrated CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS

Review Request 26857: Added CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS

Re: Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/ --- (Updated Oct. 16, 2014, 11:28 p.m.) Review request for mesos, Niklas Nielsen an

Review Request 26855: Added setup/teardown for module API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26855/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos-

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2182

See

Re: Review Request 26702: Updated reconciliation semantics to take the task's unacknowledged state into account.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/#review57093 --- Patch looks great! Reviews applied: [26846, 26699, 26700, 26701, 26

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2456

See

Re: Review Request 26825: MESOS-1712: Automate disallowing of commits mixing mesos/libprocess/stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26825/#review57081 --- support/hooks/pre-commit

Re: Review Request 26723: Escape JSON object keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/#review57082 --- Patch looks great! Reviews applied: [26723] All tests passed. - M

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26701: Updated master to update task unacknowledged state properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26701/ --- (Updated Oct. 17, 2014, 12:31 a.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 26702: Updated reconciliation semantics to take the task's unacknowledged state into account.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/ --- (Updated Oct. 17, 2014, 12:31 a.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 26700: Updated Slave to send latest task state in update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26700/ --- (Updated Oct. 17, 2014, 12:30 a.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 4:03 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2181

See Changes: [yujie.jay] Added an advisory message reminding the user to initialize the log. [yujie.jay] Fixed a typo in the last commit. [yujie.jay] Supported O_CLOEXEC for os::open on all platforms. [

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- (Updated Oct. 17, 2014, 12:26 a.m.) Review request for mesos, Adam B, Ben Mahle

Review Request 26846: Updated status update manager to forward updates via slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26846/ --- Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. Repository: m

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2455

See Changes: [yujie.jay] Added an advisory message reminding the user to initialize the log. [yujie.jay] Fixed a typo in the last commit. [yujie.jay] Supported O_CLOEXEC f

Re: Review Request 26843: Refactored stout os open/close/fcntl.

> On Oct. 16, 2014, 11:40 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fcntl.hpp, line 24 > > > > > > Any TODO you can think of to avoid needing to deal with multiple calls > > to fcn

Re: Review Request 26825: MESOS-1712: Automate disallowing of commits mixing mesos/libprocess/stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26825/#review57056 --- Patch looks great! Reviews applied: [26825] All tests passed. - M

Re: Review Request 26843: Refactored stout os open/close/fcntl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26843/#review57050 --- Ship it! Ah, much nicer, thanks Jie! 3rdparty/libprocess/3rdparty

Re: Review Request 26838: Fix module API version tests.

> On Oct. 16, 2014, 4:20 p.m., Vinod Kone wrote: > > src/tests/module_tests.cpp, line 332 > > > > > > What happens if this test fails and this line doesn't get executed? > > Does it affect other tests? If yes, thats b

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Review Request 26843: Refactored stout os open/close/fcntl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26843/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: Review Request 26838: Fix module API version tests.

Yes - it turned out not to be enough. Will disable tests so we have more time to fix this properly. Niklas On 16 October 2014 16:20, Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 26827: MESOS-1881: Reviewbot should not apply reviews that are submitted.

> On Oct. 16, 2014, 10:54 p.m., Ben Mahler wrote: > > support/verify-reviews.py, lines 84-87 > > > > > > We probably shouldn't still be saying "Now apply this review and then > > say skip it. > > > > I'll adju

Re: Review Request 26838: Fix module API version tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26838/#review57041 --- src/tests/module_tests.cpp

Re: Review Request 26838: Fix module API version tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26838/#review57040 --- Ship it! Ship It! - Ian Downes On Oct. 16, 2014, 4:13 p.m., Kapi

Re: Review Request 26838: Fix module API version tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26838/#review57038 --- Ship it! Ship It! - Niklas Nielsen On Oct. 16, 2014, 4:13 p.m.,

Re: Review Request 26838: Fix module API version tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26838/#review57037 --- Ship it! Ship It! - Till Toenshoff On Oct. 16, 2014, 11:13 p.m.,

Review Request 26838: Fix module API version tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26838/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Descriptio

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2454

ecover.cpp:188] Received a recover response >> from a replica in EMPTY status >> I1016 22:38:58.463881 16241 recover.cpp:542] Updating replica status to >> STARTING >> I1016 22:38:58.464287 16240 leveldb.cpp:306] Persisting metadata (8 >> bytes) to leveldb took 306803ns >&g

Re: Review Request 26723: Escape JSON object keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/#review57029 --- Ship it! Thanks Cody! I will let adam commit this. - Ben Mahler

Re: Review Request 26827: MESOS-1881: Reviewbot should not apply reviews that are submitted.

> On Oct. 16, 2014, 10:54 p.m., Ben Mahler wrote: > > Thanks! I'll get this committed shortly. FYI I cleaned up the commit message to not reference reviewbot, since it's not a concept in the source: commit f6aa4b04d2e669e1e6cbcaf8fb708ab1cd6410eb Author: Cody Maloney Date: Thu Oct 16 15:54:

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

> On Oct. 16, 2014, 9:58 p.m., Jay Buffington wrote: > > src/log/recover.cpp, lines 298-302 > > > > > > You missed --path: > > mesos-log initialize --path= I've committed a fix. - Jie -

Re: Review Request 26827: MESOS-1881: Reviewbot should not apply reviews that are submitted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26827/#review57026 --- Ship it! Thanks! I'll get this committed shortly. support/verify-

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2180

ster.cpp:1426] Registering framework 20141016-225013-3142697795-53609-28427- (default) at scheduler-0552db12-4b6e-4d3f-8231-b8555d10a558@67.195.81.187:53609 I1016 22:50:13.211447 28454 hierarchical_allocator_process.hpp:329] Added framework 20141016-225013-3142697795-53609-28

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2454

ica status to > STARTING > I1016 22:38:58.464287 16240 leveldb.cpp:306] Persisting metadata (8 bytes) > to leveldb took 306803ns > I1016 22:38:58.464303 16240 replica.cpp:320] Persisted replica status to > STARTING > I1016 22:38:58.464306 16248 master.cpp:312] Master >

Re: Review Request 26723: Escape JSON object keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/#review57025 --- Ship it! LGTM 3rdparty/libprocess/3rdparty/stout/include/stout/js

Re: Review Request 26727: Hooked Isolator module to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/#review57022 --- What testing did you do? Also, let's use another term than 'hooked'

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review57023 --- Bad patch! Reviews applied: [26817, 26382] Failed command: git app

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2454

06 16248 master.cpp:312] Master 20141016-223858-3193029443-47942-16220 (pietas.apache.org) started on 67.195.81.190:47942 I1016 22:38:58.464375 16248 master.cpp:358] Master only allowing authenticated frameworks to register I1016 22:38:58.464436 16246 recover.cpp:451] Replica is in STARTING

Re: Review Request 26071: Sample isolator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57013 --- src/Makefile.am

Re: Review Request 26797: Added --isolation flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/#review57021 --- Bad patch! Reviews applied: [26674] Failed command: git apply --in

Re: Review Request 26723: Escape JSON object keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/ --- (Updated Oct. 16, 2014, 10:13 p.m.) Review request for mesos and Adam B. Chan

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review57018 --- Patch looks great! Reviews applied: [26815] All tests passed. - M

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review57016 --- src/log/recover.cpp

Review Request 26827: MESOS-1881: Reviewbot should not apply reviews that are submitted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26827/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1881 https://issues.ap

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2179

See

Review Request 26825: MESOS-1712: Automate disallowing of commits mixing mesos/libprocess/stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26825/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1712 and MESOS-193

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review56999 --- Patch looks great! Reviews applied: [17431] All tests passed. - M

Re: Review Request 26766: MESOS-1878: Add additional helper functions to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26766/ --- (Updated Oct. 16, 2014, 8:53 p.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 26767: MESOS-1878: Fix files/files.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26767/ --- (Updated Oct. 16, 2014, 8:53 p.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review56987 --- include/mesos/mesos.proto

Re: Review Request 26382: Add source and reason to TaskStatus.

> On Oct. 16, 2014, 12:43 p.m., Bill Farner wrote: > > include/mesos/mesos.proto, line 664 > > > > > > `required` unsafe to introduce without a default, right? IIUC it means > > you can't read a message that doesn't

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 16, 2014, 1:20 p.m.) Review request for mesos, Vinod Kone and Bil

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 16, 2014, 4:15 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56988 --- Ship it! I'll fix the last nits. src/module/manager.hpp

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review56979 --- include/mesos/mesos.proto

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/#review56980 --- Patch looks great! Reviews applied: [26798] All tests passed. - M

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 16, 2014, 12:28 p.m.) Review request for mesos, Vinod Kone and Bi

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 16, 2014, 12:28 p.m.) Review request for mesos, Vinod Kone and Bi

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 16, 2014, 12:28 p.m.) Review request for mesos, Vinod Kone and Bi

Re: Review Request 26382: Add source and reason to TaskStatus.

> On Oct. 7, 2014, 11:50 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 2264 > > > > > > invalid offers is a bit tricky. because there are several subcases here. > > > > 1) framework used the offer a

Re: Review Request 26382: Add source and reason to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 16, 2014, 12:26 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 26797: Added --isolation flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/ --- (Updated Oct. 16, 2014, 3:23 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/ --- (Updated Oct. 16, 2014, 3:23 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26727: Hooked Isolator module to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/ --- (Updated Oct. 16, 2014, 3:22 p.m.) Review request for mesos, Ian Downes and Nik

Re: Review Request 26071: Sample isolator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 3:20 p.m.) Review request for mesos, Bernd Mathiske, Ia

Re: Review Request 26071: Sample isolator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 3:19 p.m.) Review request for mesos, Bernd Mathiske, Ia

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review56976 --- Ship it! src/log/recover.cpp

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/ --- (Updated Oct. 16, 2014, 7:11 p.m.) Review request for mesos, Ben Mahler, Vinod

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review56973 --- src/log/recover.cpp

Review Request 26817: Split authorization from task validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review56972 --- Ship it! Thank!! - Bill Farner On Oct. 16, 2014, 6:39 p.m., Jie

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review56971 --- Ship it! Ship It! - Vinod Kone On Oct. 16, 2014, 6:39 p.m., Jie

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56970 --- Ship it! Ship It! - Niklas Nielsen On Oct. 16, 2014, 11:43 a.m.,

Re: Review Request 26789: Allow unloading a single module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 16, 2014, 2:43 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26789: Allow unloading a single module.

> On Oct. 16, 2014, 12:59 p.m., Till Toenshoff wrote: > > src/module/manager.cpp, lines 195-197 > > > > > > This sounds very temporarily almost like a TODO. Fixed the explanation. - Kapil -

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/ --- (Updated Oct. 16, 2014, 2:43 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 16, 2014, 6:41 p.m.) Review request for mesos, Michael Lunøe and

Re: Review Request 26796: Added --modules flag for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26796/#review56968 --- Patch looks great! Reviews applied: [26674, 26071, 26796] All test

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/ --- (Updated Oct. 16, 2014, 6:39 p.m.) Review request for mesos, Ben Mahler, Vinod

Re: Review Request 26674: Added "name" to Modules protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56966 --- src/tests/module_tests.cpp

Re: Review Request 26674: Added "name" to Modules protobuf.

> On Oct. 16, 2014, 2:23 p.m., Niklas Nielsen wrote: > > src/master/flags.hpp, lines 313-315 > > > > > > Thanks for clarifying! The order of the paragraphs seems a bit off > > though: First the json file, then the cav

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review56963 --- src/log/recover.cpp

Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26815/#review56964 --- Ship it! I doubt my shipit counts... but looks good to me. :) - To

  1   2   >