Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/958
I'm all set, +1. Thanks for this, it's great stuff.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/958
Moving this conversation to the top. I believe I have refactored the
KafkaProducers appropriately. Let me know if I missed something, @justinleet
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/958
@justinleet thanks for the review. I reacted to your comments either by
fixing them or suggesting why I prefer what is there. I will add a new set of
tests in the next commit.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/958
# Testing Plan:
We presume
* `ZOOKEEPER` is an environment variable set to the zk quorum (e.g.
`node1:2181`)
* `BROKER` is an environment variable set to the broker (e.g. `node1:6667`)
