Re: [PR] ci(github action): Docker integration tests [myfaces-tobago]

2023-11-28 Thread via GitHub
bohmber commented on PR #4543: URL: https://github.com/apache/myfaces-tobago/pull/4543#issuecomment-1829829839 I can see it's downloading snapshots during build. I think we should switch off the apache snapshot repository. Can you add this to the root pom? ```

[PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub
henningn opened a new pull request, #4557: URL: https://github.com/apache/myfaces-tobago/pull/4557 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub
henningn opened a new pull request, #4558: URL: https://github.com/apache/myfaces-tobago/pull/4558 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub
henningn merged PR #4557: URL: https://github.com/apache/myfaces-tobago/pull/4557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

Re: [PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub
henningn merged PR #4558: URL: https://github.com/apache/myfaces-tobago/pull/4558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

Re: [PR] ci(github action): Docker integration tests [myfaces-tobago]

2023-11-28 Thread via GitHub
bohmber commented on PR #4543: URL: https://github.com/apache/myfaces-tobago/pull/4543#issuecomment-1830031931 Our jasmine test are not stable enough for integration in the ci workflow. I would suggest a manual trigger via `workflow_dispatch` and an own workflow. -- This is an automated

[PR] fix: test-scenarios-locally.sh [myfaces-tobago]

2023-11-28 Thread via GitHub
henningn opened a new pull request, #4559: URL: https://github.com/apache/myfaces-tobago/pull/4559 * don't overwrite JAVA_HOME variables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] fix: test-scenarios-locally.sh [myfaces-tobago]

2023-11-28 Thread via GitHub
henningn merged PR #4559: URL: https://github.com/apache/myfaces-tobago/pull/4559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

[VOTE] Release Tobago 6.1.0 and Tobago 5.9.0

2023-11-28 Thread Henning Nöth
Hello, we would like to release: * Tobago 6.1.0 * Tobago 5.9.0 The artifacts were deployed on nexus repository for binary and source packages: * Tobago 6.1.0 [1] * Tobago 5.9.0 [1] The release notes are in Jira: * Tobago 6.1.0 [2] * Tobago 5.9.0 [3] The artifacts are available at the staging

[PR] build(deps): bump logback.version from 1.4.12 to 1.4.13 [myfaces-tobago]

2023-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #4560: URL: https://github.com/apache/myfaces-tobago/pull/4560 Bumps `logback.version` from 1.4.12 to 1.4.13. Updates `ch.qos.logback:logback-classic` from 1.4.12 to 1.4.13 Commits https://github.com/qos-ch/logback/commit/7ee000a0a35

[jira] [Commented] (MYFACES-4641) MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" imports

2023-11-28 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790731#comment-17790731 ] Melloware commented on MYFACES-4641: [~volosied] i think we should close this ticke

Re: [PR] Enable extensionless requests for programmatic views [myfaces]

2023-11-28 Thread via GitHub
volosied commented on PR #648: URL: https://github.com/apache/myfaces/pull/648#issuecomment-1830745578 I'll see if I can add a test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Myfaces 4644 [4.1.x] [myfaces]

2023-11-28 Thread via GitHub
volosied opened a new pull request, #649: URL: https://github.com/apache/myfaces/pull/649 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Commented] (MYFACES-4644) Automatic extensionless mapping does not work on Java Facelet

2023-11-28 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790755#comment-17790755 ] Volodymyr Siedlecki commented on MYFACES-4644: -- 4.1: [https://github.com/a

[PR] Myfaces 4644 5.0 [myfaces]

2023-11-28 Thread via GitHub
volosied opened a new pull request, #650: URL: https://github.com/apache/myfaces/pull/650 Not building locally, so I'll create a PR here to verify after all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (MYFACES-4641) MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" imports

2023-11-28 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790759#comment-17790759 ] Volodymyr Siedlecki commented on MYFACES-4641: -- I still would like to crea

[jira] [Commented] (MYFACES-4641) MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" imports

2023-11-28 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790761#comment-17790761 ] Volodymyr Siedlecki commented on MYFACES-4641: -- That said, I don't know wh

[jira] [Comment Edited] (MYFACES-4644) Automatic extensionless mapping does not work on Java Facelet

2023-11-28 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790755#comment-17790755 ] Volodymyr Siedlecki edited comment on MYFACES-4644 at 11/28/23 9:33 PM: -

Re: [PR] Myfaces 4644 5.0 [myfaces]

2023-11-28 Thread via GitHub
volosied commented on PR #650: URL: https://github.com/apache/myfaces/pull/650#issuecomment-1831169515 I had been testing on 4.0 without the NonBinding attribute, but, then when I added it for 4.1 / 5.0, the tests start failing due to the NPE. @tandraschko Any idea here? -- This

Re: [PR] Myfaces 4644 5.0 [myfaces]

2023-11-28 Thread via GitHub
volosied commented on PR #650: URL: https://github.com/apache/myfaces/pull/650#issuecomment-1831172683 Oh, I see. It's all resolving to `ProgrammaticViewBean$$OwbNormalScopeProxy` in the tests https://github.com/apache/myfaces/assets/5934310/05a1a9ab-daa0-4878-b91e-e944dee40424";>