PRs and reviews

2015-11-04 Thread Jim Klucar
I'd like to discuss how we do PRs and code reviews. Right now we are using github most likely because that's how we did it before Apache. Now the code lives in the Apache hosted repo and we have Review Board available to us. My assumption is that we are individually more familiar with one way or th

Re: PRs and reviews

2015-11-04 Thread Adam Bordelon
FYI, I asked the infrastructure-dev mailing list about merging github PRs, and these are the answers I got: http://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/201510.mbox/%3CCANyrgveNjTDWOXj6fM4v2hRhJXwB%3DS2ko8rZ_2if6AY2c-Knyw%40mail.gmail.com%3E and http://mail-archives.apache.org/mo

Re: PRs and reviews

2015-11-04 Thread Danese Cooper
+100 It would be great to see Myriad immersing itself a bit more in the Apache Way, and using their tools can only help. Also agree it should be a time-bounded evaluation period. D > On Nov 4, 2015, at 4:18 PM, Jim Klucar wrote: > > I'd like to discuss how we do PRs and code reviews. Right n