2016-07-26 11:29 GMT-07:00 Thadeu Lima de Souza Cascardo <
casca...@redhat.com>:
> On Tue, Jul 26, 2016 at 11:20:38AM -0700, Daniele Di Proietto wrote:
> > Hi Cascardo,
> >
> > thanks for your input on this. It's quite messy right now, but I believe
> > we have a chance
> > to fix this up.
> >
>
On Tue, Jul 26, 2016 at 11:20:38AM -0700, Daniele Di Proietto wrote:
> Hi Cascardo,
>
> thanks for your input on this. It's quite messy right now, but I believe
> we have a chance
> to fix this up.
>
> Replies inline
>
> 2016-07-26 7:33 GMT-07:00 Thadeu Lima de Souza Cascardo
Hi Cascardo,
thanks for your input on this. It's quite messy right now, but I believe
we have a chance
to fix this up.
Replies inline
2016-07-26 7:33 GMT-07:00 Thadeu Lima de Souza Cascardo :
> On Mon, Jul 25, 2016 at 11:03:29AM -0700, Daniele Di Proietto wrote:
> >
On Mon, Jul 25, 2016 at 11:03:29AM -0700, Daniele Di Proietto wrote:
> 2016-07-25 9:57 GMT-07:00 Thadeu Lima de Souza Cascardo >:
>
> > On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote:
> > > I would prefer if dpctl kept using the datapath types. The
2016-07-25 9:57 GMT-07:00 Thadeu Lima de Souza Cascardo :
> On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote:
> > I would prefer if dpctl kept using the datapath types. The translation
> > from database types to datapath type should happen in ofproto,
On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote:
> I would prefer if dpctl kept using the datapath types. The translation
> from database types to datapath type should happen in ofproto, dpctl is
> supposed to be used to interact with the datapath directly.
>
> What do you
I would prefer if dpctl kept using the datapath types. The translation
from database types to datapath type should happen in ofproto, dpctl is
supposed to be used to interact with the datapath directly.
What do you guys think?
The rest of the series looks good to me as well.
Thanks,
Daniele
dpctl uses a user or database defined type when calling netdev_open. Instead, it
should use the type from dpif_port_open_type. Otherwise, when using the internal
type, it could open it with that type instead of the correct one, which would be
tap or dummy.
---
lib/dpctl.c | 17 -