Re: [E] Re: Performance of hive 1.2 with ORC-1.5.x

2021-08-25 Thread Purshotam Shah
Hi Dongjoon, Thanks for your reply. Yes, we are planning to build hive-1.2 with Apache ORC 1.5.12. We realized that it's a lot of work as we have to merge multiple patches. Hive-1.2 has been very stable for us. We are wondering if it's worth building hive-1.2 with Apache ORC 1.5.12. We can't migr

[GitHub] [orc] dongjoon-hyun merged pull request #883: ORC-971: [C++] Fix LESS_THAN_EQUALS doesn't handle the case when minValue equals to maxValue

2021-08-25 Thread GitBox
dongjoon-hyun merged pull request #883: URL: https://github.com/apache/orc/pull/883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [orc] guiyanakuang commented on pull request #882: ORC-970: Reordering statements, improve readability in WriterImpl

2021-08-25 Thread GitBox
guiyanakuang commented on pull request #882: URL: https://github.com/apache/orc/pull/882#issuecomment-906072578 😄 Thanks @dongjoon-hyun for review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Created] (ORC-972) [C++] Evaluate SearchArguments using dictionaries

2021-08-25 Thread Quanlong Huang (Jira)
Quanlong Huang created ORC-972: -- Summary: [C++] Evaluate SearchArguments using dictionaries Key: ORC-972 URL: https://issues.apache.org/jira/browse/ORC-972 Project: ORC Issue Type: Improvement

[GitHub] [orc] stiga-huang opened a new pull request #883: ORC-971: [C++] Fix LESS_THAN_EQUALS doesn't handle the case when minValue equals to maxValue

2021-08-25 Thread GitBox
stiga-huang opened a new pull request #883: URL: https://github.com/apache/orc/pull/883 ### What changes were proposed in this pull request? When evaluating the LESS_THAN_EQUALS predicates, the case that has identical minValue and maxValue is not handled correctly. E.g. predi

[jira] [Created] (ORC-971) LESS_THAN_EQUALS doesn't handle the case when min=max

2021-08-25 Thread Quanlong Huang (Jira)
Quanlong Huang created ORC-971: -- Summary: LESS_THAN_EQUALS doesn't handle the case when min=max Key: ORC-971 URL: https://issues.apache.org/jira/browse/ORC-971 Project: ORC Issue Type: Bug

Re: Performance of hive 1.2 with ORC-1.5.x

2021-08-25 Thread Dongjoon Hyun
What is the baseline for your comparison? FYI, the community status is like the following. - Apache Hive 1.2.2 is not using Apache ORC. - Apache Hive 2.3.9 is using Apache ORC 1.3.4. - Apache Hive 3.1.2 is using Apache ORC 1.5.6. - Apache Hive 4.0.0-SNAPSHOT is using Apache ORC 1.6.9. So, specif

[GitHub] [orc] dongjoon-hyun merged pull request #882: ORC-970: Reordering statements, improve readability

2021-08-25 Thread GitBox
dongjoon-hyun merged pull request #882: URL: https://github.com/apache/orc/pull/882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #882: ORC-970: Reordering statements, improve readability

2021-08-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #882: URL: https://github.com/apache/orc/pull/882#discussion_r695926553 ## File path: java/core/src/java/org/apache/orc/impl/WriterImpl.java ## @@ -163,64 +162,69 @@ public WriterImpl(FileSystem fs, opts.getKeyOverrid

[jira] [Created] (ORC-970) Reordering statements, improve readability

2021-08-25 Thread Yiqun Zhang (Jira)
Yiqun Zhang created ORC-970: --- Summary: Reordering statements, improve readability Key: ORC-970 URL: https://issues.apache.org/jira/browse/ORC-970 Project: ORC Issue Type: Improvement Comp

[GitHub] [orc] guiyanakuang opened a new pull request #882: Reordering statements, improve readability

2021-08-25 Thread GitBox
guiyanakuang opened a new pull request #882: URL: https://github.com/apache/orc/pull/882 ### What changes were proposed in this pull request? Reordered multiple statements. Make variable initialization and usage closer. For example, before ``` 193 buildIndex = rowI

[jira] [Created] (ORC-969) Evaluate SearchArguments using file and stripe level stats

2021-08-25 Thread Quanlong Huang (Jira)
Quanlong Huang created ORC-969: -- Summary: Evaluate SearchArguments using file and stripe level stats Key: ORC-969 URL: https://issues.apache.org/jira/browse/ORC-969 Project: ORC Issue Type: Impr