[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/142 Merged, see JIRA --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail:

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/142 The commit makes things better than they were but is not the final fix, as per comments from you and Gordon. Closing the PR as the JIRA has the comments - I think they are valid, just

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/142 It seems you already committed this before Gordon and I commented, but neglected to close the PR with the commit or otherwise. It either needs closing, or the commit reverted, depending what

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/142 > Thanks - I didn't know about stolen. I think we could implement what the spec says on the server side - close the old link/handle with "stolen" and create a new link under the new handle.

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/142 On Fri, Apr 27, 2018 at 4:57 AM, Robbie Gemmell wrote: > The use of "invalid-field" for the error feels like it is maybe a little > off. Its

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/142 The use of "invalid-field" for the error feels like it is maybe a little off. Its possible/likely there is nothing wrong with the information in the fields of the attach, as none of it is

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

Github user codecov-io commented on the issue: https://github.com/apache/qpid-proton/pull/142 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/142?src=pr=h1) Report > Merging [#142](https://codecov.io/gh/apache/qpid-proton/pull/142?src=pr=desc) into