[GitHub] [incubator-sedona] kanchanchy commented on pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-22 Thread GitBox
kanchanchy commented on PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#issuecomment-1106856139 @jiayuasu The pull request is updated with the above discussed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-sedona] naharon2210 commented on pull request #620: Added ST_YMax and ST_YMin functions

2022-04-22 Thread GitBox
naharon2210 commented on PR #620: URL: https://github.com/apache/incubator-sedona/pull/620#issuecomment-1106801047 > @naharon2210 Please read the contributor guide and test your individual test case locally: https://sedona.apache.org/community/develop/#run-unit-tests > > GitHub Action

[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function

2022-04-22 Thread GitBox
Arindam-Jain commented on PR #619: URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1106799559 @jiayuasu I have changed GeomUtils to geometry.isEmpty() function. Could you please let me know what else is inconsistent? -- This is an automated message from the Apache Gi

[GitHub] [incubator-sedona] jiayuasu commented on pull request #620: Added ST_YMax and ST_YMin functions

2022-04-22 Thread GitBox
jiayuasu commented on PR #620: URL: https://github.com/apache/incubator-sedona/pull/620#issuecomment-1106790069 @naharon2210 Please read the contributor guide and test your individual test case locally: https://sedona.apache.org/community/develop/#run-unit-tests GitHub Action take lot

[GitHub] [incubator-sedona] naharon2210 opened a new pull request, #620: Added ST_YMax and ST_YMin functions

2022-04-22 Thread GitBox
naharon2210 opened a new pull request, #620: URL: https://github.com/apache/incubator-sedona/pull/620 ## Is this PR related to a JIRA ticket? - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-116. The PR name follows the form

[GitHub] [incubator-sedona] naharon2210 closed pull request #616: Added ST_YMax and ST_YMin

2022-04-22 Thread GitBox
naharon2210 closed pull request #616: Added ST_YMax and ST_YMin URL: https://github.com/apache/incubator-sedona/pull/616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-22 Thread GitBox
jiayuasu commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855953818 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq[E

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-22 Thread GitBox
kanchanchy commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855930007 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq

[GitHub] [incubator-sedona] Arindam-Jain opened a new pull request, #619: Added ST_IsEmpty

2022-04-22 Thread GitBox
Arindam-Jain opened a new pull request, #619: URL: https://github.com/apache/incubator-sedona/pull/619 ## Is this PR related to a proposed Issue? SEDONA-98 ## What changes were proposed in this PR? Added ST_IsEmpty function to SQL and flink ## How was this patch tested? Added

[GitHub] [incubator-sedona] kvpankaj1999 commented on pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-22 Thread GitBox
kvpankaj1999 commented on PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#issuecomment-1106140771 Updated the Code review changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-sedona] kvpankaj1999 commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-22 Thread GitBox
kvpankaj1999 commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855884404 ## flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java: ## @@ -110,4 +111,36 @@ public String eval(@DataTypeHint(value = "RAW", bridgedTo

[GitHub] [incubator-sedona] kvpankaj1999 commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-22 Thread GitBox
kvpankaj1999 commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855884229 ## docs/api/sql/Function.md: ## @@ -1105,4 +1105,42 @@ Result: +---+ |LINESTRING (3 6, 2 4, 1 2

[GitHub] [incubator-sedona] kvpankaj1999 commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-22 Thread GitBox
kvpankaj1999 commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855883974 ## flink/src/test/java/org/apache/sedona/flink/FunctionTest.java: ## @@ -88,4 +88,22 @@ public void testAsEWKT() { String result = (String) first(po

[GitHub] [incubator-sedona] kvpankaj1999 commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-22 Thread GitBox
kvpankaj1999 commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855883699 ## sql/src/test/scala/org/apache/sedona/sql/functionTestScala.scala: ## @@ -335,6 +335,18 @@ class functionTestScala extends TestBaseScala with Matchers wit

[GitHub] [incubator-sedona] kvpankaj1999 commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-22 Thread GitBox
kvpankaj1999 commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855882778 ## sql/src/test/scala/org/apache/sedona/sql/functionTestScala.scala: ## @@ -335,6 +335,18 @@ class functionTestScala extends TestBaseScala with Matchers wit

[GitHub] [incubator-sedona] tmodi7 opened a new pull request, #618: [SEDONA-97] Add ST_Force_2D function to Apache Sedona

2022-04-22 Thread GitBox
tmodi7 opened a new pull request, #618: URL: https://github.com/apache/incubator-sedona/pull/618 ## Is this PR related to a proposed Issue? ## What changes were proposed in this PR? ## How was this patch tested? ## Did this PR include necessary documentation updates?

[GitHub] [incubator-sedona] naharon2210 commented on pull request #616: Added ST_YMax and ST_YMin

2022-04-22 Thread GitBox
naharon2210 commented on PR #616: URL: https://github.com/apache/incubator-sedona/pull/616#issuecomment-1106118100 @jiayuasu I am not sure why some tests are failing? How can I resolve these? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-sedona] tmodi7 closed pull request #617: [SEDONA-97] Add ST_Force_2D function to Apache Sedona

2022-04-22 Thread GitBox
tmodi7 closed pull request #617: [SEDONA-97] Add ST_Force_2D function to Apache Sedona URL: https://github.com/apache/incubator-sedona/pull/617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-22 Thread GitBox
kanchanchy commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855828560 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-22 Thread GitBox
jiayuasu commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855826685 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq[E

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855820003 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
jiayuasu commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855815163 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq[E

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-21 Thread GitBox
jiayuasu commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855807148 ## flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java: ## @@ -110,4 +111,36 @@ public String eval(@DataTypeHint(value = "RAW", bridgedTo = o

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855804030 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-21 Thread GitBox
jiayuasu commented on code in PR #615: URL: https://github.com/apache/incubator-sedona/pull/615#discussion_r855803468 ## sql/src/test/scala/org/apache/sedona/sql/functionTestScala.scala: ## @@ -335,6 +335,18 @@ class functionTestScala extends TestBaseScala with Matchers with Ge

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855804595 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855804030 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
jiayuasu commented on code in PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#discussion_r855801004 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/Functions.scala: ## @@ -771,3 +771,45 @@ case class RS_Normalize(inputExpressions: Seq[E

[GitHub] [incubator-sedona] tmodi7 opened a new pull request, #617: [SEDONA-97] Add ST_Force_2D function to Apache Sedona

2022-04-21 Thread GitBox
tmodi7 opened a new pull request, #617: URL: https://github.com/apache/incubator-sedona/pull/617 ## Is this PR related to a proposed Issue? ## What changes were proposed in this PR? ## How was this patch tested? ## Did this PR include necessary documentation updates?

[GitHub] [incubator-sedona] naharon2210 opened a new pull request, #616: Added ST_YMax and ST_YMin

2022-04-21 Thread GitBox
naharon2210 opened a new pull request, #616: URL: https://github.com/apache/incubator-sedona/pull/616 ## Is this PR related to a proposed Issue? Yes [SEDONA-116] ## What changes were proposed in this PR? Added ST_YMax and ST_YMin functions ## How was this patch tested? Added un

[GitHub] [incubator-sedona] kvpankaj1999 opened a new pull request, #615: [SEDONA 115] Add ST_XMax and ST_XMin functions

2022-04-21 Thread GitBox
kvpankaj1999 opened a new pull request, #615: URL: https://github.com/apache/incubator-sedona/pull/615 ## Is this PR related to a proposed Issue? Yes - SEDONA-115 ## What changes were proposed in this PR? Added ST_XMax and ST_XMin functions ## How was this patch tested?

[GitHub] [incubator-sedona] kanchanchy commented on pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#issuecomment-1105862971 Same image will not be distributed into multiple sub-folders. If there are 3 images in total, there might be 3 subfolders with each subfolder having 1 image. -- This is an aut

[GitHub] [incubator-sedona] kanchanchy commented on pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#issuecomment-1105861544 In the unit tests, I have shown it both with and without coalesce(1). I also showed both versions in the documentation. -- This is an automated message from the Apache Git Ser

[GitHub] [incubator-sedona] kanchanchy commented on pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy commented on PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#issuecomment-1105859935 @jiayuasu No, coalesce(1) is not mandatory. If it is not provided, writing will be distributed and images will be written in different subfolders in the given destination path.

[GitHub] [incubator-sedona] jiayuasu commented on pull request #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
jiayuasu commented on PR #614: URL: https://github.com/apache/incubator-sedona/pull/614#issuecomment-1105858533 @kanchanchy A quick question: Is df.coalesce(1) required in order to write GeoTiffs? If we don't use coalesce(1), what will happen? and what is the disk layout of this GeoT

[GitHub] [incubator-sedona] kanchanchy opened a new pull request, #614: [SEDONA-117] RS_AppendNormalizedDifference Implemented and Raster Notebook Updated

2022-04-21 Thread GitBox
kanchanchy opened a new pull request, #614: URL: https://github.com/apache/incubator-sedona/pull/614 ## Is this PR related to a proposed Issue? Yes. [SEDONA-117](https://issues.apache.org/jira/browse/SEDONA-117) ## What changes were proposed in this PR? 1. Implements a new SQL ex

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #609: Feature/dbscan

2022-04-21 Thread GitBox
jiayuasu commented on code in PR #609: URL: https://github.com/apache/incubator-sedona/pull/609#discussion_r855462337 ## core/src/main/java/org/apache/sedona/core/spatialOperator/DBScanQuery.java: ## @@ -0,0 +1,31 @@ +package org.apache.sedona.core.spatialOperator; + +import org

[GitHub] [incubator-sedona] jiayuasu merged pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu merged PR #612: URL: https://github.com/apache/incubator-sedona/pull/612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona

[GitHub] [incubator-sedona] jiayuasu commented on pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu commented on PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#issuecomment-1104698442 @kanchanchy I am gonna merge this PR. Can you also update the notebook example here in another PR? https://github.com/apache/incubator-sedona/blob/master/binder/ApacheSedonaRaster

[GitHub] [incubator-sedona] jiayuasu commented on pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu commented on PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#issuecomment-1104697426 @Imbruced Hi Pawel, your Python test case of "Geom Constructor on Stream" frequently fails because you use a random name to the temp view name. The name was actually not very rand

[GitHub] [incubator-sedona] jiayuasu merged pull request #608: [SEDONA-106] add st line from text

2022-04-20 Thread GitBox
jiayuasu merged PR #608: URL: https://github.com/apache/incubator-sedona/pull/608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854667135 ## docs/api/sql/Raster-loader.md: ## @@ -142,3 +170,82 @@ Output: ++ ``` +### Geotiff Dataframe Writer + +Introduction: You can write a G

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854666282 ## docs/api/sql/Raster-loader.md: ## @@ -142,3 +170,82 @@ Output: ++ ``` +### Geotiff Dataframe Writer + +Introduction: You can write a

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854661548 ## docs/api/sql/Raster-loader.md: ## @@ -142,3 +170,82 @@ Output: ++ ``` +### Geotiff Dataframe Writer + +Introduction: You can write a G

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854656997 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] jiayuasu merged pull request #613: [SEDONA-112] Add ST_AsEWKT

2022-04-20 Thread GitBox
jiayuasu merged PR #613: URL: https://github.com/apache/incubator-sedona/pull/613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona

[GitHub] [incubator-sedona] pavan02 commented on a diff in pull request #613: [SEDONA-112] Add ST_AsEWKT

2022-04-20 Thread GitBox
pavan02 commented on code in PR #613: URL: https://github.com/apache/incubator-sedona/pull/613#discussion_r854578049 ## flink/src/test/java/org/apache/sedona/flink/FunctionTest.java: ## @@ -73,10 +73,23 @@ public void testPointOnSurface() { assertEquals("POINT (32 -118)

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854570441 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileFor

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854569930 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854568015 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854566911 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#issuecomment-1104469148 @jiayuasu org.apache.spark.sql.catalyst.expressions.UnsafeArrayData cannot be cast to org.locationtech.jts.geom.Geometry -- This is an automated message from the Apache Git S

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r854564682 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileFor

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-20 Thread GitBox
jiayuasu commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r854446352 ## docs/api/sql/Constructor.md: ## @@ -172,6 +172,24 @@ FROM linestringtable SELECT ST_LineStringFromText('-74.0428197,40.6867969,-74.0421975,40.6921336,-74.05

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-20 Thread GitBox
jiayuasu commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r854438357 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Constructors.scala: ## @@ -94,6 +94,40 @@ case class ST_PolygonFromText(inputExpressions: Seq[

[GitHub] [incubator-sedona] kanchanchy commented on pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-20 Thread GitBox
kanchanchy commented on PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#issuecomment-1104274929 @jiayuasu I finished implementing exactly what you proposed. However, I need to fix one more issue. If the geometry column is not passed to ST_Geom_From_WKT or ST_Transfor

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #613: [SEDONA-112] Add ST_AsEWKT

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #613: URL: https://github.com/apache/incubator-sedona/pull/613#discussion_r853673976 ## docs/api/sql/Function.md: ## @@ -302,6 +302,24 @@ SELECT ST_AsEWKB(polygondf.countyshape) FROM polygondf ``` +## ST_AsEWKT + +Introduction: Return the Ext

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #613: [SEDONA-112] Add ST_AsEWKT

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #613: URL: https://github.com/apache/incubator-sedona/pull/613#discussion_r853673450 ## docs/api/flink/Function.md: ## @@ -150,4 +150,22 @@ FROM df Input: `POLYGON ((-0.5 -0.5, -0.5 0.5, 0.5 0.5, 0.5 -0.5, -0.5 -0.5))` -Output: `POLYGON ((-0

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #613: [SEDONA-112] Add ST_AsEWKT

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #613: URL: https://github.com/apache/incubator-sedona/pull/613#discussion_r853673257 ## flink/src/test/java/org/apache/sedona/flink/FunctionTest.java: ## @@ -73,10 +73,23 @@ public void testPointOnSurface() { assertEquals("POINT (32 -118

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853657807 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileFor

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853639126 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853638415 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853636330 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853636330 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853631322 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileFor

[GitHub] [incubator-sedona] pavan02 commented on pull request #613: [SEDONA-112] Add ST_AsEWKT

2022-04-19 Thread GitBox
pavan02 commented on PR #613: URL: https://github.com/apache/incubator-sedona/pull/613#issuecomment-1103257202 @jiayuasu Could you please re-run python build? It ran fine in my local. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-19 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r853574134 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Constructors.scala: ## @@ -94,6 +94,36 @@ case class ST_PolygonFromText(inputExpressions: Seq[Ex

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853439658 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] kanchanchy commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
kanchanchy commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853439658 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileF

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853401485 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileFor

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-19 Thread GitBox
jiayuasu commented on code in PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#discussion_r853400083 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/GeotiffFileFormat.scala: ## @@ -101,4 +126,123 @@ private[spark] class GeotiffFileFormat extends FileFor

[GitHub] [incubator-sedona] pavan02 opened a new pull request, #613: Add ST_AsEWKT

2022-04-19 Thread GitBox
pavan02 opened a new pull request, #613: URL: https://github.com/apache/incubator-sedona/pull/613 ## Is this PR related to a proposed Issue? [SEDONA-112](https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-112) ## What changes were proposed in this PR? ST_AsEWKT Functio

[GitHub] [incubator-sedona] kanchanchy commented on pull request #612: [SEDONA-108] Write Support for GeoTiff Raster Images

2022-04-18 Thread GitBox
kanchanchy commented on PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#issuecomment-1102064753 Hi @jiayuasu I didn't understand the writeToCRS option. If end user provides writeToCRS option during, the coordinates of the GeoTiff source should be in that CRS format, right?

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-18 Thread GitBox
jiayuasu commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r852591258 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Constructors.scala: ## @@ -94,6 +94,36 @@ case class ST_PolygonFromText(inputExpressions: Seq[

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-18 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r852579065 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Constructors.scala: ## @@ -94,6 +94,36 @@ case class ST_PolygonFromText(inputExpressions: Seq[Ex

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-18 Thread GitBox
jiayuasu commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r852520310 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Constructors.scala: ## @@ -94,6 +94,36 @@ case class ST_PolygonFromText(inputExpressions: Seq[

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-18 Thread GitBox
jiayuasu commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r852519668 ## docs/archive/api/sql/GeoSparkSQL-Constructor.md: ## @@ -19,6 +19,19 @@ FROM polygontable SELECT ST_GeomFromWKT('POINT(40.7128,-74.0060)') AS geometry ```

[GitHub] [incubator-sedona] jiayuasu commented on pull request #612: Implemented Jira Issue SEDONA-108 (Write Support for GeoTiff Raster Images)

2022-04-18 Thread GitBox
jiayuasu commented on PR #612: URL: https://github.com/apache/incubator-sedona/pull/612#issuecomment-1101898005 @kanchanchy This PR looks awesome. I have a small request regarding the CRS in GeoTIFF reader and writer. Currently, it is fixed to (1) in the reader, read from the original data

[GitHub] [incubator-sedona] jiayuasu merged pull request #610: [SEDONA 95] Add ST_Disjoint predicate

2022-04-18 Thread GitBox
jiayuasu merged PR #610: URL: https://github.com/apache/incubator-sedona/pull/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #610: [SEDONA 95] Add ST_Disjoint predicate

2022-04-18 Thread GitBox
jiayuasu commented on code in PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#discussion_r852511063 ## flink/src/main/java/org/apache/sedona/flink/expressions/Predicates.java: ## @@ -104,4 +104,28 @@ public Boolean eval(@DataTypeHint("INT") Integer key, @DataT

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-18 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851817138 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Constructors.scala: ## @@ -94,6 +94,37 @@ case class ST_PolygonFromText(inputExpressions: Seq[Ex

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-18 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851817126 ## docs/archive/api/sql/GeoSparkSQL-Constructor.md: ## @@ -155,6 +155,24 @@ FROM polygontable SELECT ST_PolygonFromText('-74.0428197,40.6867969,-74.0421975,40.69

[GitHub] [incubator-sedona] kanchanchy opened a new pull request, #612: Implemented Jira Issue SEDONA-108 (Write Support for GeoTiff Raster Images)

2022-04-18 Thread GitBox
kanchanchy opened a new pull request, #612: URL: https://github.com/apache/incubator-sedona/pull/612 ## Is this PR related to a proposed Issue? Yes. [SEDONA-108](https://issues.apache.org/jira/browse/SEDONA-108) ## What changes were proposed in this PR? GeoTiff DataFrame can be w

[GitHub] [incubator-sedona] kanchanchy closed pull request #611: Jira Issue SEDONA-108 (Writing GeoTiff) Implemented

2022-04-18 Thread GitBox
kanchanchy closed pull request #611: Jira Issue SEDONA-108 (Writing GeoTiff) Implemented URL: https://github.com/apache/incubator-sedona/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-sedona] kanchanchy opened a new pull request, #611: Jira Issue SEDONA-108 (Writing GeoTiff) Implemented

2022-04-17 Thread GitBox
kanchanchy opened a new pull request, #611: URL: https://github.com/apache/incubator-sedona/pull/611 ## Is this PR related to a proposed Issue? Yes, [SEDONA-108](https://issues.apache.org/jira/browse/SEDONA-108) ## What changes were proposed in this PR? Added write support for Ge

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-17 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851817148 ## sql/src/test/scala/org/apache/sedona/sql/predicateTestScala.scala: ## @@ -140,6 +140,37 @@ class predicateTestScala extends TestBaseScala { assert(equald

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-17 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851817126 ## docs/archive/api/sql/GeoSparkSQL-Constructor.md: ## @@ -155,6 +155,24 @@ FROM polygontable SELECT ST_PolygonFromText('-74.0428197,40.6867969,-74.0421975,40.69

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-17 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851817126 ## docs/archive/api/sql/GeoSparkSQL-Constructor.md: ## @@ -155,6 +155,24 @@ FROM polygontable SELECT ST_PolygonFromText('-74.0428197,40.6867969,-74.0421975,40.69

[GitHub] [incubator-sedona] ngaur9 commented on a diff in pull request #608: [SEDONA-106] add st line from text

2022-04-17 Thread GitBox
ngaur9 commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851817082 ## docs/api/sql/Constructor.md: ## @@ -172,6 +172,24 @@ FROM linestringtable SELECT ST_LineStringFromText('-74.0428197,40.6867969,-74.0421975,40.6921336,-74.0508

[GitHub] [incubator-sedona] onkarpandit commented on a diff in pull request #610: [SEDONA 95] Add ST_Disjoint predicate

2022-04-17 Thread GitBox
onkarpandit commented on code in PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#discussion_r851776284 ## flink/src/main/java/org/apache/sedona/flink/expressions/Predicates.java: ## @@ -104,4 +104,28 @@ public Boolean eval(@DataTypeHint("INT") Integer key, @Da

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #610: [SEDONA 95] Add ST_Disjoint predicate

2022-04-17 Thread GitBox
jiayuasu commented on code in PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#discussion_r851720081 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala: ## @@ -69,6 +69,8 @@ class JoinQueryDetector(sparkSession: SparkSess

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #608: Sedona 106 add st line from text

2022-04-17 Thread GitBox
jiayuasu commented on code in PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#discussion_r851718619 ## docs/api/sql/Constructor.md: ## @@ -172,6 +172,24 @@ FROM linestringtable SELECT ST_LineStringFromText('-74.0428197,40.6867969,-74.0421975,40.6921336,-74.05

[GitHub] [incubator-sedona] onkarpandit commented on pull request #610: [SEDONA 95] Add ST_Disjoint predicate

2022-04-17 Thread GitBox
onkarpandit commented on PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#issuecomment-1100826512 @jiayuasu Sorry I missed some comments. I have resolved them now. Please let me know if anything else is required. -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-sedona] jiayuasu commented on pull request #610: [SEDONA 95] Add ST_Disjoint predicate

2022-04-17 Thread GitBox
jiayuasu commented on PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#issuecomment-1100825593 @onkarpandit Please fix other issues mentioned by me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-sedona] jiayuasu commented on pull request #610: Add ST_Disjoint predicate

2022-04-16 Thread GitBox
jiayuasu commented on PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#issuecomment-1100802920 > @jiayuasu I have made the changes for flink Even when I remove all my code and run mvn clean install I am getting the following error Failed tests: ShapefileReaderTest.testLoadD

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #610: Add ST_Disjoint predicate

2022-04-16 Thread GitBox
jiayuasu commented on code in PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#discussion_r851702022 ## flink/src/main/java/org/apache/sedona/flink/expressions/Predicates.java: ## @@ -104,4 +104,44 @@ public Boolean eval(@DataTypeHint("INT") Integer key, @DataT

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #610: Add ST_Disjoint predicate

2022-04-16 Thread GitBox
jiayuasu commented on code in PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#discussion_r851701999 ## docs/archive/api/sql/GeoSparkSQL-Predicate.md: ## @@ -100,4 +100,19 @@ Spark SQL example: SELECT * FROM geom WHERE ST_Overlaps(geom.geom_a, geom.geom_b) +`

[GitHub] [incubator-sedona] ngaur9 commented on pull request #608: Sedona 106 add st line from text

2022-04-16 Thread GitBox
ngaur9 commented on PR #608: URL: https://github.com/apache/incubator-sedona/pull/608#issuecomment-1100753889 I have incorporated the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-sedona] onkarpandit commented on pull request #610: Add ST_Disjoint predicate

2022-04-16 Thread GitBox
onkarpandit commented on PR #610: URL: https://github.com/apache/incubator-sedona/pull/610#issuecomment-1100743253 @jiayuasu I have made the changes for flink Even when I remove all my code and run mvn clean install I am getting the following error Failed tests: ShapefileReaderTe

[GitHub] [incubator-sedona] jiayuasu commented on pull request #609: Feature/dbscan

2022-04-16 Thread GitBox
jiayuasu commented on PR #609: URL: https://github.com/apache/incubator-sedona/pull/609#issuecomment-1100739916 Thanks for your contribution. This PR is huge. I will take some to review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

<    2   3   4   5   6   7   8   9   10   11   >