Re: Review Request 48312: SENTRY-848:[column level privilege] if grant user column level select privilege, DESCRIBE FORMATTED table[.column] shouldn't require extra table level privilege

2016-06-06 Thread Ke Jia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48312/ --- (Updated June 7, 2016, 5:58 a.m.) Review request for sentry, Anne Yu, Colin Ma,

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

2016-06-06 Thread Colin Ma
> On June 6, 2016, 4:52 p.m., Sravya Tirukkovalur wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java, > > line 108 > > > > > > Should this be

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

2016-06-06 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48055/ --- (Updated June 7, 2016, 5:44 a.m.) Review request for sentry and Sravya Tirukkov

Review Request 48316: SENTRY-320:show role grant group groupname should not throw an exception if group doesnt exist in db

2016-06-06 Thread Ke Jia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48316/ --- Review request for sentry, Colin Ma and Dapeng Sun. Bugs: SENTRY-320 https:

Review Request 48312: SENTRY-848:[column level privilege] if grant user column level select privilege, DESCRIBE FORMATTED table[.column] shouldn't require extra table level privilege

2016-06-06 Thread Ke Jia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48312/ --- Review request for sentry, Anne Yu, Colin Ma, and Dapeng Sun. Bugs: SENTRY-848

Review Request 48307: SENTRY-1094:SentryMetastorePostEventListener.onAlterTable should check for null dereference

2016-06-06 Thread Ke Jia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48307/ --- Review request for sentry, Colin Ma and Dapeng Sun. Bugs: SENTRY-1094 https

Re: Review Request 48195: SENTRY-858: Database prefix is not honoured when executing grant statement

2016-06-06 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48195/#review136303 --- Ship it! Ship It! - Sravya Tirukkovalur On June 3, 2016, 1:2

Re: Review Request 48195: SENTRY-858: Database prefix is not honoured when executing grant statement

2016-06-06 Thread Sravya Tirukkovalur
> On June 3, 2016, 11:14 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java, > > line 2183 > > > > > > As the problem

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

2016-06-06 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48055/#review136300 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 48195: SENTRY-858: Database prefix is not honoured when executing grant statement

2016-06-06 Thread Rahul Sharma
> On June 3, 2016, 11:14 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java, > > line 2183 > > > > > > As the problem

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

2016-06-06 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48055/ --- (Updated June 6, 2016, 1:44 p.m.) Review request for sentry and Sravya Tirukkov