Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-01 Thread Hao Hao
> On June 30, 2016, 11:56 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 61 > > > > > > Sh

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-01 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/ --- (Updated July 1, 2016, 11:43 p.m.) Review request for sentry, Anne Yu, Colin Mc

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-01 Thread Sravya Tirukkovalur
> On June 30, 2016, 11:56 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 61 > > > > > > Sh

Re: Review Request 49526: SENTRY-1365

2016-07-01 Thread Hao Hao
> On July 1, 2016, 6:57 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql, > > line 1 > > > > > > Need to add this file into > > "https://github.com/apache/sentry

Re: Review Request 49526: SENTRY-1365

2016-07-01 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review140397 --- Thanks Hao Hao. Left two comments here. sentry-provider/sentry-p

Review Request 49526: SENTRY-1365

2016-07-01 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/ --- Review request for sentry and Anne Yu. Repository: sentry Description ---

Review Request 49522: SENTRY-1378: MAde changes to a make allowed sentry users to be case sensitive.

2016-07-01 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49522/ --- Review request for sentry and Sravya Tirukkovalur. Repository: sentry Descrip

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

2016-07-01 Thread Anne Yu
> On July 1, 2016, 5:31 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java, > > line 633 > > > > > > Can you also try to add one test for Creat

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

2016-07-01 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49491/#review140387 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te