Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2636
@cfriaszapater
Ok, look forward to your master branch patch.
---
Github user cfriaszapater commented on the issue:
https://github.com/apache/storm/pull/2636
Hi danny0405,
In response to HeartSaVioR, I said:
> I'll try to do that pull request in the future to master branch.
> I did this to 1.1.x branch because we use it in our organiz
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2636
@cfriaszapater
You should first build and install your dependencies modules successfully.
---
Github user cfriaszapater commented on the issue:
https://github.com/apache/storm/pull/2636
Hi HeartSaVioR,
I saw your comment and understand the reason. Just that I haven't had time
to do it yet, as I had problems building the full storm project master branch
locally. I'll t
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2636
@cfriaszapater
Thanks for the contribution. Basically we receive PRs which go first to the
master branch, and additional PRs (against 1.x-branch) which is expected to not
cleanly ported back
Github user cfriaszapater commented on the issue:
https://github.com/apache/storm/pull/2636
Ah, that's strange, because I did not change anything out of
external/storm-cassandra. So that should be failing before this pull request.
Anyway, I'll try what you say, thanks.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2636
@cfriaszapater The failure is because the integration test POM is pointing
at Storm 1.2.0-SNAPSHOT, but this branch has Storm at version 1.1.3-SNAPSHOT.
You should be able to just replace the version st
Github user cfriaszapater commented on the issue:
https://github.com/apache/storm/pull/2636
Fixed requested issues.
I did not add a test case for this pull request because I could not find
any test cases in storm-cassandra in this branch. I tested the changes in
topologies no
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2636
The RAT plugin failure is because the SslProps file doesn't have the Apache
license at the top
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2636
@cfriaszapater
You can see the clojure test cases reports and logs in module targets dir,
also the check style plugin logs.
You can see the Java Junit logs in the console.
---
Github user cfriaszapater commented on the issue:
https://github.com/apache/storm/pull/2636
Could someone provide help with the failed checks? I don't know how to fix
them, eg:
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check
(default) on project storm: T
11 matches
Mail list logo