struts2 pull request: DeprecationInterceptor

2013-10-23 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts2/pull/10 DeprecationInterceptor You can merge this pull request into a Git repository by running: $ git pull https://github.com/strutsathon/struts2 trunk Alternatively you can review and apply

struts2 pull request: DeprecationInterceptor

2013-11-06 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts2/pull/10 - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If your project does not have this feature

[GitHub] struts pull request: Restricts direct access to JSP files

2014-03-03 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/2 Restricts direct access to JSP files This PR moves all JSP files in example apps under `WEB-INF` and adds security constraints to `web.xml` to avoid accessing JSP files directly. Thus

[GitHub] struts pull request: Restricts direct access to JSP files

2014-03-06 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts pull request: Extends UrlValidator to support custom regex

2014-03-09 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/3 Extends UrlValidator to support custom regex This PR is related to [WW-4198](https://issues.apache.org/jira/browse/WW-4198) You can merge this pull request into a Git repository by running

[GitHub] struts pull request: WW-4187 correctly identify protocols to recog...

2014-03-10 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/4 WW-4187 correctly identify protocols to recognise if URL is path This is related to [WW-4187](https://issues.apache.org/jira/browse/WW-4187) You can merge this pull request into a Git repository

[GitHub] struts pull request: Feature: use JavaScript to support multiple a...

2014-03-13 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/5 Feature: use JavaScript to support multiple actions instead action: prefix You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/struts

[GitHub] struts pull request: Extends UrlValidator to support custom regex

2014-03-13 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts pull request: WW-4187 correctly identify protocols to recog...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38027870 Have you tested that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] struts pull request: WW-4187 correctly identify protocols to recog...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/4#issuecomment-38027847 PR applied! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10740672 --- Diff: core/src/main/resources/template/simple/select.ftl --- @@ -69,7 +69,13 @@ <#assign itemKey = stack.findValue(&

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10740666 --- Diff: core/src/main/resources/template/simple/radiomap.ftl --- @@ -27,7 +27,13 @@ <#assign itemKey = stack.findValue(&

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10740655 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: Feature: use JavaScript to support multiple a...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts pull request: Feature: use JavaScript to support multiple a...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/5#issuecomment-38098723 Changes merged into develop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10768356 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10769526 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10770140 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10771172 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10771988 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10784514 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10784708 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38155805 Where is JIRA issue for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38199004 You must have a strange setup, though. `XmlConfigurationProvider` is instantiated per each configuration file, i.e. `struts-default.xml` (one), `struts-plugin.xml

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38220286 What app do you use to check that? Simple struts2-blank is enough to investigate that? --- If your project is set up for it, you can reply to this email and have

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38222608 Ok, I will double check but it looks like this needs further refactoring - it can be done later --- If your project is set up for it, you can reply to this email and

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-24 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10886002 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assig

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-24 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-38449857 Ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-28 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38965395 Whoa! You are right :-) `XmlConfigurationProvider` is created per config file, eg. `struts-plugin.xml` but we can have many such files on classpath, that's why

[GitHub] struts pull request: loadedFileUrls only contains the last one of ...

2014-03-28 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/6#issuecomment-38966472 Please close this PR, patch applied. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] struts pull request: HttpInterceptor

2014-04-23 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/8 HttpInterceptor New annotation and interceptor to allow limit access to action based on used http request type, ie: @GetOnly public class MyAction extends ActionSupport

[GitHub] struts pull request: Change Servlet Redirect to support absolute U...

2014-04-24 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/9#issuecomment-41319238 Can you open it against `develop` branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] struts pull request: HttpInterceptor

2014-04-25 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/8#issuecomment-41368084 You don't have to use `@Action` annotation to convert class/method into action, the Convention plugin can do it for you. Another thing is that you can use wil

[GitHub] struts pull request: HttpInterceptor

2014-04-25 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/8#issuecomment-41376393 But then you limit usage of it only to the Convention plugin based applications. Even with extending DTD and adding `httpMethod` to `` you will have limitations of

[GitHub] struts pull request: Security: exclude Object's class methods

2014-04-25 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/11 Security: exclude Object's class methods This fix is a follow up of the latest security issues discovered with `ParametersInterceptor` to allow access object's `getClass` metho

[GitHub] struts pull request: Change Servlet Redirect to support absolute U...

2014-04-25 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/10#issuecomment-41459539 Edit this Pull Request and change `source` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] struts pull request: Change Servlet Redirect to support absolute U...

2014-04-25 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/10#issuecomment-41459530 You don't have to have `develop` branch, use your `master` branch and `develop` branch from Struts --- If your project is set up for it, you can reply to this

[GitHub] struts pull request: Change Servlet Redirect to support absolute U...

2014-04-25 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/10#issuecomment-41459932 Step-by-step guideline https://help.github.com/articles/creating-a-pull-request --- If your project is set up for it, you can reply to this email and have your

[GitHub] struts pull request: HttpInterceptor

2014-04-28 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/8#issuecomment-41531020 Let's treat this as a Proof-of-Concept and if will work we can think about further extensions (like extending `@Action` annotation) --- If your project is set u

[GitHub] struts pull request: HttpInterceptor

2014-04-29 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/8#issuecomment-41649420 Ok, I wasn't sure about naming as well, I will rename the annotations to `@HttpGet`, `@HttpPost`, etc --- If your project is set up for it, you can reply to

[GitHub] struts pull request: HttpInterceptor

2014-04-29 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/8#issuecomment-41650283 Good questions, will check that. I have added `@AllowedMethod({GET, POST, PUT})` to cover that case --- If your project is set up for it, you can reply to this email

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-05-20 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-43715553 I think this is ready? Anything else to add? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45061200 I'm not sure if this is the best idea, I mean hardcoding styles in tags - they will always take precedence over CSS classes. --- If your project is set up f

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45182042 It can stay as is for now IMO, we can think about that with S2.5 or S3 - remove hardcoded styles and used CSS classes instead. Then `simple` theme won't provid

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45182314 > BTW what is table.ftl and where it is used? First I thought it's used by `debug.ftl` but I've checked that and it's not - so it's so

[GitHub] struts pull request: Fix a few NullPointerExceptions identified by...

2014-06-10 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/15#issuecomment-45664015 Two issues with this PR: - open a JIRA ticket and reference this PR from it - open PR against `develop` branch, not `master` --- If your project is set up

[GitHub] struts pull request: Change Servlet Redirect to support absolute U...

2014-06-18 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/10#issuecomment-46402105 @dwaite yes, all the commits from your `develop` branch will be included, should I skip changes to the `ChainingInterceptor`? --- If your project is set up for it

[GitHub] struts pull request: [PATCH] WW-4146 Caches only valid Ognl expres...

2014-06-18 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/12#discussion_r13902929 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java --- @@ -279,7 +279,8 @@ public Object compile(String expression) throws

[GitHub] struts pull request: Added support for using freemarker templates ...

2014-06-24 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/17#issuecomment-46938658 Can you create JIRA ticket and link this PR to it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts pull request: Added support for using freemarker templates ...

2014-06-24 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/17#issuecomment-46940928 Done :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-06-26 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-47312080 :eyes: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] struts pull request: Feature: list value localization

2014-06-27 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/18 Feature: list value localization This is continuation of @abrin work started in #7 Closes [WW-4295](https://issues.apache.org/jira/browse/WW-4295) Closes #7 You can merge this

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-06-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-47332091 The work continue in #18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] struts pull request: Feature: list value localization

2014-06-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/18#issuecomment-47332904 @abrin can you review the changes or test them locally? I don't see value in the changes right now as I don't now how do you want to use them. Check the

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-47334012 Is this ready for another shot? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-47358634 I'm going to postpone this PR, it will break Dojo plugin, we can include the changes in S2.5 when Dojo plugin will be dropped as well. --- If your project is s

[GitHub] struts pull request: WW-4360: Fix a few NullPointerExceptions iden...

2014-06-28 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/16#discussion_r14322940 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java --- @@ -425,7 +427,7 @@ protected void

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/19#issuecomment-50593699 Two issues: - please open this PR against `develop` branch, not `master` - please register an issue in JIRA and reference this branch from it https

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575101 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575148 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -893,6 +889,10 @@ public int hashCode

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575196 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575215 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575275 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -246,35 +245,32 @@ public static String findDefaultText

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575748 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15575786 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-07-30 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15576953 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-07-31 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15633237 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java --- @@ -136,13 +129,21 @@ public static void setReloadBundles

[GitHub] struts pull request: Localized by classloader

2014-08-04 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/20#discussion_r15775329 --- Diff: xwork-core/src/test/java/com/opensymphony/xwork2/util/LocalizedTextUtilTest.java --- @@ -133,6 +133,11 @@ public void testDefaultMessage

[GitHub] struts pull request: Localized by classloader

2014-08-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/20#issuecomment-51105487 This looks good, one tiny issue and I'm down ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] struts pull request: Localized by classloader

2014-08-06 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/20#issuecomment-51437103 I assume it is ready to go... let's merge then! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] struts pull request: Localized by classloader

2014-08-13 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/20#issuecomment-52092295 `DefaultBeanSelectionProviderTest` fails with: ``` junit.framework.ComparisonFailure: null Expected :Replaced message for token tag Actual :The form

[GitHub] struts pull request: Locale aware converters

2014-08-14 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/21 Locale aware converters Basically this PR introduces new converters which are `Locale` aware - they will convert values based on current `Locale` provided by `LocaleProvider` This

[GitHub] struts pull request: Localized by classloader

2014-08-19 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/20#issuecomment-52599336 Ok, great! I will take a shot ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] struts pull request: Support java.util.Set objects of complex type...

2014-08-26 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/23#issuecomment-53529533 Please create issue in JIRA and reference this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-08-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-53678677 Did you create appropriated JIRA ticket? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-08-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-53678964 https://issues.apache.org/jira/browse/WW-4355 :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts pull request: HttpInterceptor

2014-09-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/8#issuecomment-56310096 I've moved this branch into my fork - will work on that there --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] struts pull request: Http interceptor

2014-09-21 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/25 Http interceptor This is continuation of work performed in #8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts http

[GitHub] struts pull request: Http interceptor

2014-09-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/25#issuecomment-56311272 @jogep @davelnewton this the final version - I've extended interceptor to support multiple annotation on the same method, see [here](https://github.com/lukaszl

[GitHub] struts pull request: Http interceptor

2014-09-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/25#issuecomment-56311503 This issues is related to https://issues.apache.org/jira/browse/WW-4404 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] struts pull request: Use js to support multiple buttons

2014-09-21 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/26 Use js to support multiple buttons WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts use-js-to-support-multiple

[GitHub] struts pull request: Fix Memory leak in CDI plugin

2014-11-12 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/29#issuecomment-62716399 Can you create JIRA ticket and link this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] struts pull request: Fix Memory leak in CDI plugin

2014-11-12 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/29#issuecomment-62719415 All these builds issue are unrelated to this PR ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] struts pull request: Defend for NPE when performing async request

2014-11-13 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/30#issuecomment-62855204 Please create JIRA ticket and reference this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts pull request: Added support for new Java 8 LocalDate and Lo...

2014-12-07 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/31#issuecomment-66033091 Please create appropriate JIRA ticket and link it here https://issues.apache.org/jira/browse/WW --- If your project is set up for it, you can reply to this email

[GitHub] struts pull request: WW-4427 - Converters are no longer applied to...

2014-12-09 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r21548312 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java --- @@ -351,6 +351,8 @@ private Object tryFindValue(String expr

[GitHub] struts pull request: Added support for new Java 8 LocalDate and Lo...

2014-12-23 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/31#issuecomment-67930144 This won't work as Struts uses Java6 but I have added a new plugin to support Java 8 so it can incorporated in that plugin --- If your project is set up for it

[GitHub] struts pull request: WW-4427 - Converters are no longer applied to...

2014-12-23 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r22206741 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java --- @@ -351,6 +352,7 @@ private Object tryFindValue(String expr

[GitHub] struts pull request: WW-4427 - Converters are no longer applied to...

2014-12-23 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r22218137 --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java --- @@ -351,6 +352,7 @@ private Object tryFindValue(String expr

[GitHub] struts pull request: WW-4399 - struts2-archetype-angularjs uses ab...

2014-12-29 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/24#issuecomment-68246309 @aleksandr-m can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] struts pull request: WW-4399 - struts2-archetype-angularjs uses ab...

2014-12-29 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/24#issuecomment-68297311 Thanks! I will write down `how to merge PRs` guide for committers :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-02-16 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-74625231 I'm not sure if this is a good solution, can you provide more details? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-09 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-77833815 What I meant is that if `ValueStack` is missing in context something wrong happened, so solution to null-check is error-prone :) --- If your project is set up for

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-09 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78003822 That's the case, can you explain what you mean by non-struts2 context? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-11 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78242017 So you can use a `StubValueContext` like this one ```java public class StubValueStack implements ValueStack { Map ctx = new HashMap

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-11 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78426250 But you cannot pass `null` and expect that it will work properly, if you want such behaviour add method with signature that doesn't expect `ValueStack` --- If

[GitHub] struts pull request: Added support for new Java 8 LocalDate and Lo...

2015-05-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/31#issuecomment-104373960 Please re-open this PR against `master` branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-05-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-104374138 Please re-open this PR against `master` branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

  1   2   3   4   >