Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/905
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/905#discussion_r209302881
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -18,6 +18,21 @@
*/
package
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/905#discussion_r207705128
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -212,26 +214,39 @@ private XMLStreamW
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/905#discussion_r207241886
--- Diff:
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/structure/io/graphml/tinkerpop-classic-normalized.xml
---
@@ -1,15 +1,18 @@
Github user svanteschubert commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/905#discussion_r207240077
--- Diff:
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/structure/io/graphml/tinkerpop-classic-normalized.xml
---
@@ -1,15 +1,18 @@
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/905#discussion_r207239273
--- Diff:
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/structure/io/graphml/tinkerpop-classic-normalized.xml
---
@@ -1,15 +1,18 @@
GitHub user svanteschubert opened a pull request:
https://github.com/apache/tinkerpop/pull/905
Pr 891
I have added a test and adjusted the changed according to the comments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/svantesc