Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/732
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/736
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/737
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/715
@mpollmeier Making it official. Please update the title to start with
`TINKERPOP-1822`
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/739
VOTE +1
---
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/742
TINKERPOP-1824 Bump netty to 4.0.52
https://issues.apache.org/jira/browse/TINKERPOP-1824
Latest bug-fix release.
VOTE +1
You can merge this pull request into a Git
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/742
```
$ sh docker/build.sh -i -t -n
...
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/742
@spmallette Updated NOTICE with latest version. No new deps.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/744
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
The race condition is in `put()` and it's used elsewhere. It would make
more sense to fix `put()` to be thread-safe. Then we can keep
`parallelStream()`
```
Map>
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
@mpollmeier Sorry, I thought that `putIfAbsent()` returned the current map
but it returns old mapping or `null` hence the `NPEs`. Should be:
```java
protected void put(final String
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
`mvn -pl tinkergraph-gremlin -DskipIntegrationTests=false -am clean
install` build SUCCESS
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/741
VOTE +1
---
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/750
TINKERPOP-1835 Bump Netty 4.0.53
https://issues.apache.org/jira/browse/TINKERPOP-1835
Latest bug-fix release. No new deps.
Building...
You can merge this pull request into
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@jorgebay On which OS do you get the test errors?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
Indeed it was. Rebase on tp32. Building..
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
Updated the PR to tp32 base
---
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/763
TINKERPOP-1848 python dates should be UTC in and out
https://issues.apache.org/jira/browse/TINKERPOP-1848
You can merge this pull request into a Git repository by running:
$ git
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/763
`docker/build.sh -t` BUILD SUCCESS
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/763
Yeah, I didn't initially see it in tp32. This is not the right approach
anyway. Will push an update.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/763
Fixed test only.
Tests pass.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/765
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
What about for those of us unable to build it?
```
sh docker/build.sh -d
* source: /usr/src/tinkermem/docs/src/recipes/olap-spark-yarn.asciidoc
target
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz I did see that. There was a dep added to the image. I have that
rebuilding now. Will let you know the results.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Just what I was afraid of... the tabs look just like they do in the
screenshots. And I don't mean that in a good way :smile:
Seriously, this is fantastic. Multi-line work
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz my css skills are close to nil. what little i did play with it,
i'm not sure it looks any better. and in the course of doing so, I've grown
accustomed to it.
I
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz I pushed a CTR fix for invisibility to tp32/master. This fixes
the screen from being rendered to pixels wide. It didn't help the code
block language popup though.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
In the 'Console' tab, muli-line statements work. They have the `\`
continuation after the callout. However, on the 'language' tab, these seem to
be lost thus copy-paste m
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Excellent!
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/768
I don't think we should break the interface. I think these should be new
methods and `@deprecate` the old ones. The old methods can call the new methods.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/767
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Try rebuilding the docker images using master.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Hmm.. there doesn't seem to be much difference. Are you deleting both the
hadoop and base images?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/771
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@spmallette did you save your console log?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/773
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/767
Failed docker...
```
docker/build.sh -i -t
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
13.448 s <<< FAIL
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/767
Is it just the wrong expected exception in the test?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@spmallette delete all of your images and then rebuild everything with
`docker/build.sh -d |tee /tmp/console.log` and send me that output file. I
wonder if it's choking on some python dow
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/775
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/778
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/781
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163528577
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -1279,7 +1270,7 @@ The following `RequestMessage` is an example of a
sessionless request for a scri
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163529709
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -75,8 +72,7 @@ file.withWriter { writer ->
writer.write(toJson(msg, "Sessionless Eva
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163529404
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -4066,11 +4075,12 @@ The following `RequestMessage` is an example of a
sessionless request for a
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163529843
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -187,8 +180,7 @@ file.withWriter { writer ->
writer.write(toJson(msg, "Sessionl
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/784
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/786
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/789
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/791
Those tests pass? It doesn't seem to work for me on the cli.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/791
Yeah, ok, apparently I never actually switched branches. Time to get some
coffee
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/786
Hmm... Looks like it is reproducible on tp32.
## 3.2.7
```
apache-tinkerpop-gremlin-console-3.2.7]$ ./bin/gremlin.sh
\,,,/
(o o)
-oOOo-(3
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/794
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/795
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169304285
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java
---
@@ -147,7 +149,12 @@ public void init(final
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169305818
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
---
@@ -293,6 +312,21 @@ private static
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169302920
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1073,7 +1073,8 @@ The following table describes the various
configuration options
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169302646
--- Diff: CHANGELOG.asciidoc ---
@@ -25,6 +25,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169364908
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1073,7 +1073,8 @@ The following table describes the various
configuration options
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/800
The only thing I don't like is that the client keep-alive doesn't seem to
reset the 'write idle time' so the server still sends ping requests to the
client even
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/800
Yes, manually. I was surprised too. In practice, I don't think it's a big
deal. The only reason I could see even using server-side keep-alive is because
client-side keep-alive was
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/793
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/799
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/803
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/804
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/812
What's the difference between the global method cache and the local method
cache?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/808
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/809
```
$ docker/build.sh -i -t -n
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/818
@jbaker-nca Is there a test case that would fail without this fix so it
can catch regressions?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/811
Does this handle custom strategies?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/811
I don't know. Just asking for the record.
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/621#discussion_r176236647
--- Diff: CHANGELOG.asciidoc ---
@@ -110,7 +112,6 @@ This release also includes changes from
<>.
* Removed access to previously depr
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/621#discussion_r176237542
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/ByModulatorOptimizationStrategy.java
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
```
docker/build.sh -i -t -n
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
4.187 s <<< FAIL
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
This test has two `prettyPrint()` assertions.
The first does `prettyPrint()` no args. It passes. However, it's strange
in that two of the `found`s catch the same
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
@dkuppitz
https://gist.github.com/robertdale/8b5fa41432d29b3e99bf5ff2515dff3d
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
@dkuppitz Still, why is it testing `prettyPrint()` and `prettyPrint(160)`?
What does the `160` do for us?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
Looks like my line is longer because it has `vertex` instead of `edge`.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/825
Should get a CHANGELOG entry, right?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/825
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/826
Looks like netty is upgraded in Spark 2.3.0 only.
https://issues.apache.org/jira/browse/SPARK-19552
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/826
Can this be closed now?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/825
Can this be merged?
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/829#discussion_r179166260
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -1515,16 +1516,17 @@
link:++http://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/829#discussion_r179166002
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -1471,16 +1471,17 @@
link:++http://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/829
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181408164
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/838
Look at the Serializers in
`./gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/`
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/837
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/836
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/835
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/832
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/833
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/830
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/831
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/839
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/851
@jorgebay don't forget to vote on your own PR! :smile:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/853
VOTE +1
---
1 - 100 of 390 matches
Mail list logo
