DO NOT REPLY [Bug 48221] New: POM for tomcat-embed-core has bogus dependencies

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48221 Summary: POM for tomcat-embed-core has bogus dependencies Product: Tomcat 7 Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal P

DO NOT REPLY [Bug 48222] New: Source JARs empty in maven central

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48222 Summary: Source JARs empty in maven central Product: Tomcat 7 Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2

DO NOT REPLY [Bug 48223] New: IIS Logs HTTP status code 200 instead of error code

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48223 Summary: IIS Logs HTTP status code 200 instead of error code Product: Tomcat Connectors Version: 1.2.28 Platform: PC OS/Version: Windows Server 2003 Status: NEW Severit

Re: svn commit: r881414 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-18 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/11/17 : >> Author: markt >> Date: Tue Nov 17 17:57:23 2009 >> New Revision: 881414 >> >> + >> +* Update to commons-pool 1.5.4 >> + http://svn.apache.org/viewvc?rev=881412&view=rev >> + +1: markt >> + -1: >> > > Just a note: 1.5.4 is not yet available for downlo

DO NOT REPLY [Bug 48218] Comet example chat.ChatServlet fails to start when running with SecurityManager

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48218 --- Comment #1 from Mark Thomas 2009-11-18 03:51:12 GMT --- Access is controlled per package so the Comet API really needs to be in a separate package (like the Servlet API). This was done for trunk in r833510 but it is an API breaking chan

svn commit: r881735 - /tomcat/trunk/res/maven/tomcat-embed-core.pom

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 11:53:46 2009 New Revision: 881735 URL: http://svn.apache.org/viewvc?rev=881735&view=rev Log: Fix typo Modified: tomcat/trunk/res/maven/tomcat-embed-core.pom Modified: tomcat/trunk/res/maven/tomcat-embed-core.pom URL: http://svn.apache.org/viewvc/tomcat/trunk/

DO NOT REPLY [Bug 48221] POM for tomcat-embed-core has bogus dependencies

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48221 --- Comment #1 from Mark Thomas 2009-11-18 03:58:32 GMT --- The one typo I could find has been fixed in the source (r881735). I believe the group IDs are correct and that both dependencies exist in the correct locations for those IDs. See:

DO NOT REPLY [Bug 48222] Source JARs empty in maven central

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48222 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark

svn commit: r881742 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Protocol.java Http11NioProtocol.java Http11Protocol.java

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 12:10:12 2009 New Revision: 881742 URL: http://svn.apache.org/viewvc?rev=881742&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48217 Make logs final and private; add missing @Override markers Patch provided by sebb. Modified: tomcat/trunk/j

DO NOT REPLY [Bug 48217] Loggers should be final

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48217 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r881748 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 12:25:41 2009 New Revision: 881748 URL: http://svn.apache.org/viewvc?rev=881748&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44041 Threading issue in class loading Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/or

DO NOT REPLY [Bug 44041] WebappClassLoader duplicate class definition under high Load if hasExternalRepositories is true

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44041 --- Comment #12 from Mark Thomas 2009-11-18 04:26:14 GMT --- This has been fixed in 6.0.x (with a slightly different patch) and will be included in 6.0.21 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab

svn commit: r881751 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 12:30:33 2009 New Revision: 881751 URL: http://svn.apache.org/viewvc?rev=881751&view=rev Log: Update patch Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev

svn commit: r881753 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt dist.xml webapps/docs/changelog.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 12:48:13 2009 New Revision: 881753 URL: http://svn.apache.org/viewvc?rev=881753&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267 Display release notes correctly in Windows installer Modified: tomcat/tc6.0.x/trunk/ (props changed)

svn commit: r881756 - /tomcat/native/branches/1.1.x/STATUS.txt

2009-11-18 Thread jfclere
Author: jfclere Date: Wed Nov 18 13:04:27 2009 New Revision: 881756 URL: http://svn.apache.org/viewvc?rev=881756&view=rev Log: Branch is CTR no needed of a STATUS.txt file. Removed: tomcat/native/branches/1.1.x/STATUS.txt -

svn commit: r881759 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/coyote/http11/Http11NioProtocol.java java/org/apache/coyote/http11/Http11Protocol.java webapps/docs/changelog.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:10:48 2009 New Revision: 881759 URL: http://svn.apache.org/viewvc?rev=881759&view=rev Log: Use correct attribute for SSL Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/coyote/http

svn commit: r881760 - /tomcat/native/branches/1.1.x/native/include/tcn_version.h

2009-11-18 Thread jfclere
Author: jfclere Date: Wed Nov 18 13:15:52 2009 New Revision: 881760 URL: http://svn.apache.org/viewvc?rev=881760&view=rev Log: Preparing 1.1.18 release. Modified: tomcat/native/branches/1.1.x/native/include/tcn_version.h Modified: tomcat/native/branches/1.1.x/native/include/tcn_version.h URL

svn commit: r881762 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:19:25 2009 New Revision: 881762 URL: http://svn.apache.org/viewvc?rev=881762&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47495 If server.xml not readable - be more explicit in letting the user know Modified: tomcat/tc6.0.x/trunk/

DO NOT REPLY [Bug 47495] provide meaningful error message also to stdout if server.xml is not readable

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47495 --- Comment #3 from Mark Thomas 2009-11-18 05:20:12 GMT --- Tim's patch has been applied to 6.0.x and will be in 6.0.21 onwards. Konstantin has also proposed an additional patch. -- Configure bugmail: https://issues.apache.org/bugzilla/u

svn commit: r881763 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:20:28 2009 New Revision: 881763 URL: http://svn.apache.org/viewvc?rev=881763&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=881763&

svn commit: r881765 - /tomcat/trunk/res/tomcat.nsi

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:23:51 2009 New Revision: 881765 URL: http://svn.apache.org/viewvc?rev=881765&view=rev Log: Being *really* picky. It is a single web app. Modified: tomcat/trunk/res/tomcat.nsi Modified: tomcat/trunk/res/tomcat.nsi URL: http://svn.apache.org/viewvc/tomcat/tru

svn commit: r881770 - /tomcat/native/tags/TOMCAT_NATIVE_1_1_18/

2009-11-18 Thread jfclere
Author: jfclere Date: Wed Nov 18 13:28:56 2009 New Revision: 881770 URL: http://svn.apache.org/viewvc?rev=881770&view=rev Log: Preparing release 1.1.18. Added: tomcat/native/tags/TOMCAT_NATIVE_1_1_18/ (props changed) - copied from r881769, tomcat/native/branches/1.1.x/ Propchange: to

svn commit: r881771 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt res/tomcat.nsi webapps/docs/changelog.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:32:25 2009 New Revision: 881771 URL: http://svn.apache.org/viewvc?rev=881771&view=rev Log: Fix CVE-2009-3548 When installing using defaults, don't create an administrative user with a blank password Note: This is already public - it was discussed on the users lis

svn commit: r881773 - /tomcat/native/tags/TOMCAT_NATIVE_1_1_18/xdocs/miscellaneous/changelog.xml

2009-11-18 Thread jfclere
Author: jfclere Date: Wed Nov 18 13:35:17 2009 New Revision: 881773 URL: http://svn.apache.org/viewvc?rev=881773&view=rev Log: Oops typo. Modified: tomcat/native/tags/TOMCAT_NATIVE_1_1_18/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/tags/TOMCAT_NATIVE_1_1_18/xdocs/miscellaneous

svn commit: r881774 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java java/org/apache/tomcat/util/net/jsse/JSSESupport.java webapps/docs/changelog.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:37:12 2009 New Revision: 881774 URL: http://svn.apache.org/viewvc?rev=881774&view=rev Log: Provide a workaround for CVE-2009-3555 for the BIO connector Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/jsse/JS

svn commit: r881775 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

2009-11-18 Thread jfclere
Author: jfclere Date: Wed Nov 18 13:39:33 2009 New Revision: 881775 URL: http://svn.apache.org/viewvc?rev=881775&view=rev Log: Oops typo. Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml URL: ht

svn commit: r881776 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/listeners.xml

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:39:45 2009 New Revision: 881776 URL: http://svn.apache.org/viewvc?rev=881776&view=rev Log: Fix typos Modified: tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java tomcat/trunk/webapps/docs/config/listeners.xml Modified: tomc

svn commit: r881777 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:40:07 2009 New Revision: 881777 URL: http://svn.apache.org/viewvc?rev=881777&view=rev Log: Typos fixed in proposed patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/tru

svn commit: r881779 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 13:51:54 2009 New Revision: 881779 URL: http://svn.apache.org/viewvc?rev=881779&view=rev Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=881779

Re: SSL & Tomcat

2009-11-18 Thread Luciana Moreira Sa de Souza Signed by - PrivaSphere AG
Hello, I just added the patch created by Costin Manolache to prevent the MITM attack during re-negotiations for JSSE to our platform. I performed some tests and at first I found the solution quite elegant. Nevertheless, when I did some debugging to verify if everything was really fine I noti

DO NOT REPLY [Bug 48192] Allow to specify the SSLSocket class in connector tag of server.xml

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48192 --- Comment #1 from Ralf Hauser 2009-11-18 06:12:49 UTC --- this might solve the race condition problem in http://marc.info/?l=tomcat-dev&m=125855279313354&w=2 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=ema

svn commit: r881789 - /tomcat/native/branches/1.1.x/KEYS

2009-11-18 Thread jfclere
Author: jfclere Date: Wed Nov 18 14:34:47 2009 New Revision: 881789 URL: http://svn.apache.org/viewvc?rev=881789&view=rev Log: Add my new key and remove the old one. Just the old one will be too short soon/ Modified: tomcat/native/branches/1.1.x/KEYS Modified: tomcat/native/branches/1.1.x/KE

[VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread jean-frederic clere
Hi, Native 1.1.18 is available for testing. Compared with 1.1.17 It just contains the fix for CVE-2009-3555 If you want to take a look, the final source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/native/source/1.1.18 Some binaries will be available

DO NOT REPLY [Bug 48226] New: Wrong JRE_HOME set

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48226 Summary: Wrong JRE_HOME set Product: Tomcat 6 Version: unspecified Platform: Sun OS/Version: Solaris Status: NEW Severity: major Priority: P2 Compone

DO NOT REPLY [Bug 48221] POM for tomcat-embed-core has bogus dependencies

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48221 --- Comment #2 from Dave Syer 2009-11-18 07:40:53 UTC --- I see those artifacts in the repository. There's a spelling error there as well ("tomcta-embed-logging-juli"). The original problem is in the POM for tomcat-embed-core (the groupI

DO NOT REPLY [Bug 48226] Wrong JRE_HOME set

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48226 --- Comment #1 from Andreas Ferrari 2009-11-18 07:41:27 UTC --- dont know if this is fixed in other versions... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because:

Re: SSL & Tomcat

2009-11-18 Thread Costin Manolache
Good catch ! If the listener is called in a separate thread, as it seems from your debugging - the attacker may have a small window when he can still push data - and potentially get the request executed. I guess the probability is extremely small - but theoretically can be done. I'll try it - the

DO NOT REPLY [Bug 48226] Wrong JRE_HOME set

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48226 Andreas Ferrari changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from And

DO NOT REPLY [Bug 48226] Wrong JRE_HOME set

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48226 Andreas Ferrari changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Andreas

Re: svn commit: r881789 - /tomcat/native/branches/1.1.x/KEYS

2009-11-18 Thread sebb
On 18/11/2009, jfcl...@apache.org wrote: > Author: jfclere > Date: Wed Nov 18 14:34:47 2009 > New Revision: 881789 > > URL: http://svn.apache.org/viewvc?rev=881789&view=rev > Log: > Add my new key and remove the old one. > Just the old one will be too short soon/ Have you signed anything wi

Re: svn commit: r881789 - /tomcat/native/branches/1.1.x/KEYS

2009-11-18 Thread jean-frederic clere
On 11/18/2009 05:44 PM, sebb wrote: On 18/11/2009, jfcl...@apache.org wrote: Author: jfclere Date: Wed Nov 18 14:34:47 2009 New Revision: 881789 URL: http://svn.apache.org/viewvc?rev=881789&view=rev Log: Add my new key and remove the old one. Just the old one will be too short soon

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Mladen Turk
On 18/11/09 16:18, jean-frederic clere wrote: Apache Tomcat Native 1.1.18 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Regards -- ^TM --

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Remy Maucherat
On Wed, 2009-11-18 at 16:18 +0100, jean-frederic clere wrote: > [X] Stable - no major issues, no regressions > [ ] Beta - at least one significant issue -- tell us what it is > [ ] Alpha - multiple significant issues -- tell us what they are Rémy -

DO NOT REPLY [Bug 47714] Reponse mixed between users

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47714 --- Comment #2 from Derek 2009-11-18 12:11:52 UTC --- Has this bug where "responses are being mixed between users" been confirmed in mod_jk? If so, would it apply to all the previous versions of mod_JK? -- Configure bugmail: https://issu

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Henri Gomez
Someone try to build it on OS/X ? 2009/11/18 Remy Maucherat : > On Wed, 2009-11-18 at 16:18 +0100, jean-frederic clere wrote: >> [X] Stable - no major issues, no regressions >> [ ] Beta   - at least one significant issue -- tell us what it is >> [ ] Alpha  - multiple significant issues -- tell us

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Henri Gomez
JF, could you provide a new tarball with the configure included. I couldn't built it under OS/X since buildconf failed about missing : cp: /usr/bin/build/apr_common.m4: No such file or directory cp: /usr/bin/build/find_apr.m4: No such file or directory cp: /usr/bin/build/install.sh: No such file

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Filip Hanik - Dev Lists
On 11/18/2009 08:18 AM, jean-frederic clere wrote: [X] Stable - no major issues, no regressions - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r881938 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 21:17:20 2009 New Revision: 881938 URL: http://svn.apache.org/viewvc?rev=881938&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=881

svn commit: r881939 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 21:17:24 2009 New Revision: 881939 URL: http://svn.apache.org/viewvc?rev=881939&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=881

svn commit: r881942 - in /tomcat/trunk/res/maven: tomcat-embed-logging-juli.pom tomcat-embed-logging-log4j.pom

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 21:23:25 2009 New Revision: 881942 URL: http://svn.apache.org/viewvc?rev=881942&view=rev Log: Fix more typos Modified: tomcat/trunk/res/maven/tomcat-embed-logging-juli.pom tomcat/trunk/res/maven/tomcat-embed-logging-log4j.pom Modified: tomcat/trunk/res/mave

DO NOT REPLY [Bug 48221] POM for tomcat-embed-core has bogus dependencies

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48221 --- Comment #3 from Mark Thomas 2009-11-18 13:27:59 GMT --- Found them. Fixed in svn. I'll update the snapshot repository shortly. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving

DO NOT REPLY [Bug 48230] New: Unused imports

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48230 Summary: Unused imports Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Cat

DO NOT REPLY [Bug 48230] Unused imports

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48230 Sebb changed: What|Removed |Added Attachment #24559|0 |1 is patch|

svn commit: r881972 - in /tomcat/trunk/res/maven: tomcat-i18n-fr.pom tomcat-i18n-ja.pom

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 22:37:19 2009 New Revision: 881972 URL: http://svn.apache.org/viewvc?rev=881972&view=rev Log: Fix copy and paste errors Modified: tomcat/trunk/res/maven/tomcat-i18n-fr.pom tomcat/trunk/res/maven/tomcat-i18n-ja.pom Modified: tomcat/trunk/res/maven/tomcat-i18

DO NOT REPLY [Bug 48221] POM for tomcat-embed-core has bogus dependencies

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48221 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r881990 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/tomcat/util/net/ modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 23:10:53 2009 New Revision: 881990 URL: http://svn.apache.org/viewvc?rev=881990&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48230 Remove unused imports. Patch provided by sebb. Modified: tomcat/trunk/java/org/apache/catalina/Authenticato

DO NOT REPLY [Bug 48230] Unused imports

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48230 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r881996 - /tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 23:22:13 2009 New Revision: 881996 URL: http://svn.apache.org/viewvc?rev=881996&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48197 Reduce visibility where possible Fix javadoc Based on a patch by sebb Modified: tomcat/trunk/java/org/apach

DO NOT REPLY [Bug 48197] XByteBuffer: privatize public fields; fix Javadoc

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48197 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r882002 - /tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 23:33:57 2009 New Revision: 882002 URL: http://svn.apache.org/viewvc?rev=882002&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48172 Potential threading issues, make fields final where possible Modified: tomcat/trunk/java/org/apache/jasper/

DO NOT REPLY [Bug 48172] JspRuntimeContext synch. problems.

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48172 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r882004 - /tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 23:47:29 2009 New Revision: 882004 URL: http://svn.apache.org/viewvc?rev=882004&view=rev Log: Fix NPE Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java URL

svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread markt
Author: markt Date: Wed Nov 18 23:54:24 2009 New Revision: 882008 URL: http://svn.apache.org/viewvc?rev=882008&view=rev Log: Fix theorectical sync issue and soem Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java Modified: tomcat/trunk/java/org/apa

DO NOT REPLY [Bug 48177] org.apache.naming.java.javaURLContextFactory.getInitialContext not thread-safe

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48177 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48178] org.apache.tomcat.lite.Locale2Charset.defaultMap is not threadsafe

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48178 Mark Thomas changed: What|Removed |Added Component|Catalina|Modules: tomcat-lite -- Configure b

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Konstantin Kolinko
2009/11/19 : > Author: markt > Date: Wed Nov 18 23:54:24 2009 > New Revision: 882008 > > +        // If the thread is not bound, return a shared writable context > +        if (initialContext == null) { > +            if (initialContext == null) { > +                synchronized(this) { twice the

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/11/19 : >> Author: markt >> Date: Wed Nov 18 23:54:24 2009 >> New Revision: 882008 >> >> +// If the thread is not bound, return a shared writable context >> +if (initialContext == null) { >> +if (initialContext == null) { >> +

svn commit: r882014 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread markt
Author: markt Date: Thu Nov 19 00:20:35 2009 New Revision: 882014 URL: http://svn.apache.org/viewvc?rev=882014&view=rev Log: Fix copy/paste error Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFac

DO NOT REPLY [Bug 48233] New: Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 Summary: Loggers should be private Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Com

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 Sebb changed: What|Removed |Added Attachment #24560|0 |1 is patch|

DO NOT REPLY [Bug 47939] Jars added by VirtualWebappLoader are not scanned for TLDs

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47939 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Konstantin Kolinko
2009/11/19 Mark Thomas : > Konstantin Kolinko wrote: >> >> twice the same condition > > Thanks - I'll fix that. > OK, seen that. On second thought: it is strange to synchronize on "this" to set a static field. That should be synchronized(getClass()) Best regards, Konstantin Kolinko

svn commit: r882017 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/ha/context/ java/org/apache/catalina/ha/deploy/ java/org/apache/catalina/ha/session/ java/org/apache/cat

2009-11-18 Thread markt
Author: markt Date: Thu Nov 19 00:46:52 2009 New Revision: 882017 URL: http://svn.apache.org/viewvc?rev=882017&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 More loggers to private static final Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.j

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r882019 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread markt
Author: markt Date: Thu Nov 19 00:50:04 2009 New Revision: 882019 URL: http://svn.apache.org/viewvc?rev=882019&view=rev Log: Static so sync on class object Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java Modified: tomcat/trunk/java/org/apache/naming/java/javaURL

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/11/19 Mark Thomas : >> Konstantin Kolinko wrote: >>> twice the same condition >> Thanks - I'll fix that. >> > > OK, seen that. > > On second thought: > it is strange to synchronize on "this" to set a static field. That should be > synchronized(getClass()) Fair po

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 Sebb changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 --- Comment #3 from Sebb 2009-11-18 17:28:12 UTC --- Created an attachment (id=24561) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24561) Make logs private (and some final) -- Configure bugmail: https://issues.apache.org/bug

DO NOT REPLY [Bug 48234] New: org.apache.catalina.core.ContainerBase.getLogger() not thread-safe?

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48234 Summary: org.apache.catalina.core.ContainerBase.getLogger() not thread-safe? Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 Mark Thomas changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #4 from Mark Th

DO NOT REPLY [Bug 48234] org.apache.catalina.core.ContainerBase.getLogger() not thread-safe?

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48234 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r882029 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2009-11-18 Thread markt
Author: markt Date: Thu Nov 19 02:01:57 2009 New Revision: 882029 URL: http://svn.apache.org/viewvc?rev=882029&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48234 Align Javadoc with code Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Modified:

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 --- Comment #5 from Sebb 2009-11-18 18:14:59 UTC --- Created an attachment (id=24562) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24562) reworked patch Rats! I'd forgotten that I had disabled compilation of tomcat-lite, as i

DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233 Sebb changed: What|Removed |Added Attachment #24561|0 |1 is obsolete|

DO NOT REPLY [Bug 48234] org.apache.catalina.core.ContainerBase.getLogger() not thread-safe?

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48234 --- Comment #2 from Sebb 2009-11-18 18:26:18 UTC --- (In reply to comment #1) > There is no need to sync getLogger() Is that because it does not matter if the logger is recreated? Or is it because the logger is not accessed from multiple t

DO NOT REPLY [Bug 48235] New: org.apache.catalina.core.ContainerBase.threadDone should be volatile

2009-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48235 Summary: org.apache.catalina.core.ContainerBase.threadDone should be volatile Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread jean-frederic clere
On 11/18/2009 09:43 PM, Henri Gomez wrote: JF, could you provide a new tarball with the configure included. I couldn't built it under OS/X since buildconf failed about missing : cp: /usr/bin/build/apr_common.m4: No such file or directory cp: /usr/bin/build/find_apr.m4: No such file or directory

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Henri Gomez
did you run buildconf ? I'm running SnowLeopard 2009/11/19 jean-frederic clere : > On 11/18/2009 09:43 PM, Henri Gomez wrote: >> >> JF, could you provide a new tarball with the configure included. >> >> I couldn't built it under OS/X since buildconf failed about missing : >> >> cp: /usr/bin/build