Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Above PR has been closed since it ha2 two branches merged and make so many confusions and also make it very hard to maintain the code. So all the comments from the above PR will be resolved and cleaned in https://github.com/wso2/msf4j/pull/365 Please review and comment. Thanks and best

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Above PR has been closed since it ha2 two branches merged and make so many confusions and also make it very hard to maintain the code. So all the comments from the above PR will be resolved and cleaned in https://github.com/wso2/msf4j/pull/365 Please review and comment. Thanks and best

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Thanks Vidura. Will check. *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu,

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Irunika, Added some comments in [1] . Please do check. [1] MSF4J Web Socket Pull Request Thank you, Vidura Nanayakkara On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne wrote: > Hi all, >

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Please review the new changes did and comment. https://github.com/wso2/msf4j/pull/364 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Created new pull request with necessary changes[1]. please review and merge. [1]https://github.com/wso2/carbon-messaging/pull/41 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn :

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Senduran, Yes. We can use a general control message type instead of ping and pong messages. So I removed ping and pong carbon message types from Carbon-Messaging and added new message type ". Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc.

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Irunika, The above PR has PingCarbonMessage and PongCarbonMessage. It will be better if you could rename those two classes to generalized name. Regards Senduran On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah wrote: > Looks ok. > > Senduran/Shafreen, can we

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Looks ok. Senduran/Shafreen, can we merge this PR? On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne wrote: > Hi, > Fixed the issues mentioned. > Please review and merge. > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. * >

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi, Fixed the issues mentioned. Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile :

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu,

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

PR has some formatting issue to be fixed. Can you look into it? On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne wrote: > Hi all, > Can you please review and merge the PR? > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. *

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Can you please review and merge the PR? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314*

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, I modified the Carbon-Messaging according to the requirements. Please review and merge. https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn :

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, I did necessary changes after the review. Please review and merge https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn :

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Fri,

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Adding @dev @Irunika, always copy the relevant mailing list. On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne wrote: > Hi, > Please review and merge > https://github.com/wso2/carbon-messaging/pull/39 > > Thanks, > Irunika > *Irunika Weeraratne* > *Software Engineer | WSO2,