[GitHub] zeppelin issue #1498: [DOCS] Fix dead link in docs/datasource_authorization....

2016-10-08 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1498 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1496: [Zeppelin-907] Apply new mechanism to AngularInterpret...

2016-10-08 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1496 @vectorijk thank you for the contribution the change look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1482: ZEPPELIN-1410 SLF4J: Class path contains multiple SLF4...

2016-10-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1482 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

2016-10-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1483 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 @khalidhuseynov fixed the issue, thank for testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 merging if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 @bzz Regarding your comment, I couldnt agree more, i am not a big fan of returning `null`. I created an issue in [JIRA - 1352](https://issues.apache.org/jira/browse/ZEPPELIN-1352) and I

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 **L**ets **G**et **T**o **M**erge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1344: ZEPPELIN-1164: backport new Shiro realm to 0.6 branch

2016-08-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1344 look good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1340: [MINOR][DOC] Update available interpreters' image in i...

2016-08-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1340 Can you order them alphabetically ? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...

2016-08-17 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1338 [WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo ### What is this PR for? Implement versioning in ZeppelinHub notebook storage. ### What type of PR is

[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...

2016-08-17 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...

2016-08-17 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1338 [WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo ### What is this PR for? Implement versioning in ZeppelinHub notebook storage. ### What type of PR is

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-15 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1254 @bzz can you merge it asap? i need this change if i want to continue my work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-10 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1304 @khalidhuseynov are we really sure about sending `complex object` as a parameter in the URL? How will it be represented? encoded? IMO it is not a good idea, if you ask for a

[GitHub] zeppelin issue #1251: [ZEPPELIN-1256][BUILD] Build distribution package with...

2016-08-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1251 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-08-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 @jongyoul sure, no problemo Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 merging if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 @khalidhuseynov @AhyoungRyu 5a27871f5a9e436653c8862e6d2ecc8913fdd496 for documentation --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 @khalidhuseynov i think it make sense to do it in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 all green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1173 [ZEPPELIN-1164] ZeppelinHub Realm ### What is this PR for? Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1160 @khalidhuseynov what is the benefit of having a new websocket call? will rest api call be enough? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1173: ZeppelinHub Realm

2016-07-12 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1173 ZeppelinHub Realm ### What is this PR for? Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials. ### What type of PR is

[GitHub] zeppelin issue #1119: [DOC] Zeppelin 0.6.0 release note

2016-07-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1119 This [issue](https://issues.apache.org/jira/browse/ZEPPELIN-1104) is missing from the release note --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZeppelinHub notebook storage/conn...

2016-05-28 Thread anthonycorbacho
Github user anthonycorbacho commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/880#issuecomment-222325060 @bzz I took the liberty of merging it, i badly needed this :) --- If your project is set up for it, you can reply to this email and have your reply

<    1   2