Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-28 Thread Leif Lindholm
On Tue, May 28, 2019 at 08:10:44AM +0200, Ard Biesheuvel wrote: > On Tue, 28 May 2019 at 02:17, Liming Gao wrote: > > > > Ard: > > Is there any impact with new option? If no behavior change, I am OK for > > this patch. Reviewed-by: Liming Gao > > > > We don't rely on anything provided by the

Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-28 Thread Wang, Jian J
[edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM > AARCH64: force use of C99 standard > > On Tue, 28 May 2019 at 02:17, Liming Gao wrote: > > > > Ard: > > Is there any impact with new option? If no behavior change, I am OK for > > this > patch. Reviewed

Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-27 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 02:17, Liming Gao wrote: > > Ard: > Is there any impact with new option? If no behavior change, I am OK for > this patch. Reviewed-by: Liming Gao > We don't rely on anything provided by the C11 standard, so it should not result in a behavior change. I do wonder whether

Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-27 Thread Liming Gao
Ard: Is there any impact with new option? If no behavior change, I am OK for this patch. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Tuesday, May 28, 2019 4:52 AM >To: devel@edk2.groups.io >Cc: Ard Biesheuve

[edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-27 Thread Ard Biesheuvel
When building OpenSSL for ARM or AARCH64 with recent Clang, the following error may result: In file included from .../CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c:18: In file included from .../CryptoPkg/Library/OpensslLib/openssl/crypto/include/internal/x509_int.h:10: In file in