On 9/30/19 10:16 PM, Laszlo Ersek wrote:
Hi Phil,
On 09/26/19 14:42, Philippe Mathieu-Daudé wrote:
Hi Laszlo,
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
Both the "ControllerHandle" parameter of CloseProtocol()
Maybe worth adding "of type EFI_CLOSE_PROTOCOL"
and the "Handle"
parameter of Unin
Hi Phil,
On 09/26/19 14:42, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
>> Both the "ControllerHandle" parameter of CloseProtocol()
>
> Maybe worth adding "of type EFI_CLOSE_PROTOCOL"
>
>> and the "Handle"
>> parameter of UninstallMultipleProtocolInter
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Laszlo Ersek
> Sent: 2019年9月18日 3:49
> To: edk2-devel-groups-io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 19/35] NetworkPkg: fix CloseProtocol &
> UninstallMultipleProtocolInterfaces calls
>
> Both the "ControllerHandle" parame
Hi Laszlo,
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> Both the "ControllerHandle" parameter of CloseProtocol()
Maybe worth adding "of type EFI_CLOSE_PROTOCOL"
> and the "Handle"
> parameter of UninstallMultipleProtocolInterfaces()
"of type EFI_UNINSTALL_MULTIPLE_PROTOCOL_INTERFACES"
have type
Jiaxin, Siyuan,
can you please review this patch?
Thanks
Laszlo
On 09/17/19 21:49, Laszlo Ersek wrote:
> Both the "ControllerHandle" parameter of CloseProtocol() and the "Handle"
> parameter of UninstallMultipleProtocolInterfaces() have type EFI_HANDLE,
> not (EFI_HANDLE*).
>
> This patch fixe
Both the "ControllerHandle" parameter of CloseProtocol() and the "Handle"
parameter of UninstallMultipleProtocolInterfaces() have type EFI_HANDLE,
not (EFI_HANDLE*).
This patch fixes actual bugs. The issues have been dormant likely because
they are on error paths. (Or, in case of TlsAuthConfigDxe,
