[PATCH] lxc: fix variable storage order before call

virDomainConfNWFilterInstantiate() was called without updated net->ifname, it caused in some cases throwing error message. If function failed, change is reverted. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/658 Signed-off-by: Adam Julis --- src/lxc/lxc_process.c |

[PATCH] qemu: add hook script event "stop"

The "stop" hook is called when the process of stopping a guest started and it is known that the process can be completed (e.g. the guest is still active). Resolves: https://gitlab.com/libvirt/libvirt/-/issues/647 Signed-off-by: Adam Julis --- docs/hooks.rst | 14 +

[PATCH] network: fix crashing "modify" option for hostname

The original condition caused (after adding modify option) possibly access to not allocated memory. For consistency added new check for multiple same records. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/654 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 9 - 1 file

[PATCH] network: NULL check for "modify" DNS-txt records

The "modify" command allowed to replace an existing record, now checks for the NULL string in the new value and throw error if found. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/655 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 7 +++ 1 file changed, 7

[PATCH] Revert "network: allow "modify" option for DNS-Srv records"

This reverts commit cf934c87cca32149675020ea595712aad25978e6. The matching logic is flawed and it would complicate support of this command. Signed-off-by: Adam Julis --- See discussion: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/6VV6ZAFNGUYUIQZGNS3PZ2FN64NPHXBT

[PATCH v2] vmx: Ensure unique disk targets when parsing

is called virDomainDiskDefAssignAddress() with the updated value. The corresponding tests have been modified to match the index changes. Signed-off-by: Adam Julis --- Since previous version in mailing list was complicated for trying to preserve the indexes of SCSI and previous tests, this one going to straightforward

[PATCH] qemuDomainDiskChangeSupported: Add missing iothreads check

GSList of iothreads is not allowed to be changed while the virtual machine is running. Resolves: https://issues.redhat.com/browse/RHEL-23607 Signed-off-by: Adam Julis --- While the qemuDomainDiskChangeSupported() design primarily uses its macros (CHECK_EQ and CHECK_STREQ_NULLABLE), the logic for

[PATCH] virtiofs: rename member to 'openfiles' for clarity

New element 'openfiles' had confusing name. Since the patch with this new element wasn't propagate yet, old name ('rlimit_nofile') was changed. ... ... Signed-off-by: Adam Julis --- docs/formatdomain.rst | 6 +++--

[PATCH] vmx: Ensure unique disk targets when parsing

. Because assigned addresses of disks are generated from their indexes, for every changed SATA disk is called virDomainDiskDefAssignAddress() with the updated value. The corresponding tests have been modified to match the index changes. Signed-off-by: Adam Julis --- src

[PATCH] qemu: virtiofs: format --rlimit-nofile

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/485 Signed-off-by: Adam Julis --- src/qemu/qemu_virtiofs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 0e3c7dbb58..703f1226a2 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src

[PATCH] conf: virtiofs: add rlimit_nofile element

Add an element to configure the rlimit nofile size: ... ... Non-positive values are forbidden in 'domaincommon.rng'. Added separate test file, created by modifying the 'vhost-user-fs-fd-memory.xml'. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/485 Signe

[PATCH] network: allow "modify" option for DNS-Txt records

n-existing record. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/639 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 18 - .../dns-txt-record-modify-fail.xml| 1 + .../dns-txt-record-modify-success.xml | 1 + .../nat-network-dns-

[PATCH] network: allow "modify" option for DNS-Srv records

rt/libvirt/-/issues/639 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 27 ++- .../srv-not-existing.xml | 1 + .../srv-record-modify-few.xml | 1 + .../nat-network-dns-srv-modify-few.xml| 26 +++

[PATCH] network: allow "modify" option for DNS hostname

datetest.c contain replacements of an existing DNS-Host record and failure due to non-existing record. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/639 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 28 ++- .../dns-host-modify-not-ex

[PATCH] domain_conf: comment not match the code below

The outdated comment refers to a non-existent member in the virDomainObj structure. Signed-off-by: Adam Julis --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7033b4e9fe..115862bbde 100644

[PATCH] qemuDomainChangeNet: forbid changing portgroup

-by: Adam Julis --- src/qemu/qemu_hotplug.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4a3f4f657e..08ca7ab973 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3937,6 +3937,13 @@ qemuDomainChangeNet

[PATCH] qemuDomainChangeNet: forbid changing portgroup

While changing the portgroup attribute causes incorrect behavior, this option is disabled for hot-plug. Resolves: https://issues.redhat.com/browse/RHEL-7299 Signed-off-by: Adam Julis --- src/qemu/qemu_hotplug.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b

[PATCH] qemuDomainDiskChangeSupported: Fill in missing check

Any modification of iothreads attribute is prohibit, the original setup must be identical with updated version of xml. Resolves: https://issues.redhat.com/browse/RHEL-23607 Signed-off-by: Adam Julis --- src/qemu/qemu_domain.c | 47 ++ 1 file changed, 47

[PATCH] qemuDomainDiskChangeSupported: Fill in missing check

The attribute 'discard_no_unref' is not allowed to be changed while the virtual machine is running. Resolves: https://issues.redhat.com/browse/RHEL-37542 Signed-off-by: Adam Julis --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c

[PATCH] conf: Drop unused declaration

Remove unused declaration of the virDomainDiskFindByBusAndDst(). Signed-off-by: Adam Julis --- src/conf/domain_conf.h | 4 1 file changed, 4 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index a06f015444..cdab6ef2da 100644 --- a/src/conf/domain_conf.h +++ b/src

[PATCH 2/2] qemu: implement iommu coldplug/unplug

Resolves: https://issues.redhat.com/browse/RHEL-23833 Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 67b9778c67..74d5e3bb86 100644 --- a/src/qemu

[PATCH 1/2] syms: Properly export virDomainIOMMUDefFree()

While the function is exported via header, the symbol itself was not. Signed-off-by: Adam Julis --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 653c84a520..8d760aca04 100644 --- a/src/libvirt_private.syms

[PATCH 0/2] qemu: implement iommu coldplug/unplug

Adam Julis (2): syms: Properly export virDomainIOMMUDefFree() qemu: implement iommu coldplug/unplug src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) -- 2.45.0

[PATCH 2/2] qemu: implement iommu coldplug/unplug

Resolves: https://issues.redhat.com/browse/RHEL-23833 Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 67b9778c67..74d5e3bb86 100644 --- a/src/qemu

[PATCH] conf: add validation of potential dependencies

virDomainDefValidate is added at the end. Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e2698c7924..67b9778c67 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6869,6 +6869,9

[PATCH] qemu_saveimage: add zstd to supported compression formats

Extend the list of supported formats, update and clarify comment in qemu.conf.in (removed misleading sentence about the order of compression format types). Signed-off-by: Adam Julis --- libvirt.spec.in | 1 + src/qemu/qemu.conf.in | 7 +++ src/qemu/qemu_saveimage.c | 2 ++ 3

[PATCH] qemuDomainChangeNet: Error when boot index changes in live XML

error. Resolves: https://issues.redhat.com/browse/RHEL-23416 Fixies: Commit hash aa3e07caec6179dfa6479deab14a21a493637d53 Signed-off-by: Adam Julis --- src/qemu/qemu_hotplug.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b9c502613c

[PATCH] virt-admin: Fix segfault when libvirtd dies

vshAdmCatchDisconnect requires non-NULL structure vshControl for getting connection name (stored at opaque), but virAdmConnectRegisterCloseCallback at vshAdmConnect called it with NULL. Signed-off-by: Adam Julis --- tools/virt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] virsh: Fix overflow error of freepages command

: https://issues.redhat.com/browse/RHEL-23608 Signed-off-by: Adam Julis --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 6c14be865f..5a934d7a7f 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -335,7

[PATCH] virsh: Fix overflow error of freepages command

Trying to print pages of a size larger than the UINT_MAX of the given platform, a system error was printed, but this is a legitimate request, fixed Signed-off-by: Adam Julis --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools

[PATCH] virfile: switch to virReportSystemError in VIR_CLOSE() cond.

VIR_CLOSE also set errno, so it's not nessesary use virReportError with explicit error code Signed-off-by: Adam Julis --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9463833d31..deaf4555fd 100644 ---

Re: [PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

On 2/20/24 10:31, Adam Julis wrote: Signed-off-by: Adam Julis --- v2: - instead new completer is used already existing virshPoolTypeCompleter - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer - fixed bug in pool-list --type command v1: https://lists.libvirt.org/archives/list

[PATCH v2] virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands

Signed-off-by: Adam Julis --- v2: - instead new completer is used already existing virshPoolTypeCompleter - added flag VIRSH_POOL_TYPE_COMPLETER_COMMA for the completer - fixed bug in pool-list --type command v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message

[PATCH] virsh: completer for --type of commands find-storage-pool-sources and find-storage-pool-sources-as

Signed-off-by: Adam Julis --- tools/virsh-completer-pool.c | 11 +++ tools/virsh-completer-pool.h | 5 + tools/virsh-pool.c | 2 ++ 3 files changed, 18 insertions(+) diff --git a/tools/virsh-completer-pool.c b/tools/virsh-completer-pool.c index 0600394411..1081e5c10c