Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 6/9/21 3:49 pm, Sebastian Huber wrote: > On 04/09/2021 06:20, Joel Sherrill wrote: >> > -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION); >> > +    sc = _TOD_Validate(&temp_tod); >> >>     This has leaked out of the internal implementation interface. Should it? >> >>    

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 06/09/2021 09:55, Chris Johns wrote: On 6/9/21 3:49 pm, Sebastian Huber wrote: On 04/09/2021 06:20, Joel Sherrill wrote: > -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION); > +    sc = _TOD_Validate(&temp_tod);     This has leaked out of the internal implementa

[PATCH RSB] rtems-tools-6.cfg: Bump hash to include fixes for clang

Hash: 9d399df4ef0050e9c190b38217b0e5d27dd0be72 --- rtems/config/tools/rtems-tools-6.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtems/config/tools/rtems-tools-6.cfg b/rtems/config/tools/rtems-tools-6.cfg index 4dcb9ea..342c54f 100644 --- a/rtems/config/tools/rtems-tool

Re: [PATCH 1/2] tester: Count tester header errors

These two patches look good with one minor nit below. On 9/5/2021 02:57, chr...@rtems.org wrote: From: Chris Johns - Remove the hard tester error and count the header errors. --- tester/rt/report.py | 17 + tester/rt/test.py | 7 +-- 2 files changed, 18 insertions(+)

Re: [PATCH 1/2] tester: Count tester header errors

On 7/9/21 7:34 am, Kinsey Moore wrote: > These two patches look good with one minor nit below. Thanks update and post a v2 with a bunch of fixes soon. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 6/9/21 6:11 pm, Sebastian Huber wrote: > On 06/09/2021 09:55, Chris Johns wrote: >> On 6/9/21 3:49 pm, Sebastian Huber wrote: >>> On 04/09/2021 06:20, Joel Sherrill wrote:   > -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION);   > +    sc = _TOD_Validate(&temp_tod

[PATCH] testsuites: Wrap putchar

The linker flag to wrap putchar was lost in translation from make to waf. --- spec/build/testsuites/ada/grp.yml| 1 + spec/build/testsuites/benchmarks/grp.yml | 1 + spec/build/testsuites/fstests/grp.yml| 1 + spec/build/testsuites/libtests/grp.yml | 1 + spec/build/testsuites/mptest

[PATCH] testsuites/fstests: Fix uninitialized utimbuf structs

The utimbuf structs in fsimfsconfig01 and fsimfsconfig02 were being passed to utime uninitialized. This did not cause problems until utime was changed to use utimensat behind the scenes. Now that utimensat is called, the values of the utimbuf struct are checked, and EINVAL is set for invalid values

[PATCH v2 1/5] tester/zynqmp: Limit the restarts to 3

From: Chris Johns --- tester/rtems/testing/bsps/xilinx_zynqmp_lp64_zu3eg.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/tester/rtems/testing/bsps/xilinx_zynqmp_lp64_zu3eg.ini b/tester/rtems/testing/bsps/xilinx_zynqmp_lp64_zu3eg.ini index c4d091f..dff7d86 100644 --- a/tester/rtems/testi

[PATCH v2 2/5] misc/tftprpoxy: Correctly scale the protocol timeout

From: Chris Johns - Fix data decoding - Fix get MAC call --- misc/tools/tftpproxy.py | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/misc/tools/tftpproxy.py b/misc/tools/tftpproxy.py index c0aebb0..a388912 100644 --- a/misc/tools/tftpproxy.py +++ b/misc/tools/t

[PATCH v2 3/5] tester/telnet: Only reopen once a second

From: Chris Johns - Limit the reopen to once a second - Make sure the socket is closed when reopening --- tester/rt/telnet.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tester/rt/telnet.py b/tester/rt/telnet.py index 4e5e84a..919aa86 100644 --- a/tester/rt/tel

[PATCH v2 4/5] tester: Count tester header errors

From: Chris Johns - Remove the hard tester error and count the header errors. --- tester/rt/config.py | 2 +- tester/rt/report.py | 32 +++- tester/rt/test.py | 7 +-- 3 files changed, 29 insertions(+), 12 deletions(-) diff --git a/tester/rt/config.py b/teste

[PATCH v2 5/5] tester/tftp: Fix prptocol timeout handling

From: Chris Johns - Change some of the notification messages --- tester/rt/tftp.py | 2 +- tester/rt/tftpserver.py | 28 ++-- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/tester/rt/tftp.py b/tester/rt/tftp.py index af5029a..49bdb29 100644 --- a/

[PATCH] tester/zynqmp: Simpify the reasons to reset

From: Chris Johns - Only reset if the bootloader error is hardware related. --- tester/rtems/testing/bsps/xilinx_zynqmp_ilp32_zu3eg.ini | 2 +- tester/rtems/testing/bsps/xilinx_zynqmp_lp64_zu3eg.ini | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tester/rtems/testing/bsps

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 07/09/2021 05:11, Chris Johns wrote: On 6/9/21 6:11 pm, Sebastian Huber wrote: On 06/09/2021 09:55, Chris Johns wrote: On 6/9/21 3:49 pm, Sebastian Huber wrote: On 04/09/2021 06:20, Joel Sherrill wrote:   > -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION);   > +   

Re: [PATCH] testsuites: Wrap putchar

On 07/09/2021 05:16, Alex White wrote: The linker flag to wrap putchar was lost in translation from make to waf. Looks good. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18

Re: [PATCH] testsuites/fstests: Fix uninitialized utimbuf structs

On 07/09/2021 05:47, Alex White wrote: The utimbuf structs in fsimfsconfig01 and fsimfsconfig02 were being passed to utime uninitialized. This did not cause problems until utime was changed to use utimensat behind the scenes. Now that utimensat is called, the values of the utimbuf struct are chec

Re: [PATCH] testsuites: Wrap putchar

On 7/9/21 3:34 pm, Sebastian Huber wrote: > On 07/09/2021 05:16, Alex White wrote: >> The linker flag to wrap putchar was lost in translation from make to waf. > > Looks good. Agreed. I have just been testing it on a zynqmp. Chris ___ devel mailing lis