Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-22 Thread Tony Lindgren
* G, Manjunath Kondaiah [110719 09:59]: > On Tue, Jul 19, 2011 at 2:00 AM, Grant Likely > wrote: > > > > No, the i2c bus node should still appear in the SoC .dtsi file.  If a > > board doesn't use a particular i2c bus, then the board.dts file can > > add a status = "disabled"; property to the i2

Re: [PATCH] OMAP: omap_device: replace _find_by_pdev() with to_omap_device()

2011-07-22 Thread Felipe Balbi
On Thu, Jul 21, 2011 at 04:52:11PM -0700, Kevin Hilman wrote: > The omap_device layer currently has two ways of getting an omap_device > pointer from a platform_device pointer. > > Replace current usage of _find_by_pdev() with to_omap_device() since > to_omap_device() is more familiar to the exist

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Felipe Balbi
On Thu, Jul 21, 2011 at 04:52:14PM -0700, Kevin Hilman wrote: > For converting from struct device to platform_device, and from > platform_device to struct device, there are existing macros. Use > them instead of manual use of container_of(). > > Signed-off-by: Kevin Hilman > --- > arch/arm/plat

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-22 Thread Felipe Balbi
Hi, On Thu, Jul 21, 2011 at 04:52:13PM -0700, Kevin Hilman wrote: > Board code should not touch omap_device internals. To get the MPU/IVA > devices, > use existing APIs: omap2_get_mpu_device(), omap2_get_iva_device(). > > Signed-off-by: Kevin Hilman > --- > arch/arm/mach-omap2/board-omap3beag

[PATCH v2 1/3] i2c: s3c2410: Keep a copy of platform data and use it.

2011-07-22 Thread Thomas Abraham
The platform data is copied into driver's private data and the copy is used for all access to the platform data. This simpifies the addition of device tree support for the i2c-s3c2410 driver. Signed-off-by: Thomas Abraham --- drivers/i2c/busses/i2c-s3c2410.c |7 +-- 1 files changed, 5 in

[PATCH v2 2/3] i2c: s3c2410: Add device tree support

2011-07-22 Thread Thomas Abraham
Add device tree probe support for Samsung's s3c2410 i2c driver. Signed-off-by: Thomas Abraham --- .../devicetree/bindings/i2c/samsung-i2c.txt| 44 + drivers/i2c/busses/i2c-s3c2410.c | 51 +++- 2 files changed, 94 insertions(+), 1 dele

[PATCH v2 0/3] Add device tree support for Samsung's I2C driver

2011-07-22 Thread Thomas Abraham
This patchset adds device tree support for Samsung's I2C driver. The Exynos4 DT enabled machine is updated to support device tree based probe for I2C instance 0 and 1. Changes since v1: - Addressed all comments from Grant Likely - s3c24xx_i2c_is2440 function is simpler now. - Consolidated

[PATCH v2 3/3] arm: dt: Add device tree support for i2c instance 0 and 1 on exynos4 dt machine

2011-07-22 Thread Thomas Abraham
Add device node for i2c instance 0 and 1 and list all its connected slave devices. Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos4-smdkv310.dts | 45 +++ arch/arm/mach-exynos4/Kconfig |2 + arch/arm/mach-exynos4/mach-exynos4-dt.c | 23 ++

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Sergei Shtylyov
Hello. On 22-07-2011 3:52, Kevin Hilman wrote: For converting from struct device to platform_device, and from platform_device to struct device, You mean from platform_device to omap_device? there are existing macros. Use them instead of manual use of container_of(). Signed-off-by: Ke

Re: Same parts of DT being probed twice

2011-07-22 Thread Grant Likely
On Thu, Jul 21, 2011 at 03:46:02PM +0100, Daniel Drake wrote: > Hi, > > We're working on enabling the HDD LED on the XO-1.5 laptop using > gpio-leds and its automatic interaction with the device tree. I have > it working locally, but there is something not quite right. > > We have modified the de

Re: [PATCH] watchdog: imx2_wdt: add device tree probe support

2011-07-22 Thread Wim Van Sebroeck
Hi Shawn, > It adds device tree probe support for imx2_wdt driver. > > Signed-off-by: Shawn Guo > Cc: Grant Likely > Cc: Wolfram Sang > Cc: Wim Van Sebroeck Patch added to linux-2.6-watchdog-next. Kind regards, Wim. ___ devicetree-discuss mailing

Re: [PATCH] Various fixups from first bug reports

2011-07-22 Thread Uwe Kleine-König
Hello, On Fri, Jul 22, 2011 at 08:34:59PM +0930, Rusty Russell wrote: > On Fri, 22 Jul 2011 08:57:11 +0200, Uwe Kleine-König > wrote: > > > second was with CONFIG_LGUEST_GUEST enabled, module build stage 2 failed > > > with Documentation/lguest not found > > Hmm, there is Documentation/virtual/l

Re: Same parts of DT being probed twice

2011-07-22 Thread Daniel Drake
On 22 July 2011 18:35, Grant Likely wrote: > of_platform_bus_probe() from the root of the tree is the wrong > approach for registering 'deep' devices.  of_platform_bus_probe() only > knows how to deal with platform_devices.  The moment something > non-trivial appears in between, it no longer works

[PATCH 2/2] arm: omap: mark dt_compat __initconst

2011-07-22 Thread Felipe Balbi
we have a special section for const data which is only needed during init, that's __initconst. Use that instead of __initdata which is for non-const data. Cc: Grant Likely Signed-off-by: Felipe Balbi --- arch/arm/mach-omap2/board-igep0020.c|2 +- arch/arm/mach-omap2/board-igep0030.c

[PATCH 1/2] of: address: use resource_size helper

2011-07-22 Thread Felipe Balbi
that should be the approved way of calculating the size of resources. No functional changes. Cc: Grant Likely Signed-off-by: Felipe Balbi --- drivers/of/address.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index deefc0c.

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Kevin Hilman
Hi Sergei, Sergei Shtylyov writes: > On 22-07-2011 3:52, Kevin Hilman wrote: > >> For converting from struct device to platform_device, and from >> platform_device to struct device, > >You mean from platform_device to omap_device? > Yes indeed, thanks. Updated patch below (only changelog c