Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

2013-07-12 Thread Haojian Zhuang
On Fri, Jul 12, 2013 at 11:10 PM, Daniel Drake wrote: > On Thu, Jul 11, 2013 at 5:54 PM, Haojian Zhuang > wrote: >>> Well, Daniel Drake spoke up for OLPC. Does that count? >> >> We don't know they used DT on Marvell MMP2/MMP3. So they don't have DTS file >

Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

2013-07-11 Thread Haojian Zhuang
On Thu, Jul 11, 2013 at 5:50 AM, Jason Cooper wrote: > On Wed, Jul 10, 2013 at 10:08:50PM +0800, Haojian Zhuang wrote: >> On Wed, Jul 10, 2013 at 8:24 PM, Jason Cooper wrote: >> > On Wed, Jul 10, 2013 at 04:19:46PM +0800, Haojian Zhuang wrote: >> >> On Tue, Jul 9,

Re: [PATCH V3 2/3] clocksource: mmp: support CLOCKSOURCE OF DECLARE

2013-07-11 Thread Haojian Zhuang
On Thu, Jul 11, 2013 at 7:23 PM, Neil Zhang wrote: > Haojian, > > >> -Original Message- >> From: Haojian Zhuang [mailto:haojian.zhu...@gmail.com] >> Sent: 2013年7月10日 13:59 >> To: Arnd Bergmann >> Cc: Thomas Petazzoni; Neil Zhang; Grant Likely; >&g

Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

2013-07-10 Thread Haojian Zhuang
On Wed, Jul 10, 2013 at 8:24 PM, Jason Cooper wrote: > On Wed, Jul 10, 2013 at 04:19:46PM +0800, Haojian Zhuang wrote: >> On Tue, Jul 9, 2013 at 8:49 PM, Jason Cooper wrote: >> > Neil, >> > >> > On Tue, Jul 09, 2013 at 02:42:44PM +0800, Neil Zhang wrote: &g

Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

2013-07-10 Thread Haojian Zhuang
On Tue, Jul 9, 2013 at 8:49 PM, Jason Cooper wrote: > Neil, > > On Tue, Jul 09, 2013 at 02:42:44PM +0800, Neil Zhang wrote: >> The documented vendor prefix for Marvell is 'marvell', not 'mrvl', so >> let's change it. >> >> Signed-off-by: Neil Zhang >> --- >> .../devicetree/bindings/arm/mrvl/intc

Re: [PATCH V3 2/3] clocksource: mmp: support CLOCKSOURCE OF DECLARE

2013-07-09 Thread Haojian Zhuang
On Wed, Jul 10, 2013 at 5:16 AM, Arnd Bergmann wrote: > On Tuesday 09 July 2013, Thomas Petazzoni wrote: >> Dear Neil Zhang, >> >> On Tue, 9 Jul 2013 14:42:45 +0800, Neil Zhang wrote: >> > support CLOCKSOURCE OF DECLARE for mmp timer. >> > >> > Signed-off-by: Neil Zhang >> > --- >> > arch/arm/ma

Re: [PATCH v3 3/5] clk: dt: binding for basic multiplexer clock

2013-06-25 Thread Haojian Zhuang
On 21 June 2013 14:14, Mike Turquette wrote: > Device Tree binding for the basic clock multiplexer, plus the setup > function to register the clock. Based on the existing fixed-clock > binding. > > Includes minor beautification of clk-provider.h where some whitespace is > added and of_fixed_facto

Re: [PATCH 3/4] pinctrl: single: omap: Add SoC specific module for wake-up events

2013-06-08 Thread Haojian Zhuang
On Sat, Jun 8, 2013 at 4:50 AM, Tony Lindgren wrote: > For wake-up events from deeper idle modes we need to check the > configured padconf registers for the wake-up bit and then call > the related interrupt handler. > > Done in collaboration with Roger Quadros . > > Cc:

Re: [PATCH 1/4] pinctrl: single: Prepare for supporting SoC specific features

2013-06-08 Thread Haojian Zhuang
On Sat, Jun 8, 2013 at 11:27 PM, Tony Lindgren wrote: > * Haojian Zhuang [130608 02:43]: >> >> Manjunathappa's pinctrl-single patch on enhancing bits is already merged. >> This patch conflicts with his patch. >> >> Could you rebase your patches? > >

Re: [PATCH 2/4] pinctrl: single: Add hardware specific hooks for IRQ and GPIO wake-up events

2013-06-08 Thread Haojian Zhuang
> lose interrupts. > > Allow supporting IRQ and GPIO wake-up events if a hardware > spefific module is registered for the enable and disable > calls. > > Done in collaboration with Roger Quadros . > > Cc: Haojian Zhuang > Cc: Peter Ujfalusi > Cc: devicetree-discus

Re: [PATCH 1/4] pinctrl: single: Prepare for supporting SoC specific features

2013-06-08 Thread Haojian Zhuang
nctrl-single if needed. > > Done in collaboration with Roger Quadros . > Manjunathappa's pinctrl-single patch on enhancing bits is already merged. This patch conflicts with his patch. Could you rebase your patches? > Cc: Haojian Zhuang > Cc: Peter Ujfalusi > Cc: device

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-06-08 Thread Haojian Zhuang
On 8 June 2013 03:18, Stephen Warren wrote: > On 06/06/2013 09:30 AM, Christian Ruppert wrote: >> On Thu, Jun 06, 2013 at 10:32:21PM +0800, Haojian Zhuang wrote: >>> On 6 June 2013 22:11, Christian Ruppert >>> wrote: >>>> On Wed, Jun 05, 2013 at 09:44:27A

Re: pxa27x and pinctrl-single

2013-06-07 Thread Haojian Zhuang
On 8 June 2013 01:41, Mike Dunn wrote: > On 06/07/2013 08:16 AM, Haojian Zhuang wrote: >> > > [...] > > >> Since you need to configure both GPDRx and GAFRx. If we are talking >> pinctrl-single >> as reference, we can make it work by this way. >> >&g

Re: [PATCH v2 1/8] clk: flag to use upper half of the register as change indicator

2013-06-07 Thread Haojian Zhuang
On 7 June 2013 20:27, Heiko Stübner wrote: > Am Freitag, 7. Juni 2013, 13:46:32 schrieb Linus Walleij: >> On Thu, Jun 6, 2013 at 9:08 PM, Heiko Stübner wrote: >> > There exist platforms, namely at least all Rockchip Cortex-A9 based ones, >> > that don't use the paradigm of reading-changing-writin

Re: pxa27x and pinctrl-single

2013-06-07 Thread Haojian Zhuang
On 7 June 2013 22:50, Mike Dunn wrote: > On 06/06/2013 06:21 PM, Haojian Zhuang wrote: >> On Fri, Jun 7, 2013 at 8:48 AM, Mike Dunn wrote: >>> On 06/06/2013 04:58 PM, Haojian Zhuang wrote: >>>> On 7 June 2013 01:33, Mike Dunn wrote: >>>>> >>>

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-06-07 Thread Haojian Zhuang
On 7 June 2013 19:32, Christian Ruppert wrote: > On Fri, Jun 07, 2013 at 08:00:57AM +0800, Haojian Zhuang wrote: >> On 6 June 2013 23:30, Christian Ruppert wrote: >> > On Thu, Jun 06, 2013 at 10:32:21PM +0800, Haojian Zhuang wrote: >> >> On 6 June 2013 22:11, C

Re: pxa27x and pinctrl-single

2013-06-06 Thread Haojian Zhuang
On Fri, Jun 7, 2013 at 8:48 AM, Mike Dunn wrote: > On 06/06/2013 04:58 PM, Haojian Zhuang wrote: >> On 7 June 2013 01:33, Mike Dunn wrote: >>> > > > [...] > > >>> >>> Yes, but currently pinctrl-single only supports writing one register for

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-06-06 Thread Haojian Zhuang
On 6 June 2013 23:30, Christian Ruppert wrote: > On Thu, Jun 06, 2013 at 10:32:21PM +0800, Haojian Zhuang wrote: >> On 6 June 2013 22:11, Christian Ruppert wrote: >> > On Wed, Jun 05, 2013 at 09:44:27AM +0800, Haojian Zhuang wrote: >> >> On 3 June 2013 20:30, C

Re: pxa27x and pinctrl-single

2013-06-06 Thread Haojian Zhuang
On 7 June 2013 01:33, Mike Dunn wrote: > Thanks for the reply Haojian. > > On 06/05/2013 05:43 PM, Haojian Zhuang wrote: >> On 6 June 2013 01:23, Mike Dunn wrote: >>> Hi, >>> >>> I'd like to start converting to device tree usage some of the old

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-06-06 Thread Haojian Zhuang
On 6 June 2013 22:11, Christian Ruppert wrote: > On Wed, Jun 05, 2013 at 09:44:27AM +0800, Haojian Zhuang wrote: >> On 3 June 2013 20:30, Christian Ruppert wrote: >> > OK, here's a simplified example of what we would like to do (this seems >> > pretty common so I

Re: pxa27x and pinctrl-single

2013-06-05 Thread Haojian Zhuang
On 6 June 2013 01:23, Mike Dunn wrote: > Hi, > > I'd like to start converting to device tree usage some of the old pxa27x > platforms I'm fond of, starting with adding pinctrl support. If I'm not > mistaken, this will clear the way for some ongoing updates to the pinctrl/gpio > code used by newer

Re: [PATCH 2/3] pinctrl: pinctrl-single: pin names for pinctrl-single.bits

2013-06-04 Thread Haojian Zhuang
On Tue, May 21, 2013 at 10:08 PM, Manjunathappa, Prakash wrote: > Take care to name pin names as > register-offset.bit-pos-of-pin-in-register in case configuring multiple > pins in register. > > Signed-off-by: Manjunathappa, Prakash > --- Acked-

Re: [PATCH 1/3] pinctrl: pinctrl-single: enhance to configure multiple pins of different modules

2013-06-04 Thread Haojian Zhuang
04), > > Signed-off-by: Manjunathappa, Prakash > Reported-by: Lad, Prabhakar > Tested-by: Lad, Prabhakar Excuse me for response late. Acked-by: Haojian Zhuang ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-06-04 Thread Haojian Zhuang
On 3 June 2013 20:30, Christian Ruppert wrote: > OK, here's a simplified example of what we would like to do (this seems > pretty common so I suppose there is a way I haven't understood). Our > situation is slightly more complex but for the purpose of discussion > let's assume a chip with 8 pins w

Re: [PATCH 0/3] pinctrl: pinctrl-single: Add full fledge support to configure multiple pins of different modules

2013-05-26 Thread Haojian Zhuang
On 24 May 2013 17:03, Linus Walleij wrote: > On Tue, May 21, 2013 at 4:07 PM, Manjunathappa, Prakash > wrote: > >> Based function-mask and submask preoperties patch allocates and registers >> pins. >> Patch is fixes the issue reported and discussed here: >> http://www.spinics.net/lists/arm-kerne

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-05-26 Thread Haojian Zhuang
On 24 May 2013 19:50, Christian Ruppert wrote: > Hello Haojian, > > On Thu, May 23, 2013 at 03:43:27PM +0800, Haojian Zhuang wrote: >> On 22 May 2013 22:28, Christian Ruppert wrote: >> > >> > On Mon, May 20, 2013 at 10:10:33AM +0200, Linus Walleij wrote: >&

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-05-23 Thread Haojian Zhuang
dy have this?) > > > > Now I'm ever more confused ... we already have this :-) > > > > It's not even pinctrl-simple-centric it is completely generic. > > The code is in drivers/gpio/gpiolib-of.c. > > > > It was written by Shiraz Hashin and Haoj

Re: [PATCH] pinctrl: single: fix error return code in pcs_parse_one_pinctrl_entry()

2013-05-07 Thread Haojian Zhuang
On 7 May 2013 20:57, Wei Yongjun wrote: > On 05/07/2013 08:11 PM, Haojian Zhuang wrote: >> On 7 May 2013 20:06, Wei Yongjun wrote: >>> From: Wei Yongjun >>> >>> Fix to return a negative error code from the error handling >>> case ins

Re: [PATCH] pinctrl: single: fix error return code in pcs_parse_one_pinctrl_entry()

2013-05-07 Thread Haojian Zhuang
On 7 May 2013 20:06, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Introduced by commit 9dddb4df90d136429b6d6ddefceb49a9b93f6cd1 > (pinctrl: single: support generic pinconf) > > S

[PATCH 6/6] Documentation: add docs for max8925 dt

2013-02-11 Thread Haojian Zhuang
From: Qing Xu add docs for dt of max8925-mfd, max8925-backlight, and max8925-battery Signed-off-by: Qing Xu Signed-off-by: Haojian Zhuang --- Documentation/devicetree/bindings/mfd/max8925.txt | 64 .../bindings/power_supply/max8925_batter.txt | 18

[PATCH 5/6] mfd: max8925: add dts

2013-02-11 Thread Haojian Zhuang
From: Qing Xu Add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu Signed-off-by: Haojian Zhuang --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions(+), 1

[PATCH 4/6] mfd: max8925: support dt for backlight

2013-02-11 Thread Haojian Zhuang
From: Qing Xu Add device tree support in max8925 backlight. Signed-off-by: Qing Xu Signed-off-by: Haojian Zhuang --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/max8925_bl.c

[PATCH 3/6] mfd: max8925: fix onkey driver irq base

2013-02-11 Thread Haojian Zhuang
From: Qing Xu update onkey driver's irq base, it should get from max8925, but not save in a private value Signed-off-by: Qing Xu Acked-by: Dmitry Torokhov --- drivers/input/misc/max8925_onkey.c |3 --- drivers/mfd/max8925-core.c |2 +- 2 files changed, 1 insertion(+), 4 deleti

[PATCH 2/6] mfd: max8925: fix mfd device register failure

2013-02-11 Thread Haojian Zhuang
From: Qing Xu we encounter rtc/power/touch driver registry failure, root cause it is resources confilict in insert_resouce, solved by changing mfd_add_devices 5th parameter to NULL Signed-off-by: Qing Xu --- drivers/mfd/max8925-core.c | 22 ++ 1 file changed, 10 insertion

[PATCH 1/6] mfd: max8925: add irqdomain for dt

2013-02-11 Thread Haojian Zhuang
From: Qing Xu Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu Signed-off-by: Haojian Zhuang --- drivers/mfd/max8925-core

Re: [PATCH 1/6] mfd: max8925: add irqdomain for dt

2013-02-05 Thread Haojian Zhuang
On Tue, Feb 5, 2013 at 4:19 PM, Samuel Ortiz wrote: > Hi Haojian, > > On Mon, Feb 04, 2013 at 11:40:42PM +0800, Haojian Zhuang wrote: >> From: Qing Xu >> >> Add irqdomains for max8925's main irq, wrap irq register operations >> into irqdomain'

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2013-02-04 Thread Haojian Zhuang
On Mon, Feb 4, 2013 at 7:32 PM, Samuel Ortiz wrote: > Hi Haojian, > > On Mon, Feb 04, 2013 at 09:05:09AM +0800, Haojian Zhuang wrote: >> Hi Samuel, >> >> Are they merged into your git tree? > No, they're not. Qing sent several versions for many of the patches i

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2013-02-03 Thread Haojian Zhuang
On Wed, Dec 12, 2012 at 2:22 PM, Qing Xu wrote: > On 12/04/2012 03:11 PM, Haojian Zhuang wrote: >> >> On Thu, Nov 29, 2012 at 1:54 PM, Qing Xu wrote: >>> >>> On 11/23/2012 05:09 PM, Haojian Zhuang wrote: >>>> >>>> On Tue, Nov 6, 2

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-12-03 Thread Haojian Zhuang
On Thu, Nov 29, 2012 at 1:54 PM, Qing Xu wrote: > On 11/23/2012 05:09 PM, Haojian Zhuang wrote: >> >> On Tue, Nov 6, 2012 at 3:35 PM, Qing Xu wrote: >>> >>> From: Qing Xu >>> >>> 1. add irqdomain for max8925, it is necessary for dt support

Re: [PATCH] Documentation: add docs for max8925 dt

2012-12-03 Thread Haojian Zhuang
ocumentation/devicetree/bindings/power_supply/max8925_batter.txt > create mode 100644 > Documentation/devicetree/bindings/video/backlight/max8925-backlight.txt > Acked-by: Haojian Zhuang ___ devicetree-discuss mailing list devicetree-discuss@lists.o

Re: [PATCH v4 7/7] mfd: max8925: add dts

2012-12-03 Thread Haojian Zhuang
}; > }; > rtc: rtc@d401 { > status = "okay"; > diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi > index 80f74e2..76f9cc7 100644 > --- a/arch/arm/boot/dts/mmp2.dtsi > +++ b/

Re: [PATCH v3 1/7] mfd: max8925: add irqdomain for dt

2012-12-03 Thread Haojian Zhuang
.of_match_table = of_match_ptr(max8925_dt_ids), > }, > .probe = max8925_probe, > .remove = __devexit_p(max8925_remove), > @@ -217,7 +249,6 @@ static struct i2c_driver max8925_driver = { > static int __init max8925_i2c_init(void) > { > int ret; > - > ret = i2c_add_driver(&max8925_driver); > if (ret != 0) > pr_err("Failed to register MAX8925 I2C driver: %d\n", ret); > diff --git a/include/linux/mfd/max8925.h b/include/linux/mfd/max8925.h > index 74d8e29..ce8502e 100644 > --- a/include/linux/mfd/max8925.h > +++ b/include/linux/mfd/max8925.h > @@ -190,6 +190,8 @@ enum { > MAX8925_NR_IRQS, > }; > > + > + > struct max8925_chip { > struct device *dev; > struct i2c_client *i2c; > @@ -201,7 +203,6 @@ struct max8925_chip { > int irq_base; > int core_irq; > int tsc_irq; > - > unsigned intwakeup_flag; > }; > > -- > 1.7.0.4 > Acked-by: Haojian Zhuang ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-11-23 Thread Haojian Zhuang
On Tue, Nov 6, 2012 at 3:35 PM, Qing Xu wrote: > From: Qing Xu > > 1. add irqdomain for max8925, it is necessary for dt support > 2. bug fix in max8925 mfd devices'irq base and device registry failure > 3. support DT for max8925 mfd devices > > Qing Xu (7): > mfd: max8925: add irqdomain for dt

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-23 Thread Haojian Zhuang
On Tue, Nov 6, 2012 at 3:47 PM, Qing Xu wrote: > From: Qing Xu > > Signed-off-by: Qing Xu > --- > drivers/video/backlight/max8925_bl.c | 31 ++- > 1 files changed, 30 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/backlight/max8925_bl.c > b/drivers/v

Re: [PATCH 1/7] mfd: max8925: add irqdomain for dt

2012-11-23 Thread Haojian Zhuang
On Tue, Nov 6, 2012 at 3:37 PM, Qing Xu wrote: > From: Qing Xu > > Add irqdomains for max8925's main irq, and touch irq. > Wrap irq register operations into irqdomain's map func. > it is necessary for dt support. > Also, add dt support for max8925 driver. > > Signed-off-by: Qing Xu > --- > driv

Re: [PATCH 7/7] mfd: max8925: add dts

2012-11-23 Thread Haojian Zhuang
On Tue, Nov 6, 2012 at 3:49 PM, Qing Xu wrote: > From: Qing Xu > > add max8925 dts support into mmp2 brownstone platform > > Signed-off-by: Qing Xu > --- > arch/arm/boot/dts/mmp2-brownstone.dts | 166 > + > arch/arm/boot/dts/mmp2.dtsi |4 +- > 2 f

Re: [PATCH 2/7] mfd: max8925: fix mfd device register failure

2012-11-23 Thread Haojian Zhuang
On Tue, Nov 6, 2012 at 3:38 PM, Qing Xu wrote: > From: Qing Xu > > we encounter rtc/power/touch driver registry failure, root cause > it is resources confilict in insert_resouce, solved by changing > mfd_add_devices 5th parameter to NULL > Since resources are not used in power/rtc driver and touc

Re: [PATCH v2 5/9] document: devicetree: bind pinconf with pin-single

2012-10-31 Thread Haojian Zhuang
On Wed, Oct 31, 2012 at 11:26 PM, Stephen Warren wrote: > On 10/31/2012 10:58 AM, Haojian Zhuang wrote: >> On Tue, Oct 23, 2012 at 6:44 AM, Stephen Warren >> wrote: >>> 3) Why is pinctrl-single,gpio-func optional? Presumably you always need >>> to program

Re: [PATCH 08/10] pinctrl: single: support pinconf generic

2012-10-31 Thread Haojian Zhuang
On Fri, Oct 26, 2012 at 1:43 AM, Tony Lindgren wrote: > * Tony Lindgren [121022 10:11]: >> * Haojian Zhuang [121022 03:11]: >> > On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote: >> > > * Haojian Zhuang [121018 02:08]: >> > >> Add pinconf

Re: [PATCH v2 5/9] document: devicetree: bind pinconf with pin-single

2012-10-31 Thread Haojian Zhuang
On Tue, Oct 23, 2012 at 6:44 AM, Stephen Warren wrote: > On 10/22/2012 10:08 AM, Haojian Zhuang wrote: >> Add comments with pinconf & gpio range in the document of >> pinctrl-single. >> >> Signed-off-by: Haojian Zhuang >> --- >> .../devicetree

Re: [PATCH v2 2/9] pinctrl: single: support gpio request and free

2012-10-28 Thread Haojian Zhuang
On Tue, Oct 23, 2012 at 4:28 AM, Tony Lindgren wrote: > * Haojian Zhuang [121022 09:11]: >> Marvell's PXA/MMP silicon also match the behavior of pinctrl-single. >> Each pin binds to one register. A lot of pins could be configured >> as gpio. >> >> Now add

Re: [PATCH v2 2/9] pinctrl: single: support gpio request and free

2012-10-28 Thread Haojian Zhuang
On Tue, Oct 23, 2012 at 5:37 AM, Tony Lindgren wrote: > * Tony Lindgren [121022 13:29]: >> * Haojian Zhuang [121022 09:11]: >> > --- a/drivers/pinctrl/pinctrl-single.c >> > +++ b/drivers/pinctrl/pinctrl-single.c >> > @@ -28,8 +28,10 @@ >> > #defin

Re: [PATCH 08/10] pinctrl: single: support pinconf generic

2012-10-25 Thread Haojian Zhuang
On Fri, Oct 26, 2012 at 7:43 AM, Tony Lindgren wrote: > * Tony Lindgren [121022 10:11]: >> * Haojian Zhuang [121022 03:11]: >> > On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote: >> > > * Haojian Zhuang [121018 02:08]: >> > >> Add pinconf

[PATCH v2 9/9] pinctrl: single: dump pinmux register value

2012-10-22 Thread Haojian Zhuang
Dump pinmux register value, not only function part in the pinmux register. Also fix the issue on caluclating pin offset. The last parameter should be pin number, not register offset. Signed-off-by: Haojian Zhuang --- drivers/pinctrl/pinctrl-single.c |8 1 files changed, 4

[PATCH v2 8/9] i2c: pxa: configure pinmux

2012-10-22 Thread Haojian Zhuang
Configure pins by pinctrl driver. Signed-off-by: Haojian Zhuang --- drivers/i2c/busses/i2c-pxa.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 7c8b5d0..11e4a30 100644 --- a/drivers/i2c/busses/i2c

[PATCH v2 7/9] i2c: pxa: use devm_kzalloc

2012-10-22 Thread Haojian Zhuang
Use devm_kzalloc & add checking in probe() function. Signed-off-by: Haojian Zhuang --- drivers/i2c/busses/i2c-pxa.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 103

[PATCH v2 6/9] tty: pxa: configure pin

2012-10-22 Thread Haojian Zhuang
Configure pins by pinctrl driver. Signed-off-by: Haojian Zhuang --- drivers/tty/serial/pxa.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c index 9033fc6..02dc771 100644 --- a/drivers/tty/serial/pxa.c +++ b

[PATCH v2 5/9] document: devicetree: bind pinconf with pin-single

2012-10-22 Thread Haojian Zhuang
Add comments with pinconf & gpio range in the document of pinctrl-single. Signed-off-by: Haojian Zhuang --- .../devicetree/bindings/pinctrl/pinctrl-single.txt | 52 arch/arm/boot/dts/pxa910.dtsi |1 - 2 files changed, 52 insertions(+), 1 delet

[PATCH v2 4/9] ARM: dts: support pinctrl single in pxa910

2012-10-22 Thread Haojian Zhuang
Add pinctrl-single support with device tree in pxa910 dkb platform. Signed-off-by: Haojian Zhuang --- arch/arm/boot/dts/pxa910-dkb.dts | 187 +- arch/arm/boot/dts/pxa910.dtsi| 78 2 files changed, 264 insertions(+), 1 deletions

[PATCH v2 3/9] pinctrl: single: support pinconf generic

2012-10-22 Thread Haojian Zhuang
Add pinconf generic support with POWER SOURCE, BIAS PULL. Signed-off-by: Haojian Zhuang --- drivers/pinctrl/Kconfig |1 + drivers/pinctrl/pinctrl-single.c | 276 -- 2 files changed, 266 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH v2 2/9] pinctrl: single: support gpio request and free

2012-10-22 Thread Haojian Zhuang
Marvell's PXA/MMP silicon also match the behavior of pinctrl-single. Each pin binds to one register. A lot of pins could be configured as gpio. Now add three properties in below. pinctrl-single,gpio-ranges: gpio range array pinctrl-single,gpio: pinctrl-single,gpio-func: Signed-off-by: Ha

[PATCH v2 1/9] ARM: mmp: select pinctrl driver

2012-10-22 Thread Haojian Zhuang
Pinctrl driver is necessary for MMP DT & MMP2 DT platforms. Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/Kconfig |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig index 178d4da..ebdda83 100644 --- a/arch

[PATCH v2 0/9] support pinctrl single in arch pxa/mmp

2012-10-22 Thread Haojian Zhuang
Changelog: v2: 1. Remove "pinctrl-single,gpio-mask". Since GPIO function is one of the mux function in the pinmux register of both OMAP and PXA/MMP silicons. Use "pinctrl-single,function-mask" instead. 2. Remove "pinctrl-single,gpio-enable" & "pinctrl-single,gpio-disable". Use "pinctrl-single,gpio

Re: [PATCH 08/10] pinctrl: single: support pinconf generic

2012-10-22 Thread Haojian Zhuang
On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote: > * Haojian Zhuang [121018 02:08]: >> Add pinconf generic support with POWER SOURCE, BIAS PULL. > ... > >> + case PIN_CONFIG_POWER_SOURCE: >> + if (pcs->psmask == PCS_OFF_DISABLED >> +

Re: [PATCH 01/10] pinctrl: use postcore_initcall

2012-10-18 Thread Haojian Zhuang
On Fri, Oct 19, 2012 at 10:38 AM, Tony Lindgren wrote: > * Haojian Zhuang [121018 19:17]: >> On Fri, Oct 19, 2012 at 6:28 AM, Tony Lindgren wrote: >> > >> > Specifically could you decribe the cases where this issue happens? >> > Also check if one of your cl

Re: [PATCH 08/10] pinctrl: single: support pinconf generic

2012-10-18 Thread Haojian Zhuang
On Fri, Oct 19, 2012 at 6:29 AM, Tony Lindgren wrote: > * Linus Walleij [121018 11:32]: >> On Thu, Oct 18, 2012 at 11:07 AM, Haojian Zhuang >> wrote: >> >> > Add pinconf generic support with POWER SOURCE, BIAS PULL. >> > >> > Signed-off-by: Haoji

Re: [PATCH 01/10] pinctrl: use postcore_initcall

2012-10-18 Thread Haojian Zhuang
On Fri, Oct 19, 2012 at 6:28 AM, Tony Lindgren wrote: > * Stephen Warren [121018 15:20]: >> On 10/18/2012 03:06 AM, Haojian Zhuang wrote: >> > Since pins are configured in device driver, pinctrl driver should be >> > loaded by those device driver. module_plat

Re: [PATCH 05/10] i2c: pxa: use devm_kzalloc

2012-10-18 Thread Haojian Zhuang
On Fri, Oct 19, 2012 at 6:27 AM, Stephen Warren wrote: > On 10/18/2012 03:06 AM, Haojian Zhuang wrote: >> Use devm_kzalloc & add checking in probe() function. > > This patch seems unrelated to this series. In fact, the series touches a > bunch of different subsystems; woul

[PATCH 10/10] document: devicetree: bind pinconf in pinctrl single

2012-10-18 Thread Haojian Zhuang
Add comments with pinconf & gpio range in the document of pinctrl-single. Signed-off-by: Haojian Zhuang --- .../devicetree/bindings/pinctrl/pinctrl-single.txt | 43 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/pin

[PATCH 09/10] ARM: dts: support pinctrl single in pxa910

2012-10-18 Thread Haojian Zhuang
Add pinctrl-single support with device tree in pxa910 dkb platform. Signed-off-by: Haojian Zhuang --- arch/arm/boot/dts/pxa910-dkb.dts | 187 +- arch/arm/boot/dts/pxa910.dtsi| 81 2 files changed, 267 insertions(+), 1 deletions

[PATCH 08/10] pinctrl: single: support pinconf generic

2012-10-18 Thread Haojian Zhuang
Add pinconf generic support with POWER SOURCE, BIAS PULL. Signed-off-by: Haojian Zhuang --- drivers/pinctrl/Kconfig |2 +- drivers/pinctrl/pinctrl-single.c | 286 -- 2 files changed, 274 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH 07/10] pinctrl: remove mutex lock in groups show

2012-10-18 Thread Haojian Zhuang
Mutex is locked duplicatly by pinconf_groups_show() and pin_config_group_get(). It results dead lock. So avoid to lock mutex in pinconf_groups_show(). Signed-off-by: Haojian Zhuang --- drivers/pinctrl/pinconf.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 06/10] pinctrl: single: support gpio request and free

2012-10-18 Thread Haojian Zhuang
nctrl-single,gpio: pinctrl-single,gpio-enable: pinctrl-single,gpio-disable: Signed-off-by: Haojian Zhuang --- drivers/pinctrl/pinctrl-single.c | 140 +- 1 files changed, 138 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/dr

[PATCH 05/10] i2c: pxa: use devm_kzalloc

2012-10-18 Thread Haojian Zhuang
Use devm_kzalloc & add checking in probe() function. Signed-off-by: Haojian Zhuang --- drivers/i2c/busses/i2c-pxa.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index cd6

[PATCH 04/10] i2c: pxa: configure pins

2012-10-18 Thread Haojian Zhuang
Configure pins by pinctrl driver. Signed-off-by: Haojian Zhuang --- drivers/i2c/busses/i2c-pxa.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 1034d93..cd66ec2 100644 --- a/drivers/i2c/busses/i2c

[PATCH 03/10] tty: pxa: configure pin

2012-10-18 Thread Haojian Zhuang
Configure pins by pinctrl driver. Signed-off-by: Haojian Zhuang --- drivers/tty/serial/pxa.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c index 5847a4b..ee6118a 100644 --- a/drivers/tty/serial/pxa.c +++ b

[PATCH 02/10] ARM: mmp: select pinctrl driver

2012-10-18 Thread Haojian Zhuang
Pinctrl driver is necessary for MMP DT & MMP2 DT platforms. Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig index 7fddd01..c70c787 100644 --- a/arch

[PATCH 01/10] pinctrl: use postcore_initcall

2012-10-18 Thread Haojian Zhuang
Since pins are configured in device driver, pinctrl driver should be loaded by those device driver. module_platform_driver() only declares pinctrl driver is in module_initcall privilege. Use postcore_initcall privilege instead. Signed-off-by: Haojian Zhuang --- drivers/pinctrl/pinctrl-single.c

Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code

2012-09-17 Thread Haojian Zhuang
On Tue, Sep 18, 2012 at 1:43 PM, Eric Miao wrote: > On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij > wrote: >> On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: >> >>> From: Wei Yongjun >>> >>> Using for_each_set_bit() to simplify the code. >>> >>> spatch with a semantic match is used to fou

Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code

2012-09-17 Thread Haojian Zhuang
//coccinelle.lip6.fr/) >> >> Signed-off-by: Wei Yongjun > > PXA maintainers: does this look OK? > > Yours, > Linus Walleij It seems good. Acked-by: Haojian Zhuang ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] mmc: sdhci-pxa: Add device tree support

2012-06-20 Thread Haojian Zhuang
gt;  drivers/mmc/host/sdhci-pxav3.c                     |   52 +++++++ >  3 files changed, 127 insertions(+) Acked-by: Haojian Zhuang ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: Re: [PATCH] mmc: sdhci-pxa: Add device tree support

2012-06-13 Thread haojian . zhuang
On , Chris Ball wrote: Hi Zhangfei, On Tue, Jun 12 2012, zhangfei gao wrote: > On Wed, Jun 13, 2012 at 3:05 AM, Chris Ball c...@laptop.org> wrote: How do you feel about having the compatible node say "sdhci-pxav3" instead of "mrvl,pxav3-mmc"? I used the mrvl prefix because it fits in

Re: [PATCH v2 8/9] ARM: dts: refresh dts file for arch mmp

2012-06-05 Thread Haojian Zhuang
On Wed, Jun 6, 2012 at 1:22 PM, Mitch Bradley wrote: > On 6/5/2012 4:35 PM, Haojian Zhuang wrote: >> >> On Wed, Jun 6, 2012 at 9:47 AM, Mitch Bradley  wrote: >>> >>> On 6/5/2012 3:28 PM, Arnd Bergmann wrote: >>>> >>>> >>>> On

Re: [PATCH v2 8/9] ARM: dts: refresh dts file for arch mmp

2012-06-05 Thread Haojian Zhuang
On Wed, Jun 6, 2012 at 9:47 AM, Mitch Bradley wrote: > On 6/5/2012 3:28 PM, Arnd Bergmann wrote: >> >> On Tuesday 05 June 2012, Chris Ball wrote: >>> >>> Hi Haojian, >>> >>> On Fri, May 04 2012, Haojian Zhuang wrote: >>>> >>

Re: [PATCH v2 8/9] ARM: dts: refresh dts file for arch mmp

2012-06-04 Thread Haojian Zhuang
On Tue, Jun 5, 2012 at 8:08 AM, Chris Ball wrote: > Hi Haojian, > > On Fri, May 04 2012, Haojian Zhuang wrote: >> Append mmp2 and pxa910 dts files. Update PXA168 dts files for irq, >> timer, gpio components. > > The patch I'm replying to introduced a device tree

Re: [PATCH 3/9] ARM: mmp: support DT in irq

2012-05-30 Thread Haojian Zhuang
On Thu, May 31, 2012 at 3:38 AM, Chris Ball wrote: > Hi Haojian, > > > Did you test non-DT boot with these changes? > I tested non-DT boot on my brownstone board on TTC dkb board. It seems that you meet issue in icu_mux_irq_demux(). Could you give me the detail which interrupt is running while y

Re: [PATCH v2 0/9] support dt for mmp2

2012-05-17 Thread Haojian Zhuang
On Fri, May 18, 2012 at 7:57 AM, Rob Herring wrote: > On 05/04/2012 07:30 AM, Haojian Zhuang wrote: >> v2: >> 1. remove MACH_MMP_LEGACY & MACH_MMP2_LEGACY >> 2. use irq.c to replace irq-pxa168.c & irq-mmp2.c >> 3. Avoid to use CONFIG_OF in entry-macro.S >&g

[PATCH v2 9/9] Documentation: update docs for mmp dt

2012-05-04 Thread Haojian Zhuang
Append interrupt controller and timer document for mmp. Updates documents for gpio and i2c. Signed-off-by: Haojian Zhuang --- Documentation/devicetree/bindings/arm/mrvl.txt |6 --- .../devicetree/bindings/arm/mrvl/intc.txt | 40 .../devicetree/bindings

[PATCH v2 8/9] ARM: dts: refresh dts file for arch mmp

2012-05-04 Thread Haojian Zhuang
Append mmp2 and pxa910 dts files. Update PXA168 dts files for irq, timer, gpio components. Signed-off-by: Haojian Zhuang --- arch/arm/boot/dts/mmp2-brownstone.dts | 38 ++ arch/arm/boot/dts/mmp2.dtsi | 220 + arch/arm/boot/dts/pxa168.dtsi

[PATCH v2 7/9] ARM: mmp: support pxa910 with device tree

2012-05-04 Thread Haojian Zhuang
Suppot gpio/irq/timer in mmp-dt driver. Support PXA910 also in mmp-dt driver. Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/mmp-dt.c | 50 +++ 1 files changed, 40 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-mmp/mmp-dt.c b/arch/arm

[PATCH v2 6/9] ARM: mmp: support mmp2 with device tree

2012-05-04 Thread Haojian Zhuang
Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/Makefile |1 + arch/arm/mach-mmp/mmp2-dt.c | 60 +++ 2 files changed, 61 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mmp/mmp2-dt.c diff --git a/arch/arm/mach-mmp/Makefile b

[PATCH v2 5/9] gpio: pxa: parse gpio from DTS file

2012-05-04 Thread Haojian Zhuang
Parse GPIO numbers from DTS file. Allocate interrupt according to GPIO numbers. Signed-off-by: Haojian Zhuang --- drivers/gpio/gpio-pxa.c | 116 +++--- 1 files changed, 98 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers

[PATCH v2 4/9] ARM: mmp: support DT in timer

2012-05-04 Thread Haojian Zhuang
Parse timer from DTS file. Avoid to use hardcoding marco for register. Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/time.c | 81 ++ 1 files changed, 60 insertions(+), 21 deletions(-) diff --git a/arch/arm/mach-mmp/time.c b/arch/arm/mach-mmp

[PATCH v2 3/9] ARM: mmp: support DT in irq

2012-05-04 Thread Haojian Zhuang
Merge irq-pxa168 and irq-mmp2. And support device tree also. Since CONFIG_SPARSE_IRQ is enabled in arch-mmp, base irq starts from NR_IRQS_LEGACY. Signed-off-by: Haojian Zhuang --- arch/arm/Kconfig |1 + arch/arm/mach-mmp/Makefile |8

[PATCH v2 2/9] ARM: mmp: append CONFIG_MACH_MMP2_DT

2012-05-04 Thread Haojian Zhuang
Append CONFIG_MACH_MMP2_DT. CONFIG_MACH_MMP_DT is used to ARMv5 DT support. CONFIG_MACH_MMP2_DT is used to ARMv7 DT support. These two machine support can't be selected at the same time. Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/Kconfig | 29 +++-- 1

[PATCH v2 1/9] ARM: mmp: fix build issue on mmp with device tree

2012-05-04 Thread Haojian Zhuang
Since irq_domain_add_simple() is removed, remove it in mmp-dt.c also. Signed-off-by: Haojian Zhuang --- arch/arm/mach-mmp/mmp-dt.c | 22 -- 1 files changed, 0 insertions(+), 22 deletions(-) diff --git a/arch/arm/mach-mmp/mmp-dt.c b/arch/arm/mach-mmp/mmp-dt.c index 6707539

[PATCH v2 0/9] support dt for mmp2

2012-05-04 Thread Haojian Zhuang
v2: 1. remove MACH_MMP_LEGACY & MACH_MMP2_LEGACY 2. use irq.c to replace irq-pxa168.c & irq-mmp2.c 3. Avoid to use CONFIG_OF in entry-macro.S ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/device

Re: [PATCH 3/9] ARM: mmp: support DT in irq

2012-05-03 Thread Haojian Zhuang
On Wed, May 2, 2012 at 8:51 PM, Arnd Bergmann wrote: > On Wednesday 02 May 2012, Haojian Zhuang wrote: >> I use two CONFIG_OF in this file. The first one is used to record >> register base address >> of interrupt controller. In legacy code, the register address is >&

Re: [PATCH 2/9] ARM: mmp: distinguish mmp and mmp2 in Kconfig

2012-05-01 Thread Haojian Zhuang
On Sat, Apr 28, 2012 at 4:14 AM, Arnd Bergmann wrote: > On Friday 27 April 2012, Haojian Zhuang wrote: >> Append four CONFIG_* MACRO to distinguish boards in arch-mmp. >> >> CONFIG_MMP_LEGACY and CONFIG_MMP2_LEGACY are used to support boards >> without device tr

Re: [PATCH 3/9] ARM: mmp: support DT in irq

2012-05-01 Thread Haojian Zhuang
On Sat, Apr 28, 2012 at 3:06 AM, Grant Likely wrote: > On Fri, 27 Apr 2012 16:39:11 +0800, Haojian Zhuang > wrote: >> Append new interrupt driver that could support both pxa168 and mmp2 >> silicon. And this driver supports device tree. >> >> Since CONFIG_SPARSE_I

  1   2   >