https://issues.dlang.org/show_bug.cgi?id=15966
Martin Nowak changed:
What|Removed |Added
CC||c...@dawg.eu
Assignee|nob...@purema
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #2 from Martin Nowak ---
We definitely shouldn't break code, but I also don't see a reason why we should
ignore public imports in base classes. Maybe we can find the prior forum
discussion that Walter mentioned.
--
https://issues.dlang.org/show_bug.cgi?id=15966
Walter Bright changed:
What|Removed |Added
Status|NEW |RESOLVED
CC|
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #4 from Walter Bright ---
There was a PR for this: https://github.com/dlang/dmd/pull/5749
--
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #5 from Walter Bright ---
> Since we import it as protected, subclasses should be able to override
> this function without import
This is easily resolved by adding:
import core.exception : AssertError;
--
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #6 from Mathias Lang ---
(In reply to Walter Bright from comment #3)
> The trouble is that imports in the base class will override global imports
> referred to by the derived class. This is exactly the kind of problem the
> import changes
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #7 from Martin Nowak ---
(In reply to Walter Bright from comment #3)
> The trouble is that imports in the base class will override global imports
> referred to by the derived class. This is exactly the kind of problem the
> import changes
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #8 from Walter Bright ---
(In reply to Mathias Lang from comment #6)
> A base class in another module can
> already override global imports by introducing new local symbols.
The problem is if symbols are added to that import, then they h
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #9 from Walter Bright ---
(In reply to Martin Nowak from comment #7)
> Should this really apply to public imports as well?
Yes.
--
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #10 from Dicebot ---
NB: please make sure that if this is not allowed anymore, it is appropriately
covered by -transition=checkimport , as far as I know we had quite some code
relying on such behaviour as an intended feature.
--
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #11 from Mathias Lang ---
(In reply to Walter Bright from comment #8)
> (In reply to Mathias Lang from comment #6)
> > A base class in another module can
> > already override global imports by introducing new local symbols.
>
> The probl
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #12 from Martin Nowak ---
(In reply to Dicebot from comment #10)
> NB: please make sure that if this is not allowed anymore, it is
> appropriately covered by -transition=checkimport , as far as I know we had
> quite some code relying on s
https://issues.dlang.org/show_bug.cgi?id=15966
--- Comment #13 from Martin Nowak ---
Works as expected with -transition=import/checkimports and that behavior is
already covered by test cases.
--
13 matches
Mail list logo