Re: Explicit relative imports

2014-11-19 Thread Tim Graham
gt; --check-only` run with flake8. > > On Thursday, 13 November 2014 14:57:15 UTC+1, Tom Christie wrote: >> >> Contrary voice here, but I don't dig explicit relative imports, it's just >> adds an extra decision point for no real benefit. >> >> Personall

Re: Explicit relative imports

2014-11-15 Thread tomv
t; Contrary voice here, but I don't dig explicit relative imports, it's just > adds an extra decision point for no real benefit. > > Personally I always recommend full absolute imports, ordered strictly > alphabetically - there's then never any room for confusion or dec

Re: Explicit relative imports

2014-11-13 Thread Tai Lee
would recommend against any relative imports from parent packages. It should be limited to siblings only. Cheers. Tai. On Friday, 14 November 2014 00:57:15 UTC+11, Tom Christie wrote: > > Contrary voice here, but I don't dig explicit relative imports, it's just > adds an ext

Re: Explicit relative imports

2014-11-13 Thread Marc Tamlyn
s the last block at the end of the imports which further show what is "within" a component, rather than it being buried within a large block. In any case, explicit relative imports are greatly preferable to implicit ones. Marc On 13 Nov 2014 13:57, "Tom Christie" wrote: >

Re: Explicit relative imports

2014-11-13 Thread Tom Christie
Contrary voice here, but I don't dig explicit relative imports, it's just adds an extra decision point for no real benefit. Personally I always recommend full absolute imports, ordered strictly alphabetically - there's then never any room for confusion or decision making around

Re: Explicit relative imports

2014-11-12 Thread Jannis Leidel
> On 11 Nov 2014, at 22:51, Aymeric Augustin > wrote: > > Hello, > > We’ve started using explicit relative imports in newer parts of the Django > source tree. They’re short and readable. That’s good. > > I would like to add guidelines about imports in the coding

Re: Explicit relative imports

2014-11-12 Thread Aymeric Augustin
.registry import apps # NOQA > > from https://github.com/django/django/blob/master/django/apps/__init__.py > > On Tuesday, November 11, 2014 1:51:19 PM UTC-8, Aymeric Augustin wrote: >> >> Hello, >> >> We’ve started using explicit relative imports in newer part

Re: Explicit relative imports

2014-11-12 Thread Zach Borboa
ing explicit relative imports in newer parts of the Django > source tree. They’re short and readable. That’s good. > > I would like to add guidelines about imports in the coding style guide in > order to improve consistency. > > My inclination would be to recommend relative impo

Re: Explicit relative imports

2014-11-12 Thread Florian Apolloner
tin wrote: > > Hello, > > We’ve started using explicit relative imports in newer parts of the Django > source tree. They’re short and readable. That’s good. > > I would like to add guidelines about imports in the coding style guide in > order to improve consistency. > > My

Re: Explicit relative imports

2014-11-11 Thread Marc Tamlyn
I agree wholeheartedly. (Sorry, not much else to say...) On 11 November 2014 21:51, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello, > > We’ve started using explicit relative imports in newer parts of the Django > source tree. They’re short and readable.

Explicit relative imports

2014-11-11 Thread Aymeric Augustin
Hello, We’ve started using explicit relative imports in newer parts of the Django source tree. They’re short and readable. That’s good. I would like to add guidelines about imports in the coding style guide in order to improve consistency. My inclination would be to recommend relative imports